Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2835190ybd; Mon, 24 Jun 2019 13:38:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqwjWYF0t/xsDDt4QfU+86UaLSH/jXH8vUNswfBHQp21MxiVqonXXow3NWmxvvvcaLIZ9p3r X-Received: by 2002:a63:1322:: with SMTP id i34mr35382803pgl.424.1561408712832; Mon, 24 Jun 2019 13:38:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561408712; cv=none; d=google.com; s=arc-20160816; b=lmaDLZMS/+mJGhsB8v+4dom3vXKbv2n4hsZ0wQGxa66jJt2U/tgKsPRjloMBlhJQ8q rNIZ9BZ/sdeEipaGY/l6p51ExjmIuQemrOpJLCsncs8kO2LnOOz1+VXEAQYpmBxZ0msC 6PNi3abgxzoDkGy/IviMyvhAaZ2n5FQB9w/qxvnK6FmjH/q2x9LefMOuyrpWuOaxqTwJ nDTxLtu8xkpuiERDFnER0ug9dlDcOgkzUZcespHZwvx4KynJUPU+xesjBam5fQLIsZkM iAL3xAjmTXivJThwKEp2udmsk/a61O2ledcqSue1Iq9pLsAR0OmzpvOsuCsjv9mO7wow Sphg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=HKVZVeTIp0VzP4z4Uro5y3TTUO1hlLUucOTNEWyo+tU=; b=iphYDxmH/TWjrztnk5HOBDhyzPFsvZ/Jrh+e3NNhyLcggT3yOtW8UVVgYilLmNc0bF Dkx5JD+hdIx9rQGLDQXwEcgiXDCanzZCCIFmQL/kG0/5/iFAlvE+rrBCZkCZn8aJyPQI L8eBL4MXcea0GwYl9O6Ao0GCLDu1Bd0bbYR2ZQFtPbKcloUfSMZgB6Fd2v75YJz614RL nhh0+2iJFqCtP4XjfKE7gjPX+LnB19JM5GedjP0MkC8a1k8YlBG5/U217rrQpf3U3noG Fl21rzcTmOHoyLkT+RHoVKtZUFJHXempRJMhIgKKMWbZk68lNtC/wSBYyoZBB1y7V/Jn 1Baw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kqK76VCJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u33si10831998pgn.253.2019.06.24.13.38.17; Mon, 24 Jun 2019 13:38:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kqK76VCJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732360AbfFXRRC (ORCPT + 99 others); Mon, 24 Jun 2019 13:17:02 -0400 Received: from mail-io1-f44.google.com ([209.85.166.44]:39980 "EHLO mail-io1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726628AbfFXRRC (ORCPT ); Mon, 24 Jun 2019 13:17:02 -0400 Received: by mail-io1-f44.google.com with SMTP id n5so3816908ioc.7; Mon, 24 Jun 2019 10:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=HKVZVeTIp0VzP4z4Uro5y3TTUO1hlLUucOTNEWyo+tU=; b=kqK76VCJ2Tc+wIyI2JOQ/ZV6Fh/BExUX9pt0s72wbQbVVyV1s3YFexA2Gu8SlQXp/I EtwsZB2BoZlFJ983KZ+zCm7b6Hx46/GF4b2NSjWh7Cibsg0DXEe892VrJteOTB1cH4oX qtNqLS6uspEqD/Kv7ScBHkdRbALxcS/Lx/QzuVUazygm6YFZt1yG7WFkhytp0HSKX72H x0m2BId2noXj/eTO969WTKThIe7izvrU6zXhLBJ0b6nid0VrT2YnaAJLuR5+rju5cVwW mRvhGzNcNLwu+FZcbkOT1TVBV0gHEjmj9EuSB+Dy2PBTIzgnpRd31SbVOnGG3LWWElb2 D5Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HKVZVeTIp0VzP4z4Uro5y3TTUO1hlLUucOTNEWyo+tU=; b=sgl0e1leW2n3EZ7cZRckUajBpqBZtKtfiSewpfrsVKrZwt3Q9RqpL4/brTGPwTqZCk LMo3boGzDRIY2/kYnkK3SWCj4nWK83Kda4VEEKBD8/mQpSSS+Br7uJgNSUtzcZ8GWhpr gZ8SmyGCMYzlAhu8BLknD8I3jaQK9/1LDrYai9/kPb7EKNFVzp4tqg+ltiisRM222IGM ie7qhZV4T4xG+9IhjULrnsHDu72TjlVk6kcLFmm9gSuFbSyLHimquirODQsBZB0aRH8K E+PW3xAmkXrwHnHE+FB8hmfrZgI84arOHuEwV4Vp/N/RA9Yx0LTZpKD0Gz8ksM2NAGH+ hrKw== X-Gm-Message-State: APjAAAWwq5EVPbVz4LCiAcYQI9auYU3ies39Ocy23jJeBvG4fO5IeKWb r89Ek00fUj3cKyEKikz2VEZ/N2+7SHwt5bViAyw= X-Received: by 2002:a5e:8f42:: with SMTP id x2mr15878117iop.35.1561396621141; Mon, 24 Jun 2019 10:17:01 -0700 (PDT) MIME-Version: 1.0 References: <0000000000008f19f7058c10a633@google.com> <871rzj6sww.fsf@miraculix.mork.no> <87tvcf54qc.fsf@miraculix.mork.no> In-Reply-To: <87tvcf54qc.fsf@miraculix.mork.no> From: Kristian Evensen Date: Mon, 24 Jun 2019 19:16:50 +0200 Message-ID: Subject: Re: KASAN: global-out-of-bounds Read in qmi_wwan_probe To: =?UTF-8?Q?Bj=C3=B8rn_Mork?= Cc: Hillf Danton , syzbot , andreyknvl@google.com, David Miller , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Network Development , syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jun 24, 2019 at 6:26 PM Bj=C3=B8rn Mork wrote: > Doh! Right you are. Thanks to both you and Andrey for quick and good > help. > > We obviously have some bad code patterns here, since this apparently > worked for Kristian by pure luck. Thanks a lot to everyone for spotting and fixing my mistake, and sorry for not replying earlier. The patch from Bj=C3=B8rn is probably a candidate for stable as well. I don't remember exactly when the quirk was accepted in the kernel, but I recently submitted and got the quirk accepted into 4.14. BR, Kristian