Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2895772ybd; Mon, 24 Jun 2019 14:55:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqzhRgf/b9me96hkY5Oy5fVqXwM7Bglz66ZOGOphTGkw0Fz+eyyAjD/HPBjyv41eeh29K+/F X-Received: by 2002:a17:902:b594:: with SMTP id a20mr6276377pls.259.1561413339021; Mon, 24 Jun 2019 14:55:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561413339; cv=none; d=google.com; s=arc-20160816; b=ZHZixUTOs3SZxaYjwjsQYD8S1bEDNWIK0sD4gGGYAa52J5i2MjtVdKC0eJcp6KOeER 7pFgnk8mzaLg8JkJw8WNGkIqwMAZDRrLFNv69FqgnlPOqx1a4XO+p9zdG2yi/mUrUaxr +c+7DK1hKmSuCt33boa47ZNUIRNjSiJHdhzr9pQUW9UGl1NoYYC1NYUnWkuZhXw31sZt N8qIoKJMkdzahSHgAgvc09zaQMrW1URqJtDI1zuzELtBnDWRG0OXsIUtKywJNZ1/600G Dt+2AvgGs5vLVzKJvQ7yxLwcxta57kQfonM7kzJU7sqy1qrkWb58pZ2OZPJeflSdtz02 yZJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=C9sRjC6IIlagaAVZD2kVDVV7i0f7sEn0BfaZNFyhvmc=; b=cIjIJ74CyKFVb4xpFCWzeDpgn4DdTHPxFO0H2fJAIZevGGwY2xfbay6FsRxSOGW9nW t0ok/uzmzlE0oQIiavFVuXWWkgyRHaDNmKJcecvLWcivXkX+EDWZr2l2eug0lFX4p56X Ep0YAhZRVMiHrg9xyORIKkBW2eCDppSfIIlonOuGajiEvLTM3ACxbGnZh0X9sZXnHCTU 709N0EGYYxhqUmyVIN27uCbpWta1her2zeFpqNy7ZvAPvaKDksZCzIgvxYKH6g4sQnSo iD/bU/hss/S7RvD3c8nCkaAokOVy+hPeYpHiNXx6mNEgkDisA8Y1jO3IEiGCnKuu1xH8 TLFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uzCwP7P2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si4276706pgf.171.2019.06.24.14.55.23; Mon, 24 Jun 2019 14:55:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uzCwP7P2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730352AbfFXTSe (ORCPT + 99 others); Mon, 24 Jun 2019 15:18:34 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:39034 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729083AbfFXTSd (ORCPT ); Mon, 24 Jun 2019 15:18:33 -0400 Received: by mail-ed1-f66.google.com with SMTP id m10so23319862edv.6; Mon, 24 Jun 2019 12:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C9sRjC6IIlagaAVZD2kVDVV7i0f7sEn0BfaZNFyhvmc=; b=uzCwP7P2kDwXURnwxaxRt5tfLVjI/gECIOS6C8f0BuX21vytuhwhTLimOZwyNPdoiA ZQ2Z0rMOjW/uFwePL6Wa5o2OyDyKjgmrnQ0Z04wDzYXugRBrLDhlsds7ILVV0PXdOeBd 7bBZjKW+wrDk0nUq2DXCnOrZvWyDikWLGtqORIEMpWeQObauS/PUhutqlLtEsdXR13/b nUyWR57whY5bzzgCw3R+DO15MamH4aD8vhniZ840sRYC6eKkGkEfCziezFpIRldZoBav eV5aGlsvqOYn8tVvUkMemo5W83uSejgyy1a9TZErK+DMBh7YA9XmRYZWJZ58hFG7dFDp 5k7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C9sRjC6IIlagaAVZD2kVDVV7i0f7sEn0BfaZNFyhvmc=; b=Cvbsl/09hl2yNw5NAvJQJjr2Wec5w2R1vyN9QcARxit7wb6jenXoh4yXIpq9R6OWpF tcL95TjUoC5lRynznfqsFwOMlTWWHh2gSvtIJ914augFC35+Lzrv5/gbOmoOS3k1hwHP 9LBY7EBVBImTu0E0N+pyZgg58JkVfMslgzSXV56nDmO17ZM55YWUZbn153xxpgElkxMR ec78xTHqp3z5O124DLeab6eWMzybU/rYESd/26FZ38miUDQZ5SjKyCCEfzzarsk6kIcg y460jaEFrfHgbtJ5In3Td3yEIbr9gJcAVSwjf5TqU/50oUk82OzjINPTwbzvuM0jU7n3 4+fA== X-Gm-Message-State: APjAAAXYivNJzIB3YvLqDyhqewh84VPfDG1XdU/h+O1RG2ORsekfyW9O zewEKTpdWAEcmoAJ3ShkjsSc7RHoQSTiP002 X-Received: by 2002:a05:6402:14d4:: with SMTP id f20mr55248215edx.125.1561403911100; Mon, 24 Jun 2019 12:18:31 -0700 (PDT) Received: from [192.168.1.221] ([195.245.55.52]) by smtp.gmail.com with ESMTPSA id p3sm4122916eda.43.2019.06.24.12.18.28 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 12:18:30 -0700 (PDT) Subject: Re: [PATCH V2 03/15] ARM: ep93xx: cleanup cppcheck shifting errors To: Phong Tran Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com References: <20190623151313.970-1-tranmanphong@gmail.com> <20190624135105.15579-1-tranmanphong@gmail.com> <20190624135105.15579-4-tranmanphong@gmail.com> From: Alexander Sverdlin Message-ID: <9d21b4dc-4855-b203-bc31-903591d3bb0d@gmail.com> Date: Mon, 24 Jun 2019 21:16:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190624135105.15579-4-tranmanphong@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On 24/06/2019 15:50, Phong Tran wrote: > [arch/arm/mach-ep93xx/clock.c:102]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour > [arch/arm/mach-ep93xx/clock.c:132]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour > [arch/arm/mach-ep93xx/clock.c:140]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour > [arch/arm/mach-ep93xx/core.c:1001]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour > [arch/arm/mach-ep93xx/core.c:1002]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour Acked-by: Alexander Sverdlin > Signed-off-by: Phong Tran > --- > arch/arm/mach-ep93xx/soc.h | 132 ++++++++++++++++++++++----------------------- > 1 file changed, 66 insertions(+), 66 deletions(-) > > diff --git a/arch/arm/mach-ep93xx/soc.h b/arch/arm/mach-ep93xx/soc.h > index f2dace1c9154..250c82f8b0a1 100644 > --- a/arch/arm/mach-ep93xx/soc.h > +++ b/arch/arm/mach-ep93xx/soc.h > @@ -109,89 +109,89 @@ > #define EP93XX_SYSCON_REG(x) (EP93XX_SYSCON_BASE + (x)) > #define EP93XX_SYSCON_POWER_STATE EP93XX_SYSCON_REG(0x00) > #define EP93XX_SYSCON_PWRCNT EP93XX_SYSCON_REG(0x04) > -#define EP93XX_SYSCON_PWRCNT_FIR_EN (1<<31) > -#define EP93XX_SYSCON_PWRCNT_UARTBAUD (1<<29) > -#define EP93XX_SYSCON_PWRCNT_USH_EN (1<<28) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2M1 (1<<27) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2M0 (1<<26) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2P8 (1<<25) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2P9 (1<<24) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2P6 (1<<23) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2P7 (1<<22) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2P4 (1<<21) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2P5 (1<<20) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2P2 (1<<19) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2P3 (1<<18) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2P0 (1<<17) > -#define EP93XX_SYSCON_PWRCNT_DMA_M2P1 (1<<16) > +#define EP93XX_SYSCON_PWRCNT_FIR_EN BIT(31) > +#define EP93XX_SYSCON_PWRCNT_UARTBAUD BIT(29) > +#define EP93XX_SYSCON_PWRCNT_USH_EN BIT(28) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2M1 BIT(27) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2M0 BIT(26) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2P8 BIT(25) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2P9 BIT(24) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2P6 BIT(23) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2P7 BIT(22) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2P4 BIT(21) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2P5 BIT(20) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2P2 BIT(19) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2P3 BIT(18) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2P0 BIT(17) > +#define EP93XX_SYSCON_PWRCNT_DMA_M2P1 BIT(16) > #define EP93XX_SYSCON_HALT EP93XX_SYSCON_REG(0x08) > #define EP93XX_SYSCON_STANDBY EP93XX_SYSCON_REG(0x0c) > #define EP93XX_SYSCON_CLKSET1 EP93XX_SYSCON_REG(0x20) > -#define EP93XX_SYSCON_CLKSET1_NBYP1 (1<<23) > +#define EP93XX_SYSCON_CLKSET1_NBYP1 BIT(23) > #define EP93XX_SYSCON_CLKSET2 EP93XX_SYSCON_REG(0x24) > -#define EP93XX_SYSCON_CLKSET2_NBYP2 (1<<19) > -#define EP93XX_SYSCON_CLKSET2_PLL2_EN (1<<18) > +#define EP93XX_SYSCON_CLKSET2_NBYP2 BIT(19) > +#define EP93XX_SYSCON_CLKSET2_PLL2_EN BIT(18) > #define EP93XX_SYSCON_DEVCFG EP93XX_SYSCON_REG(0x80) > -#define EP93XX_SYSCON_DEVCFG_SWRST (1<<31) > -#define EP93XX_SYSCON_DEVCFG_D1ONG (1<<30) > -#define EP93XX_SYSCON_DEVCFG_D0ONG (1<<29) > -#define EP93XX_SYSCON_DEVCFG_IONU2 (1<<28) > -#define EP93XX_SYSCON_DEVCFG_GONK (1<<27) > -#define EP93XX_SYSCON_DEVCFG_TONG (1<<26) > -#define EP93XX_SYSCON_DEVCFG_MONG (1<<25) > -#define EP93XX_SYSCON_DEVCFG_U3EN (1<<24) > -#define EP93XX_SYSCON_DEVCFG_CPENA (1<<23) > -#define EP93XX_SYSCON_DEVCFG_A2ONG (1<<22) > -#define EP93XX_SYSCON_DEVCFG_A1ONG (1<<21) > -#define EP93XX_SYSCON_DEVCFG_U2EN (1<<20) > -#define EP93XX_SYSCON_DEVCFG_EXVC (1<<19) > -#define EP93XX_SYSCON_DEVCFG_U1EN (1<<18) > -#define EP93XX_SYSCON_DEVCFG_TIN (1<<17) > -#define EP93XX_SYSCON_DEVCFG_HC3IN (1<<15) > -#define EP93XX_SYSCON_DEVCFG_HC3EN (1<<14) > -#define EP93XX_SYSCON_DEVCFG_HC1IN (1<<13) > -#define EP93XX_SYSCON_DEVCFG_HC1EN (1<<12) > -#define EP93XX_SYSCON_DEVCFG_HONIDE (1<<11) > -#define EP93XX_SYSCON_DEVCFG_GONIDE (1<<10) > -#define EP93XX_SYSCON_DEVCFG_PONG (1<<9) > -#define EP93XX_SYSCON_DEVCFG_EONIDE (1<<8) > -#define EP93XX_SYSCON_DEVCFG_I2SONSSP (1<<7) > -#define EP93XX_SYSCON_DEVCFG_I2SONAC97 (1<<6) > -#define EP93XX_SYSCON_DEVCFG_RASONP3 (1<<4) > -#define EP93XX_SYSCON_DEVCFG_RAS (1<<3) > -#define EP93XX_SYSCON_DEVCFG_ADCPD (1<<2) > -#define EP93XX_SYSCON_DEVCFG_KEYS (1<<1) > -#define EP93XX_SYSCON_DEVCFG_SHENA (1<<0) > +#define EP93XX_SYSCON_DEVCFG_SWRST BIT(31) > +#define EP93XX_SYSCON_DEVCFG_D1ONG BIT(30) > +#define EP93XX_SYSCON_DEVCFG_D0ONG BIT(29) > +#define EP93XX_SYSCON_DEVCFG_IONU2 BIT(28) > +#define EP93XX_SYSCON_DEVCFG_GONK BIT(27) > +#define EP93XX_SYSCON_DEVCFG_TONG BIT(26) > +#define EP93XX_SYSCON_DEVCFG_MONG BIT(25) > +#define EP93XX_SYSCON_DEVCFG_U3EN BIT(24) > +#define EP93XX_SYSCON_DEVCFG_CPENA BIT(23) > +#define EP93XX_SYSCON_DEVCFG_A2ONG BIT(22) > +#define EP93XX_SYSCON_DEVCFG_A1ONG BIT(21) > +#define EP93XX_SYSCON_DEVCFG_U2EN BIT(20) > +#define EP93XX_SYSCON_DEVCFG_EXVC BIT(19) > +#define EP93XX_SYSCON_DEVCFG_U1EN BIT(18) > +#define EP93XX_SYSCON_DEVCFG_TIN BIT(17) > +#define EP93XX_SYSCON_DEVCFG_HC3IN BIT(15) > +#define EP93XX_SYSCON_DEVCFG_HC3EN BIT(14) > +#define EP93XX_SYSCON_DEVCFG_HC1IN BIT(13) > +#define EP93XX_SYSCON_DEVCFG_HC1EN BIT(12) > +#define EP93XX_SYSCON_DEVCFG_HONIDE BIT(11) > +#define EP93XX_SYSCON_DEVCFG_GONIDE BIT(10) > +#define EP93XX_SYSCON_DEVCFG_PONG BIT(9) > +#define EP93XX_SYSCON_DEVCFG_EONIDE BIT(8) > +#define EP93XX_SYSCON_DEVCFG_I2SONSSP BIT(7) > +#define EP93XX_SYSCON_DEVCFG_I2SONAC97 BIT(6) > +#define EP93XX_SYSCON_DEVCFG_RASONP3 BIT(4) > +#define EP93XX_SYSCON_DEVCFG_RAS BIT(3) > +#define EP93XX_SYSCON_DEVCFG_ADCPD BIT(2) > +#define EP93XX_SYSCON_DEVCFG_KEYS BIT(1) > +#define EP93XX_SYSCON_DEVCFG_SHENA BIT(0) > #define EP93XX_SYSCON_VIDCLKDIV EP93XX_SYSCON_REG(0x84) > -#define EP93XX_SYSCON_CLKDIV_ENABLE (1<<15) > -#define EP93XX_SYSCON_CLKDIV_ESEL (1<<14) > -#define EP93XX_SYSCON_CLKDIV_PSEL (1<<13) > +#define EP93XX_SYSCON_CLKDIV_ENABLE BIT(15) > +#define EP93XX_SYSCON_CLKDIV_ESEL BIT(14) > +#define EP93XX_SYSCON_CLKDIV_PSEL BIT(13) > #define EP93XX_SYSCON_CLKDIV_PDIV_SHIFT 8 > #define EP93XX_SYSCON_I2SCLKDIV EP93XX_SYSCON_REG(0x8c) > -#define EP93XX_SYSCON_I2SCLKDIV_SENA (1<<31) > -#define EP93XX_SYSCON_I2SCLKDIV_ORIDE (1<<29) > -#define EP93XX_SYSCON_I2SCLKDIV_SPOL (1<<19) > +#define EP93XX_SYSCON_I2SCLKDIV_SENA BIT(31) > +#define EP93XX_SYSCON_I2SCLKDIV_ORIDE BIT(29) > +#define EP93XX_SYSCON_I2SCLKDIV_SPOL BIT(19) > #define EP93XX_I2SCLKDIV_SDIV (1 << 16) > #define EP93XX_I2SCLKDIV_LRDIV32 (0 << 17) > #define EP93XX_I2SCLKDIV_LRDIV64 (1 << 17) > #define EP93XX_I2SCLKDIV_LRDIV128 (2 << 17) > #define EP93XX_I2SCLKDIV_LRDIV_MASK (3 << 17) > #define EP93XX_SYSCON_KEYTCHCLKDIV EP93XX_SYSCON_REG(0x90) > -#define EP93XX_SYSCON_KEYTCHCLKDIV_TSEN (1<<31) > -#define EP93XX_SYSCON_KEYTCHCLKDIV_ADIV (1<<16) > -#define EP93XX_SYSCON_KEYTCHCLKDIV_KEN (1<<15) > -#define EP93XX_SYSCON_KEYTCHCLKDIV_KDIV (1<<0) > +#define EP93XX_SYSCON_KEYTCHCLKDIV_TSEN BIT(31) > +#define EP93XX_SYSCON_KEYTCHCLKDIV_ADIV BIT(16) > +#define EP93XX_SYSCON_KEYTCHCLKDIV_KEN BIT(15) > +#define EP93XX_SYSCON_KEYTCHCLKDIV_KDIV BIT(0) > #define EP93XX_SYSCON_SYSCFG EP93XX_SYSCON_REG(0x9c) > #define EP93XX_SYSCON_SYSCFG_REV_MASK (0xf0000000) > #define EP93XX_SYSCON_SYSCFG_REV_SHIFT (28) > -#define EP93XX_SYSCON_SYSCFG_SBOOT (1<<8) > -#define EP93XX_SYSCON_SYSCFG_LCSN7 (1<<7) > -#define EP93XX_SYSCON_SYSCFG_LCSN6 (1<<6) > -#define EP93XX_SYSCON_SYSCFG_LASDO (1<<5) > -#define EP93XX_SYSCON_SYSCFG_LEEDA (1<<4) > -#define EP93XX_SYSCON_SYSCFG_LEECLK (1<<3) > -#define EP93XX_SYSCON_SYSCFG_LCSN2 (1<<1) > -#define EP93XX_SYSCON_SYSCFG_LCSN1 (1<<0) > +#define EP93XX_SYSCON_SYSCFG_SBOOT BIT(8) > +#define EP93XX_SYSCON_SYSCFG_LCSN7 BIT(7) > +#define EP93XX_SYSCON_SYSCFG_LCSN6 BIT(6) > +#define EP93XX_SYSCON_SYSCFG_LASDO BIT(5) > +#define EP93XX_SYSCON_SYSCFG_LEEDA BIT(4) > +#define EP93XX_SYSCON_SYSCFG_LEECLK BIT(3) > +#define EP93XX_SYSCON_SYSCFG_LCSN2 BIT(1) > +#define EP93XX_SYSCON_SYSCFG_LCSN1 BIT(0) > #define EP93XX_SYSCON_SWLOCK EP93XX_SYSCON_REG(0xc0) > > /* EP93xx System Controller software locked register write */