Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <aba1c363-92de-66d7-4aac-b555f398e70a@alvarezp.org>
 <2cf2f745-0e29-13a7-6364-0a981dae758c@alvarezp.org> <alpine.DEB.2.21.1906132229540.1791@nanos.tec.linutronix.de>
 <95539fd9-ffdb-b91c-935f-7fd54d048fdf@alvarezp.org> <alpine.DEB.2.21.1906221523340.5503@nanos.tec.linutronix.de>
 <alpine.DEB.2.21.1906231448540.32342@nanos.tec.linutronix.de> <098de4c3-5f71-f84d-8b49-d2f43e18ed91@alvarezp.org>
In-Reply-To: <098de4c3-5f71-f84d-8b49-d2f43e18ed91@alvarezp.org>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue, 25 Jun 2019 03:48:45 +0800
Message-ID: <CAHk-=wgwKVnod6a030iRDWTbkV_no+ggRzMUFAws0iEbYe=jqw@mail.gmail.com>
Subject: Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation
To:     Octavio Alvarez <octallk1@alvarezp.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
        Jiang Biao <jiang.biao2@zte.com.cn>,
        Yi Wang <wang.yi59@zte.com.cn>,
        Dou Liyang <douly.fnst@cn.fujitsu.com>,
        Nicolai Stange <nstange@suse.de>,
        Mirko Lindner <mlindner@marvell.com>,
        Stephen Hemminger <stephen@networkplumber.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 25, 2019 at 1:08 AM Octavio Alvarez <octallk1@alvarezp.org> wrote:
>
> If I boot regularly (disable_msi not set) and then do modprobe -r sky2;
> modprobe sky2 disable_msi=1, the problem stays (when back from
> hibernation, the NIC does not work).

Side note: some distros end up unloading and reloading modules over suspend.

I wonder if perhaps your system does that, and then when it resumes it
has reloaded the sky2 driver, but without your manual "disable_msi=1"?

Because it sounds odd that it would work with the kernel command line
but not manually, and so I wonder if perhaps there's a hidden module
unload/load that causes that second case..

              Linus