Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2898875ybd; Mon, 24 Jun 2019 15:00:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqw728SwKGwhiEQpoCTAQgg56rTyWRFICNcXYp3tdXdptM09JGAcNv3u5xhgl2alsCuFBxh/ X-Received: by 2002:a63:d847:: with SMTP id k7mr17530644pgj.283.1561413604482; Mon, 24 Jun 2019 15:00:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561413604; cv=none; d=google.com; s=arc-20160816; b=CVeQNdUlvalXRDFG0Hs0qeNVOq8oaw3YU06v+zxzQI18Cjj12X4EWx/AUASdzhWekf QdN39nKrniZCBwvYJgXZe47lUv+k8DqvQlQWa2C5tSuBGhdTNXDdimAN6J0XqK2gODMw 7V2Ffg359FyjnORXE8vlra/bfeFSHTznG/t+BMkPr68XrO3Lq9npsXAhN1I6U4PGPfQj xbnrJsirw4MaokV4t8CMOWBjPILWHt+xD3787kGQYtsaFhIhB37DEPb1mWTjTGLIYSRh yosy7vp3vyqApo25V9XRMaM//ZUf3eqOREzsf/TLtnXL/g8GPvdm3nvsPYy3sEWhQgUF rjug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=NZu4O00NPZleuCWXITSxnWW1rGLa66653MvVC+wHLmw=; b=F/wehSedH8KHAXNOXzHJqm6p7znPPHSBE91lhHm1GtCu9wpPKX8IednJR6uxSNeXG6 aZoPebIEe5UlhLe0IJeHkKEcuW/T+9/PfcEnxEOndynQvE70AjFlqochkkRca0UYDVIA 52qma+I9PiigHULADgXncIE/pwGpfIz4w5et0NcoJh1MRpYKYAuHaB4HI/+OM822XKJN ycTi05rdxpoNShWTXAALtVU73j5Sz/NOkQGn6gBSqms2Wt+OrQq8fLufH+PVDwy3APeU Omq5Byx0k2Xh8qG/HUMqz0P5VxtCsnfeq605aNRojHzA/XT1eUXdeVLcuxlEvLakAZ5j lcsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jVeSXiVs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m45si674401pje.39.2019.06.24.14.59.49; Mon, 24 Jun 2019 15:00:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jVeSXiVs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731158AbfFXTtk (ORCPT + 99 others); Mon, 24 Jun 2019 15:49:40 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:40722 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728549AbfFXTtj (ORCPT ); Mon, 24 Jun 2019 15:49:39 -0400 Received: by mail-io1-f66.google.com with SMTP id n5so4834940ioc.7; Mon, 24 Jun 2019 12:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NZu4O00NPZleuCWXITSxnWW1rGLa66653MvVC+wHLmw=; b=jVeSXiVsHVu2ouD9U37An682AZzAmmkFDiJ+LkM6/EftdC972P9MeMDquhfc5L4lZL j18MoUvN4XjKZXE8rOAlSmSh2ypQaGsQoNcsFVIgUXlQDhNWGg0oUi9l+paz44faPa3+ 7pEB3QBX417I/pQ+SqxPYr+HKmEHMeM8Jy5nKjXEC88TEMrlxO01uMszzLY9Li5eIOBt q+Kju30heEn6reuItzwtS+hr+qVrMPOrn7MbwoleSpbDniuYdJtHhFZjPnTmf+jmD8MS lf4UlMnZew435rZg9jB3TiwL33OJLG1VQlSaLpWEO+3P/OpW1E6aF9XKP52g89geYsfX dVqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NZu4O00NPZleuCWXITSxnWW1rGLa66653MvVC+wHLmw=; b=lVkKH6ziGeWS1YGXBuqHOtlS9aX0D0bfhylGJLDaCRUHKPVZHgJc35bRMzFVU9I9Iy d9wMRe/sl203f7mIHlWTJ8jF+Yxacew2uvGMrF2KCAmngs2LgzhHZy218MYnpdmveql1 aIygR8Zt+e32kG13S0ABGNHuAPq5PPiKJOOCKnooD+vvjMXAlBEJ4/kGptRGQfeAOy65 Md7Z6TvAwneX1otjyc8wqJ/LOsqNPZedrZo6QLsCSVOXf99yIZbYCqghmnAScR0MeLuE nImUctd4ODJCNivC35jtxJA0qjtCEoutL0EktM7fOCOhBcTxRw+IqJL+3+eKpCYiSjPW bwVw== X-Gm-Message-State: APjAAAU6FcO0+uY658J2mBXMPS1vyjIaKdxq37+Xx0QBjzo8oUzBepBE IDBS7bPx2mJ96jGHJB69j/BQp5Mi X-Received: by 2002:a5e:8508:: with SMTP id i8mr17447890ioj.108.1561405778305; Mon, 24 Jun 2019 12:49:38 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:f558:9f3d:eff4:2876? ([2601:282:800:fd80:f558:9f3d:eff4:2876]) by smtp.googlemail.com with ESMTPSA id e188sm18389354ioa.3.2019.06.24.12.49.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 12:49:37 -0700 (PDT) Subject: Re: [PATCH net-next] ipv4: enable route flushing in network namespaces To: Christian Brauner , davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20190624132923.16792-1-christian@brauner.io> From: David Ahern Message-ID: <56ed92eb-14db-789a-c226-cdf8a5862e61@gmail.com> Date: Mon, 24 Jun 2019 13:49:33 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190624132923.16792-1-christian@brauner.io> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/24/19 7:29 AM, Christian Brauner wrote: > Tools such as vpnc try to flush routes when run inside network > namespaces by writing 1 into /proc/sys/net/ipv4/route/flush. This > currently does not work because flush is not enabled in non-initial > network namespaces. > Since routes are per network namespace it is safe to enable > /proc/sys/net/ipv4/route/flush in there. > > Link: https://github.com/lxc/lxd/issues/4257 > Signed-off-by: Christian Brauner > --- > net/ipv4/route.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > why not teach vpnc to use rtnetlink and then add a flush option to RTM_DELROUTE?