Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     allanzhang <allanzhang@google.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin Lau <kafai@fb.com>, Yonghong Song <yhs@fb.com>,
        "David S. Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/2] bpf: Allow bpf_skb_event_output for more prog
 types
Thread-Topic: [PATCH v3 0/2] bpf: Allow bpf_skb_event_output for more prog
 types
Thread-Index: AQHVKuikUE/omfxviUSX95ATQSfH9KarfDQA
Date:   Tue, 25 Jun 2019 00:00:35 +0000
Message-ID: <C74526B1-7426-4F84-A5D3-DA444A17CFCD@fb.com>
References: <20190624235720.167067-1-allanzhang@google.com>
In-Reply-To: <20190624235720.167067-1-allanzhang@google.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3A32A135E791AF4CB3FE11154083D599@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d7412e4b-6c41-4849-0858-08d6f9002636
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2019 00:00:35.3543
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: songliubraving@fb.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1773
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-24_16:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=994 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1906240189
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jun 24, 2019, at 4:57 PM, allanzhang <allanzhang@google.com> wrote:
>=20
> Software event output is only enabled by a few prog types right now (TC,
> LWT out, XDP, sockops). Many other skb based prog types need
> bpf_skb_event_output to produce software event.
>=20
> Added socket_filter, cg_skb, sk_skb prog types to generate sw event.
>=20
> *** BLURB HERE ***
    ^^^^^^ this should be removed.=20

Please include bpf-next in the subject prefix.=20
Please also include changes from v1 to v2 and v2 to v3 in the cover=20
letter, like:

changes v1 =3D> v2:
1. ...
2. ...

Thanks,
Song


>=20
> allanzhang (2):
>  bpf: Allow bpf_skb_event_output for a few prog types
>  bpf: Add selftests for bpf_perf_event_output
>=20
> net/core/filter.c                             |  6 ++
> tools/testing/selftests/bpf/test_verifier.c   | 33 ++++++-
> .../selftests/bpf/verifier/event_output.c     | 94 +++++++++++++++++++
> 3 files changed, 132 insertions(+), 1 deletion(-)
> create mode 100644 tools/testing/selftests/bpf/verifier/event_output.c
>=20
> --=20
> 2.22.0.410.gd8fdbe21b5-goog
>=20