Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3179275ybd; Mon, 24 Jun 2019 21:05:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqxXfxmKK/JD/egkILphv1Iqj5WymUvPdDUNn78oLl3jOeyPqgBj/u5+pmidf6EOKWNwx9L6 X-Received: by 2002:a63:1c09:: with SMTP id c9mr27689258pgc.63.1561435549870; Mon, 24 Jun 2019 21:05:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561435549; cv=none; d=google.com; s=arc-20160816; b=Uil6UzpJLL9+J7SUEisdnEHEfdshjrGj9zQ+ZkFsnw3ibP9q6ay1w85sjNuwfPkGgE uPz3NPhMSsWMXydSrs6WiMss1eT0n/WiSVEVeasD+hcbIysXIwbfxNb1ienl72ItJ6MJ K9rFloiUuu6bIAn1w+EraLfzz+znTvMbdXJQ/z2SJrElsS+dLBDV8SHVewJ/kUroEXas /ZAgfzwUjo3PAoakyvXDAj53U208Axudxe51aafZ25uUP8eMKcMncm6dAL1b9EuqmpoP crLHXfTgkC+dvcbVgUFMafEUtM6qHpXPWmqcX5c6ts9a7rnCJCC0wK+hFABP7Ui7hRfm BpMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:smtp-origin-cluster:cc:to :smtp-origin-hostname:from:smtp-origin-hostprefix:dkim-signature; bh=EqtD9pgjSn3RpeCA8R1A7DD1Wom8eSWCEiXrtl71yV4=; b=K0yEDW5O9L+wGWavMY+JVOf1PFL8fMkwemj7Yij9kCQFBnx+y4BNE5b5jky0Iz53b6 NZbfifVxmzCpujKikOMbwgqpb5t29a0v27myJwthcnbeWWc3OetQg7+rk4PuSOOzYTjF h+it7hUthMvYwo+mumaF3LcWQDz6TJIfidUFfNTmhflaK7dDnXPD7n6PO4kThUGdpYzq Cugqju2r8OlnLK3J2fnjRF37PLp/F918R3xyWonn1N35MNErksJ2UrxFauf3tKBJWKRX +J2oP1m7i6K0X7cz62uc12FwslfmJ2ICYXh8+EhADliZMcCHTL9T5QqFte8wrcqWpAiu CH7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=Xn8tQ4Ka; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a20si12251840pgw.306.2019.06.24.21.05.34; Mon, 24 Jun 2019 21:05:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=Xn8tQ4Ka; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729587AbfFYANI (ORCPT + 99 others); Mon, 24 Jun 2019 20:13:08 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:48272 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729531AbfFYAM7 (ORCPT ); Mon, 24 Jun 2019 20:12:59 -0400 Received: from pps.filterd (m0109334.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5P08SIu029551 for ; Mon, 24 Jun 2019 17:12:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=facebook; bh=EqtD9pgjSn3RpeCA8R1A7DD1Wom8eSWCEiXrtl71yV4=; b=Xn8tQ4KaSTAaKIrmEDK3g/qzHWbvSllORMtOv+5HabJUKfKEJ0HB8+eoHS3xJ4uFOPSZ y2S8Ruf83O1MB6fgymW4amomT+HuhZMUrVvHB5llYgz5qJE2UPUrG5ToGfp8bRoB9rrj DnUANIts4NU0oCOdc8XJK+Deh959QBDK+EA= Received: from mail.thefacebook.com (mailout.thefacebook.com [199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2tb56ugu40-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 24 Jun 2019 17:12:58 -0700 Received: from mx-out.facebook.com (2620:10d:c081:10::13) by mail.thefacebook.com (2620:10d:c081:35::126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.1.1713.5; Mon, 24 Jun 2019 17:12:56 -0700 Received: by devbig006.ftw2.facebook.com (Postfix, from userid 4523) id 924A462E206E; Mon, 24 Jun 2019 17:12:52 -0700 (PDT) Smtp-Origin-Hostprefix: devbig From: Song Liu Smtp-Origin-Hostname: devbig006.ftw2.facebook.com To: , , CC: , , , , , , Song Liu Smtp-Origin-Cluster: ftw2c04 Subject: [PATCH v9 1/6] filemap: check compound_head(page)->mapping in filemap_fault() Date: Mon, 24 Jun 2019 17:12:41 -0700 Message-ID: <20190625001246.685563-2-songliubraving@fb.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190625001246.685563-1-songliubraving@fb.com> References: <20190625001246.685563-1-songliubraving@fb.com> X-FB-Internal: Safe MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-24_16:,, signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=924 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250000 X-FB-Internal: deliver Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, filemap_fault() avoids trace condition with truncate by checking page->mapping == mapping. This does not work for compound pages. This patch let it check compound_head(page)->mapping instead. Acked-by: Rik van Riel Signed-off-by: Song Liu --- mm/filemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/filemap.c b/mm/filemap.c index df2006ba0cfa..f5b79a43946d 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2517,7 +2517,7 @@ vm_fault_t filemap_fault(struct vm_fault *vmf) goto out_retry; /* Did it get truncated? */ - if (unlikely(page->mapping != mapping)) { + if (unlikely(compound_head(page)->mapping != mapping)) { unlock_page(page); put_page(page); goto retry_find; -- 2.17.1