Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3182270ybd; Mon, 24 Jun 2019 21:09:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqyj4n6lUfTvlFknRvBu2v/GqOk+a2t7jVQ/Z8pIwl5DSh3f+/b3nBF/95NXM8SRR0g820Gm X-Received: by 2002:a17:902:20c8:: with SMTP id v8mr16527428plg.284.1561435795041; Mon, 24 Jun 2019 21:09:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561435795; cv=none; d=google.com; s=arc-20160816; b=LGZKDFoWTW4C4Bhao9bRArt398CuC06yyDYK7z1Bx9uFSqSugk/OgY5TS2H/Y3qDuO WsWuIbmYRjb4iseZy1twQKmEMW23F0rx4JSNLJDRVPR5rLGlOfplSlQAWlOL6UsK/pg3 ktw5nKTbkTGLBe5O8BPkdgVv8D6W1PFKSfXlZbq5k/bJwBbiNKPcwB/zOmga9nh3Evde NTBX+F+GMoFy+sDd0kFhMveaO8gbsw/fmI78GrlyY3O4xiANEFkdM1xaMlgABuwdATOC SaZE0B2G2Am3MgIzeKxwe7D4QZPQch6qaAHR3ACuLPQII9PewNHYntO4kb0/RBQSWMQ/ xBeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id; bh=j8UQCveMRn0+TfYxNozLyOg1xHTDysYUuUIewWXlcqY=; b=L33vSrlZuU0YsFJY8YfMdUSgS5321rmcPifLrOPWp78UwAMupUg8bbu7K2fXdhDXfI ERRxWZ58akJeXkyxMpNDdYNOjy8X00xtr0SbKLTnMdKnPNIkFSePAhEp8C8ZdK0HRxBa fKn5vL769ur2A2VBYNGzLnNISJiPk70aCqZeRkPT6X9rgVNsokRR42FYXLVyp7W5fZ+w QzjyRnZX6g539Jw+zt3ga07Igcsf5a8Qz/Gwmi708/mV8rfxt4MppnEZI9aJbQNPuXgD IWZv2OVO3+VqFDvInUCRusFiySC745ZiKSEXySvocD0Qnw/sVysrF62mrR4RpNg3yHMq ECDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z23si12137723plo.160.2019.06.24.21.09.39; Mon, 24 Jun 2019 21:09:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730170AbfFYBti convert rfc822-to-8bit (ORCPT + 99 others); Mon, 24 Jun 2019 21:49:38 -0400 Received: from mga03.intel.com ([134.134.136.65]:38509 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729450AbfFYBti (ORCPT ); Mon, 24 Jun 2019 21:49:38 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jun 2019 18:49:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,413,1557212400"; d="scan'208";a="172192735" Received: from lftan-mobl.gar.corp.intel.com (HELO ubuntu) ([10.226.248.93]) by orsmga002.jf.intel.com with SMTP; 24 Jun 2019 18:49:35 -0700 Received: by ubuntu (sSMTP sendmail emulation); Tue, 25 Jun 2019 09:49:34 +0800 Message-ID: <1561427374.3131.2.camel@intel.com> Subject: Re: [PATCH] nios2: remove pointless second entry for CONFIG_TRACE_IRQFLAGS_SUPPORT From: Ley Foon Tan To: Masahiro Yamada , Ley Foon Tan , nios2-dev@lists.rocketboards.org Cc: Linux Kernel Mailing List Date: Tue, 25 Jun 2019 09:49:34 +0800 In-Reply-To: References: <1557666733-19527-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2019-06-23 at 23:13 +0900, Masahiro Yamada wrote: > On Sun, May 12, 2019 at 10:16 PM Masahiro Yamada > wrote: > > > > > > Strangely enough, NIOS2 defines TRACE_IRQFLAGS_SUPPORT twice > > with different values, which is pointless and confusing. > > > > [1] arch/nios2/Kconfig > > > >   config TRACE_IRQFLAGS_SUPPORT > >           def_bool n > > > > [2] arch/nios2/Kconfig.debug > > > >   config TRACE_IRQFLAGS_SUPPORT > >           def_bool y > > > > [1] is included before [2]. In the Kconfig syntax, the first one > > is effective. So, TRACE_IRQFLAGS_SUPPORT is always 'n'. > > > > The second define in arch/nios2/Kconfig.debug is dead code. > > > > Signed-off-by: Masahiro Yamada > > --- > Ping. > > Acked-by: Ley Foon Tan Will integrate to next kernel version. Thanks. > > > >  arch/nios2/Kconfig.debug | 3 --- > >  1 file changed, 3 deletions(-) > > > > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug > > index f1da8a7..a8bc06e 100644 > > --- a/arch/nios2/Kconfig.debug > > +++ b/arch/nios2/Kconfig.debug > > @@ -1,8 +1,5 @@ > >  # SPDX-License-Identifier: GPL-2.0 > > > > -config TRACE_IRQFLAGS_SUPPORT > > -       def_bool y > > - > >  config EARLY_PRINTK > >         bool "Activate early kernel debugging" > >         default y > > -- > > 2.7.4 > > > > -- > Best Regards > Masahiro Yamada > > ________________________________ Regards Ley Foon