Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3186597ybd; Mon, 24 Jun 2019 21:15:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwc0DwVu3hoXzgBciIQRU3JIJgTrHpmLKrtdEOp9Sq59pGtNkf1fpfDOTpDdpr2LteG7AkK X-Received: by 2002:a17:902:8f81:: with SMTP id z1mr84279224plo.290.1561436143303; Mon, 24 Jun 2019 21:15:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561436143; cv=none; d=google.com; s=arc-20160816; b=GtQ38VuBxKN2lRGI0uei/KgeWlJZ7drrj4Jw78rVWLo1jo2dNkMp031a0+GNgeWPd7 plKxA2XMXxUGp9vVMyVOURtWYli9gIHh1VVJeuBaSRatzMK8KLXvdbnM9qh21ic+WA3y I1nzCINreelDNcsTPpFwe+Z9hyjW9sHWhINnu8vAV8Sw9hjeogJXW4cKlDHmIyWpoYjm /CMqd5JqC+9EPIxnl/nDC3O9B/PWga9bZZ71oHEvpsAKHCY2aglnF8DdXkaowNz2GLJ3 /DDOiR6+NQUaXZxlafAra7g7wSj7gb2ds5c48twBPB28vygl6jDiwRpFnRgxpXkOnrv0 YI+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Pgcd3Tm429ZLWd6lJtXW8d5c5D+gerN2QIPFhZ+ISK8=; b=I5siLuHPhLzKlKdbW9QIaHm0c1iqiBIzWrzik6CZaKF981jCv7ne6VELkt5uWx8sHl 515P1aTfbsXeTcTYNtpxHbSFJWmFQb/f34hse7bbtSA8z580xDjF1OGZ3c7QQpuiBdVY nnolYpuG4qu0dOE6Fi+uWb68Lc5ohyOg60FGyEcnMfi96Fe6tudUpmUhCR3+8ThU+h16 bsA9vteeSIp2I/nDKy4Ns4Uh0Qv6/rSOe2t8kgGKejuHB9K9EigwwYEDTETAp/5IF6GN SjE7tcWDCZKZnT10GF8XNWw1XWDE3yaJttONsRjbVePH0YpwwD3C+asotdpG9sjLYv7a m1bw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Zy0hx9p/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w33si12311381pgl.158.2019.06.24.21.15.27; Mon, 24 Jun 2019 21:15:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Zy0hx9p/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727138AbfFYDxj (ORCPT + 99 others); Mon, 24 Jun 2019 23:53:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:35768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726833AbfFYDxj (ORCPT ); Mon, 24 Jun 2019 23:53:39 -0400 Received: from localhost (unknown [116.226.249.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 993EB20863; Tue, 25 Jun 2019 03:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561434818; bh=LiKh1y/cVsCqNr8ux7WO7aEmLV31ud+AQ1bb0n+nvNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zy0hx9p/4crxzYjV1lRLmNA6srJEKNhjem7iURpTiZ6qZyykyJc4xvBjgFbuwsPBI LqUfYd9yJiH2pbvvMsA9I0JwKIbT8dhPcmzYkOFmPoWMn7kF9t4f7XcbUxpiVYvfOZ 70aqqAWKidJgfsmOQAnggYhLnpqxyh1bIcGdE/QQ= Date: Tue, 25 Jun 2019 11:08:07 +0800 From: Greg KH To: liaoweixiong Cc: Miquel Raynal , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Vignesh Raghavendra , Boris Brezillon , Frieder Schrempf , Peter Pan , Chuanhong Guo , Schrempf Frieder , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Message-ID: <20190625030807.GA11074@kroah.com> References: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read returns with 0. > > Signed-off-by: liaoweixiong > Reviewed-by: Boris Brezillon > Reviewed-by: Frieder Schrempf > Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") > --- > drivers/mtd/nand/spi/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.