Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3350605ybd; Tue, 25 Jun 2019 00:46:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqy5QkDf1Z6Mn53q0n3kax87I6um9VqzBoKMItKGC62k28lvoeIIFI0NdK0+dTh8Ws8Qu1O7 X-Received: by 2002:a17:90a:9905:: with SMTP id b5mr30882348pjp.70.1561448793156; Tue, 25 Jun 2019 00:46:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561448793; cv=none; d=google.com; s=arc-20160816; b=csSo9GkUls7QVcYF2F0ju5n2d87WTOzv2giQlbsrgyhTQ5g3MebnVvJh7ggMsiMSMj e+TbIGgUMI6tBSE1Krji/nenPeuof2uyZ/HsdXkdjujl2fsGUr3CDlJ5/0DyxUBDD9CA cLXRtx8ea75h2pqwdAAPCb6HIuHt7udOTSGWaY7OJ5fbYtlIgSYTva0ZmGlo4E53vWb4 yO2qerIALoDTkee5XHeh/+w1ZP/1RBTvDTx9DgGwCQFvmqnjgChbKl5W4tzoj9y+HFBf x4Q9JSivpBdlS9iXvCrcOAHlseWjQerKbUmjwG87q+lnxD4k9+SsvlZGb1BK8qDVEIeb a1aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=ok7tjC/s65Dh2AmYyHgCRrUA7U3gt65vgzwOeqThZoQ=; b=pqkOMFNOtEM3UCHlP2R14RZJCQsbEwnBikU4w5qJiDIvioyrA2O5J84D5cqpLT6iEk aeVkfBBgdFss5JCz939KrCHK/MVwFoYONcxc2BK5xDaSve7eCl00ENQnb5/rmOopY0hV xfeBK0Uw9MAaMjQ4uN3g8lZqdZOXb3fSg/6C/UhEJ7lLFhtncVW7cn9d9xxBHm2eLfrc RPyk1uA12JiuuIZ468PcXTnReuyxxoGW6T0JVQl2LDP0FbwYR5yS67DDlZlbkLDSM302 gCVPVmxYe/LGEWKKPerBFF6FYn7vJAvqxhmjTKCyXTI8NyVrRf+SFEQAti13wivzgy78 wm3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q3si2428312pjb.1.2019.06.25.00.46.17; Tue, 25 Jun 2019 00:46:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727400AbfFYGxa (ORCPT + 99 others); Tue, 25 Jun 2019 02:53:30 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:40766 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbfFYGxa (ORCPT ); Tue, 25 Jun 2019 02:53:30 -0400 Received: from p5b06daab.dip0.t-ipconnect.de ([91.6.218.171] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hffKS-0006Ua-Pm; Tue, 25 Jun 2019 08:53:20 +0200 Date: Tue, 25 Jun 2019 08:53:19 +0200 (CEST) From: Thomas Gleixner To: Paul Cercueil cc: Daniel Lezcano , Ralf Baechle , Paul Burton , James Hogan , Jonathan Corbet , Michael Turquette , Stephen Boyd , Jason Cooper , Marc Zyngier , Lee Jones , Mathieu Malaterre , od@zcrc.me, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-doc@vger.kernel.org, linux-clk@vger.kernel.org, Artur Rojek Subject: Re: [PATCH v13 07/13] clocksource: Add a new timer-ingenic driver In-Reply-To: <20190624225759.18299-8-paul@crapouillou.net> Message-ID: References: <20190624225759.18299-1-paul@crapouillou.net> <20190624225759.18299-8-paul@crapouillou.net> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jun 2019, Paul Cercueil wrote: > + > +struct ingenic_soc_info { > + unsigned int num_channels; > +}; > + > +struct ingenic_tcu { > + struct regmap *map; > + struct clk *timer_clk, *cs_clk; > + > + unsigned int timer_channel, cs_channel; > + struct clock_event_device cevt; > + struct clocksource cs; > + char name[4]; > + > + unsigned long pwm_channels_mask; > +}; As in the irq driver. Aside of that: Reviewed-by: Thomas Gleixner