Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3354762ybd; Tue, 25 Jun 2019 00:52:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxO3zkxc5dtmQbD6Ax8l3R5w8xUyE+w7/wGs7euvcdTv3cfs2J7m8Dj1RFB4J9ikOAR4R1r X-Received: by 2002:a63:f957:: with SMTP id q23mr38036242pgk.326.1561449122619; Tue, 25 Jun 2019 00:52:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561449122; cv=none; d=google.com; s=arc-20160816; b=nEjaxrpZJrG/xUBp9eRfBIH+S5UryQX5COiqqvmW16195SJtThq0zNHFuDujb5q13s yQjrIDXaiLnBZk3dT8K81YDCxXj4tjtVgW0byxGRM2BmjvAgezazTBfyIwp7ZA3yFm1j /TJiFJoB94UsrQZkV1aW62AOS28TG8dsVgq10p4TQi0U6wCiHN+AbTDGekG4yqQW9eXA 3Nzo/OahAEPS+F2IgGl541u636TVjvtZXMDiSMHIke7kqHgfziNpEag5vvnSbGGK7Ire rENK+Dm5LVBpyVbU3RuVHvGlHr+TY93U2Oq4FG6PLdlpKjWNlzUJNMyxJ2Nu9SGxdwDn z6WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=fiDfl6thwhLhapszwH9MhDWa2YeJyq81IolM/b0PlzA=; b=ZcgewNvrbaq1TH0/HR19ZuL8CyYTpSJHDDykYvRF35OYfgfudk3n4i5EsohZ4AThZX HuINws+FJlef1VMc/l1f7ATtz7Crx64c1VowuiCDB3+4VgEbRxTbUORZTdDaFwgl9FW3 2HZfVyQG9Sv0azMsLd9tX/L30U5EKtrj83KJ+ZebgFLDFkmTC5+XxMqA5dcn11GlhezL YrJxYD51Nn5Da9bNR5NfXQ0daupm2L1WBkqz2auu5Ut/JhSafTvrl/4IUvE+cqZT0bYg tPop0wAAWLy4afIIVJLgKSilyEcLPrahbLOJyCfCgLDOhHYJtU13vPcLVDlNkhB4htVU eBJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31si3949063plc.356.2019.06.25.00.51.46; Tue, 25 Jun 2019 00:52:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728311AbfFYH3t (ORCPT + 99 others); Tue, 25 Jun 2019 03:29:49 -0400 Received: from verein.lst.de ([213.95.11.211]:60293 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727781AbfFYH3s (ORCPT ); Tue, 25 Jun 2019 03:29:48 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 0839568B02; Tue, 25 Jun 2019 09:29:16 +0200 (CEST) Date: Tue, 25 Jun 2019 09:29:15 +0200 From: Christoph Hellwig To: Michal Hocko Cc: Christoph Hellwig , Dan Williams , =?iso-8859-1?B?Suly9G1l?= Glisse , Jason Gunthorpe , Ben Skeggs , linux-mm@kvack.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-nvdimm@lists.01.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 18/22] mm: mark DEVICE_PUBLIC as broken Message-ID: <20190625072915.GD30350@lst.de> References: <20190613094326.24093-1-hch@lst.de> <20190613094326.24093-19-hch@lst.de> <20190620192648.GI12083@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190620192648.GI12083@dhcp22.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 20, 2019 at 09:26:48PM +0200, Michal Hocko wrote: > On Thu 13-06-19 11:43:21, Christoph Hellwig wrote: > > The code hasn't been used since it was added to the tree, and doesn't > > appear to actually be usable. Mark it as BROKEN until either a user > > comes along or we finally give up on it. > > I would go even further and simply remove all the DEVICE_PUBLIC code. I looked into that as I now got the feedback twice. It would create a conflict with another tree cleaning things up around the is_device_private defintion, but otherwise I'd be glad to just remove it. Jason, as this goes through your tree, do you mind the additional conflict?