Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3657974ybd; Tue, 25 Jun 2019 06:25:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqxh/E5HidsNCbv4eir47QP5pKCdPBA6Cy7+a9BKUQ8i67GdM+LmsFTJ7krpxaKL+hbTj+v/ X-Received: by 2002:a17:902:848b:: with SMTP id c11mr131934467plo.217.1561469128719; Tue, 25 Jun 2019 06:25:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561469128; cv=none; d=google.com; s=arc-20160816; b=xUdhlStyJ8qLJi+UZL+0mwoRII5vgH22ip6i6zWkhRt2wS59ffvhXnjoZtpsj/02m6 xpeHYQFvC3YwTeza2vrW1o/cT81prjNNCjoo/MhWwh1Pwo5isSCbJqtxPy7vy4z1F6cl LAHLbzkCG4HIzWrhk81D2xD+ecwiKXo+UUcSZCL9vCpeIGSVGlRW91Qv5jKzfVw0Trho gYRPOX8nqMiHd6MpUpqLGf8dEv5I9UQnWAZWW+dHYs+nTHlcBAe+N9aa41FGQjGliCSJ y7QZxbnO3HGcJLI/nBcRj34lIHM/xH3WvMvYg/xRnib3TTV8NwXnSdV1mmW7NBuMHdKV GZrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=46xVGVLTAE3fAQKOK5jMESGhBpOCvpTFPKWWFStKR74=; b=skNyb495l2RFGpA0nyIDfhhvzTHTcr8MEdib9yXHbNgj0egHyi0cZzGFkKjG8Cm3DQ GEjtPDhsppClY7EjnomseORXd8393nUVeOnQ80hlXXEVm42KghsfyOY2jsY4kbrdnaeW 4AkIK/flQjHnQDx3tOSEWaCwpagwtzW9YvzBJMPemga6qomIrSw92mHRaFi5zn8hAlOd AgCRcETOy2NE1nWCQOaaMQMBD7q3Vs2tMs4WiHocpPBHPwEc5PfqcprDhTjVhpKONJW6 PL65h4QBLpQSWvKOAq6T+jRkKo1Ir/tmZt+ERSCRtQWdV9XtNTOFZnFr9DMM3YQwiPlo ZOcg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z21si13422488pgf.268.2019.06.25.06.25.12; Tue, 25 Jun 2019 06:25:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729972AbfFYMUh (ORCPT + 99 others); Tue, 25 Jun 2019 08:20:37 -0400 Received: from mga03.intel.com ([134.134.136.65]:62516 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726930AbfFYMUh (ORCPT ); Tue, 25 Jun 2019 08:20:37 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2019 05:20:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,415,1557212400"; d="scan'208";a="155494457" Received: from um.fi.intel.com (HELO localhost) ([10.237.72.63]) by orsmga008.jf.intel.com with ESMTP; 25 Jun 2019 05:20:33 -0700 From: Alexander Shishkin To: Peter Zijlstra , Mark Rutland Cc: Arnaldo Carvalho de Melo , Ingo Molnar , linux-kernel@vger.kernel.org, jolsa@redhat.com, dvyukov@google.com, namhyung@kernel.org, xiexiuqi@huawei.com, syzbot+a24c397a29ad22d86c98@syzkaller.appspotmail.com, alexander.shishkin@linux.intel.com Subject: Re: [PATCH] perf: Fix race between close() and fork() In-Reply-To: <20190625104320.GZ3463@hirez.programming.kicks-ass.net> References: <278ac311-d8f3-2832-5fa1-522471c8c31c@huawei.com> <20190228140109.64238-1-alexander.shishkin@linux.intel.com> <20190308155429.GB10860@lakrids.cambridge.arm.com> <20190624121902.GE3436@hirez.programming.kicks-ass.net> <20190625084904.GY3463@hirez.programming.kicks-ass.net> <20190625104320.GZ3463@hirez.programming.kicks-ass.net> Date: Tue, 25 Jun 2019 15:20:33 +0300 Message-ID: <87h88dvotq.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > Solve it by using the fact that detached events still have a reference > count on their (previous) context. With this perf_event_free_task() > can detect when events have escaped and wait for their destruction. > > Cc: Mark Rutland > Fixes: 82d94856fa22 ("perf/core: Fix lock inversion between perf,trace,cpuhp") > Reported-by: syzbot+a24c397a29ad22d86c98@syzkaller.appspotmail.com > Debugged-by: Alexander Shishkin > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Alexander Shishkin Regards, -- Alex