Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3673094ybd; Tue, 25 Jun 2019 06:39:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqz6E/LPAfl3+cGAWK+0rAfn+fJBh9h6PyvEuuP+7mMBt5WM0o5ZqV02PdIBEuBKQakMLNY7 X-Received: by 2002:a63:c34c:: with SMTP id e12mr3454783pgd.195.1561469966664; Tue, 25 Jun 2019 06:39:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561469966; cv=none; d=google.com; s=arc-20160816; b=jQNFLKRDi7O8LHgsprqA4iD2E6VS9fFg5JlXGgHLWnvgVhBDFQY2JZ1rSBFSOf9mtT kWYp1WLDCWYycY3CrDz8Od9RXaRM/2s4fdrhnXqk5HTem2CuKjBOMLFmh9njfO4r1KuJ 9uPia6/7p1A7iJpb9vbRSpjeHkJ1dpW2fDVfZgpWWdsKxVv63r1hX28xEQmr25ndTfqa yBoK4lYvkkj4i6vwd3RFiBGvxbc07omwwXVh8Qn7wA6nIHP9E+wyWqWz/XH/ul14LFR1 4qHC2APoXzQJ5KJBP/QLdh3VEP0ejmarL6P/Cz59mgOCL53QcZK+O+P654c0O5UTy8vG mw5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=+6fRTFRavMlHhdR4WuKIvOPt/02vR/mrLxZMGRMmfsU=; b=o640R06zfa7oUHyRe8K7eNO//VLRcYim8AsTF78mdxMnKq8ttsYQNL14/bgcbyBEPq ZZ876/nxvSQub2jhH8NuuHxXz5C7L7A7Yd+hMy8EBVDOPgEYSOEdpczJa5BC7pWlblHV a/NB0gjPT1vvGpPtzEqEOxHrZ+xR5zzFzMNSlGAsDBvvRIML5hlYzjI/zj0UjgmWskkM CtFB4gcdwMVphCpuYxSY49jNJXwgq0JyMEiH1qSQhuNT48fqCwTPfAzNlfXgIX8xtnUg jWK4OpW9QBFQYaiphzgD+OFqh3Mr8RMm5UYKt3ePxrgvmr+WPmHu6uykIjR9XVmF74oR Q2rA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p5si357705plk.244.2019.06.25.06.39.11; Tue, 25 Jun 2019 06:39:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729923AbfFYNCP (ORCPT + 99 others); Tue, 25 Jun 2019 09:02:15 -0400 Received: from mga02.intel.com ([134.134.136.20]:36148 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727916AbfFYNCO (ORCPT ); Tue, 25 Jun 2019 09:02:14 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2019 06:02:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,415,1557212400"; d="scan'208";a="184480030" Received: from pbossart-mobl3.igk.intel.com (HELO [10.237.142.180]) ([10.237.142.180]) by fmsmga004.fm.intel.com with ESMTP; 25 Jun 2019 06:02:11 -0700 Subject: Re: [alsa-devel] [PATCH v2 00/11] Fix driver reload issues To: Mark Brown , =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Jie Yang , Cezary Rojewski , linux-kernel@vger.kernel.org References: <20190617113644.25621-1-amadeuszx.slawinski@linux.intel.com> <20190625120450.GR5316@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: Date: Tue, 25 Jun 2019 08:02:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190625120450.GR5316@sirena.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/25/19 7:04 AM, Mark Brown wrote: > On Mon, Jun 17, 2019 at 01:36:33PM +0200, Amadeusz Sławiński wrote: >> Hi, >> >> This series of patches introduces fixes to various issues found while >> trying to unload all snd* modules and then loading them again. This >> allows for modules to be really _modules_ and be unloaded and loaded on >> demand, making it easier to develop and test them without constant >> system reboots. > > Pierre? You did comment on the general concept in one of the patches > but not on any of the patches directly. I did review the patches internally and the v1. For the v2 I could only do an airport lounge review and didn't see any blatant issues, so feel free to take the following tag for the series. Reviewed-by: Pierre-Louis Bossart