Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3702904ybd; Tue, 25 Jun 2019 07:07:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqz0iMNeHvS3MwuV4awiVuLuVhy3UOA8havRCOH4P3E78njqLP6CYso17JCgwT+wnfMDtcz3 X-Received: by 2002:a17:90a:2247:: with SMTP id c65mr31051364pje.24.1561471620248; Tue, 25 Jun 2019 07:07:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561471620; cv=none; d=google.com; s=arc-20160816; b=ZoGvXb+c3Y1PMdvWwqEQOVqSA7uWCVaFrwjTdG1aaku7aNp8egRVjI5Gh4jabC8pO0 NkOdwSQDnLUNqAUGuTmEKPcMq7i8g0K/hoO7xbI8HI9MgUb7WBSs7EmzpPKiE6ErGUfj aPrd+9pgZroGMKvCHFeptwxxUjsyOZNiT5/6nrF9RrPCuJjB/drTk54H2xs8mET3u2eC T/pWowQ8CfJWJGKyPCeOsi58VBnCU2fhJb0LNpBWsj1sdwCBDT1QulUD28NUyD/qJgIB ZEOE7JcSy3j5IgXAiwt8FGLQzUKLwLDMJq4ZT2wYYG1L1JsUam8Oj0cJBbvLx57mwdyg 9AwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=6pIIC3jytWsmntojJM5beMPwkkISJ/lE+BJnG08AcnU=; b=KtE0FWmtYi3fBrxngxJwXiJZ801eACYgtLA1KMnwrLZBPIIxiNkNzp2O0ryZNK9Erk h4KcxUKVhYZWmtODynDHVXcwImImf7FOymHfHH+IJfJMKtsQHq2V3lfH0sLYwX6OaYr+ t/TgizdShuSgEe6Mwbd/ATtHY14MSnu4tdbX7UsHygneO0DR8BqVl9YI1hiTtLej87ih IbgOJJBTsZQMbFpQKNQQYi15gN2uhTdY5XkUvT09E9T4Lxc8fEYhaT0mwg8DVEUCqImz tzr3mTMSdZsjSd6g8abibP4iFGFPj4l8cxfxmPHyEK24K6cS3sUXxZUAk+yuodVW6l7c rkbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mRU4gBCr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z3si407810plo.159.2019.06.25.07.06.44; Tue, 25 Jun 2019 07:07:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mRU4gBCr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727913AbfFYOEh (ORCPT + 99 others); Tue, 25 Jun 2019 10:04:37 -0400 Received: from mail-yb1-f193.google.com ([209.85.219.193]:38095 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727730AbfFYOEh (ORCPT ); Tue, 25 Jun 2019 10:04:37 -0400 Received: by mail-yb1-f193.google.com with SMTP id l10so4174237ybj.5 for ; Tue, 25 Jun 2019 07:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6pIIC3jytWsmntojJM5beMPwkkISJ/lE+BJnG08AcnU=; b=mRU4gBCrfg1gioLKe8ve3oGpbXdbfnB/ITSmqUQ9RcKXPtDFqmjktz9gM9ltsUh+wg yUOjr6uBYr3ljB+H8Qpntj89LzaLJ8o3QlvN9SRou/ztu9mINIl4ZYYaTN4BJuuYlANb Ut0kJmWvQM9BgB5orcacPdtvxfMMYeSgbJvugc/6SVKkKeNPc9WXLZlNEwSzV7Jyz7dw D2YbmYBouyrHwbDsgfzL+et32rsvUyNbdFc2SUx5jusN9rhLxCH4jZgtjKHlro+olg7q B0MwiYxTbk+3sGmNj0ndHj6Tn9PKidy1jzuvBQtDn3VADbLLRGWJqFTBKEe1779CkJhT 49Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6pIIC3jytWsmntojJM5beMPwkkISJ/lE+BJnG08AcnU=; b=gqCwinxap4uNMALLlSRwkU30nnUkmHMWfHU0AMAF8x0TX+lImpktnfhoioorKbo1jt pEgUURXokIp+xwbsGc6b4zFy2ufbV8IGTDFEYKWBxX6MK0OypY3wRbcAA3fnkF5mQ38X IVa6MpMqVW+QzZrgdXUGm7ojawCatCAvvrV76V1q0V9HaCg1b/F+r44EGKbM7VUriKfY Wceje5KowVJr4NnwJFDOgtu80xHTuXZ9p46WlCxcKII0krSYyTsUgD3vXXnnLvw+PO7C W+uAToWvZp/o4zyQ2EUwT2gM3MQPMt0xxGSNaBvWlt8mfJctcMTDWehg9D6uvSusrB8m GW6g== X-Gm-Message-State: APjAAAXn2gYY3xomVsgrKOf+RRKp9aWM84JdooFDy0pJaJSo77p/fD8y Nl8VE6vCsHKQBGxYETeZpGOp6AlJ X-Received: by 2002:a25:9cc4:: with SMTP id z4mr84857029ybo.187.1561471475342; Tue, 25 Jun 2019 07:04:35 -0700 (PDT) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id i84sm459189ywi.0.2019.06.25.07.04.33 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jun 2019 07:04:34 -0700 (PDT) Received: by mail-yb1-f177.google.com with SMTP id j8so5422350ybo.12 for ; Tue, 25 Jun 2019 07:04:33 -0700 (PDT) X-Received: by 2002:a25:99c4:: with SMTP id q4mr11512887ybo.390.1561471473136; Tue, 25 Jun 2019 07:04:33 -0700 (PDT) MIME-Version: 1.0 References: <20190625125048.28849-1-houweitaoo@gmail.com> In-Reply-To: <20190625125048.28849-1-houweitaoo@gmail.com> From: Willem de Bruijn Date: Tue, 25 Jun 2019 10:03:56 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] can: mcp251x: add error check when wq alloc failed To: Weitao Hou Cc: Wolfgang Grandegger , Marc Kleine-Budde , David Miller , Greg Kroah-Hartman , allison@lohutok.net, tglx@linutronix.de, sean@geanix.com, linux-can@vger.kernel.org, Network Development , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 25, 2019 at 8:51 AM Weitao Hou wrote: > > add error check when workqueue alloc failed, and remove > redundant code to make it clear > > Signed-off-by: Weitao Hou Acked-by: Willem de Bruijn