Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp4029121ybd; Tue, 25 Jun 2019 12:44:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqyG0S12aJfBCgV4Sq++Ir6P+vQ9lZ26DDo6dG5JqLga+qauB3u7IPU1LDSfKE/HqRWMu/9T X-Received: by 2002:a17:90a:24ac:: with SMTP id i41mr597391pje.124.1561491897588; Tue, 25 Jun 2019 12:44:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561491897; cv=none; d=google.com; s=arc-20160816; b=cR9OsiyulYpqj362tMnWhgGX0jNNOZruz0HHFkl2SVQkd092QvaP0YlD4dxj6zfee+ zfQ25y5Dmd4iJLPZwOVcPPXSnf4wsh5ynH86B6MeJJgYAjI2/JWHELUEYegjvIMpxNFm 51QKyD3voTcx5SS6EaLD8Lh8cAGua8cKJNklW2YJyn3rLIbUpsxYlHLBrmva1yojdjlg lfQIBqwv6dUVdXNpqsxSn02zA4VMAeH5nrpnh7W3zESQZ5+XEMFsVQmItaOUF5zSt1j1 mHvrSeZw/gJU38pJ+y5QvgKAS7WK0zKsKovOpBV9RLRqqLHgk0ITA3zq4Ipbl3f2Eb0+ I0Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=0IALFvP+WvJQb52l0sHgRnwhhAIe1dzk9fo2L6noQPk=; b=G1UVrE7VJ0tXFc7kxa6KYj2jfx8pvwInlflVOs+wbMLHSFzUsIWdWo9BydBLGryFzZ LSAL0CL/aorDcjZR8RnCQRhFBPG9gQOjCUsthpi6qrVK1/TOZcv57pfEX4kGILD0MrbA 8jwRxMXlo2/5/2ivXpD6UusEol8oXk5wlNn/xXRlR/jraXjOtIKy7ViyjF+Cz7QDqrRC jZxSeSz4vwuNCcc5ST/vttuAnC18TdEyuASHZVlETJ1UYQ8LlyBA6/3QeZ5o+jJr/0zj HU3QlIjNaOSuiUwrD1iFpgTOMIWGW063PMzoRgZL+Pw4jWS/+c60gBDrJKB38P4SHwOa zo0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si1000964plk.388.2019.06.25.12.44.42; Tue, 25 Jun 2019 12:44:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730981AbfFYRFk (ORCPT + 99 others); Tue, 25 Jun 2019 13:05:40 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:34074 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727215AbfFYRF1 (ORCPT ); Tue, 25 Jun 2019 13:05:27 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id ED25EFB02; Tue, 25 Jun 2019 19:05:23 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ILinwd_cVNSn; Tue, 25 Jun 2019 19:05:22 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 59B7648E34; Tue, 25 Jun 2019 19:05:19 +0200 (CEST) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Nicolas Ferre , "Paul E. McKenney" , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Purism Kernel Team Subject: [PATCH 2/4] drm/panel: jh057n0090: Don't use magic constant Date: Tue, 25 Jun 2019 19:05:17 +0200 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 0xBF isn't in any ST7703 data sheet so mark it as unknown. This avoids confusion on whether there is a missing command in that dsi_generic_write_seq() call. Signed-off-by: Guido Günther --- drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c index 6dcb692c4701..b8a069055fbc 100644 --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c @@ -33,6 +33,7 @@ #define ST7703_CMD_SETEXTC 0xB9 #define ST7703_CMD_SETMIPI 0xBA #define ST7703_CMD_SETVDC 0xBC +#define ST7703_CMD_UNKNOWN0 0xBF #define ST7703_CMD_SETSCR 0xC0 #define ST7703_CMD_SETPOWER 0xC1 #define ST7703_CMD_SETPANEL 0xCC @@ -94,7 +95,7 @@ static int jh057n_init_sequence(struct jh057n *ctx) msleep(20); dsi_generic_write_seq(dsi, ST7703_CMD_SETVCOM, 0x3F, 0x3F); - dsi_generic_write_seq(dsi, 0xBF, 0x02, 0x11, 0x00); + dsi_generic_write_seq(dsi, ST7703_CMD_UNKNOWN0, 0x02, 0x11, 0x00); dsi_generic_write_seq(dsi, ST7703_CMD_SETGIP1, 0x82, 0x10, 0x06, 0x05, 0x9E, 0x0A, 0xA5, 0x12, 0x31, 0x23, 0x37, 0x83, 0x04, 0xBC, 0x27, 0x38, -- 2.20.1