Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 25 Jun 2019 13:15:49 -0500
From:   Segher Boessenkool <segher@kernel.crashing.org>
To:     Mathieu Malaterre <malat@debian.org>
Cc:     Michael Ellerman <mpe@ellerman.id.au>,
        Joel Stanley <joel@jms.id.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib/mpi: fix build with clang
Message-ID: <20190625181549.GK7313@gate.crashing.org>
References: <20190621071342.17897-1-malat@debian.org> <20190621195555.20615-1-malat@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190621195555.20615-1-malat@debian.org>
User-Agent: Mutt/1.4.2.3i
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Mathieu,

On Fri, Jun 21, 2019 at 09:55:54PM +0200, Mathieu Malaterre wrote:
> Remove superfluous casts on output operands to avoid warnings on the
> following macros:
> 
> * add_ssaaaa(sh, sl, ah, al, bh, bl)
> * sub_ddmmss(sh, sl, ah, al, bh, bl)
> * umul_ppmm(ph, pl, m0, m1)

The patch is fine of course, but you might want to look at not using
these asm macros at all: GCC can handle multi-word arithmetic just fine
by itself, probably better than these macros do even.


Segher