Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp4047071ybd; Tue, 25 Jun 2019 13:06:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwk5AXpRqtrPi2mhcEqwLQ1CflLGViGSLKEN7rljCyQRG1PGKB/n7dz5ZX+KBpSeVQM08Ri X-Received: by 2002:a17:90a:9289:: with SMTP id n9mr687794pjo.35.1561493159970; Tue, 25 Jun 2019 13:05:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561493159; cv=none; d=google.com; s=arc-20160816; b=E8SVJogvYm7bxhXziwbn5JDyOEBhchFjbdMR4JSw8xjmaZ3LpUj5Jr63d/4YZDZ6QB BV1qfriCAYvWW5divRv4z7KFbF0GFw9s3iobCscyNrkChPINkrE4N9mm0FZzBgi2eA8w SFvIQW3sp7UCROP0o4/1GvHX5CqndiMaOVH+fcGni2ZKEPjk85DSNwEJUXlhkIwdLR33 3BJ4I5piAdDWriyZRxb0JVz8CUCkHlmoHEScoyvgU4d5OYo4KRVzYyvpPoDSUf9bPaqF ERFfbFGmskHbRV1vAWctChvIqOkPb6PC89ETAsFFVN/xyVH2nptpgZsM4JWcOxujieyi ltrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=dsBBwV3Zcu1wx2aezrNHO+Zc37ak5evW+h92UPtV6mE=; b=zHnTbKiSWSSoQ3CtNWRTqL1+nAUk+YNcM47RNmEmxBtPnx2N1hAKEK9lf5FadqeQ4L 7YP+vFIoq2YZmplBpMhkOwGFIt4yyYoJ3W7WkJyb7VyOpq57ADu426S1LelGCroTLyua kkHw+anyADuYxbgp+06OCfeU0RfLxaIplpClsYhrosxpThxpLWwXAl2zbHkCGR7dD5RH N/UMI6wYjVC4Tdf/0L8Lndu2sXQi1yJScXNdMincaw6dgOkpPAUwq9dk+qtDMW9AXrUo i8RrBkq1QUpsmj/p1oCzjB7br2+tm9yLJTIVDxRZ3ASZFCAx8DcMOQCGdf+kcpZ9Lx65 1lJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1si72343pjr.47.2019.06.25.13.05.43; Tue, 25 Jun 2019 13:05:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728986AbfFYT7W (ORCPT + 99 others); Tue, 25 Jun 2019 15:59:22 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50018 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726455AbfFYT7W (ORCPT ); Tue, 25 Jun 2019 15:59:22 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 96697126A2097; Tue, 25 Jun 2019 12:59:21 -0700 (PDT) Date: Tue, 25 Jun 2019 12:59:21 -0700 (PDT) Message-Id: <20190625.125921.1977351433337983702.davem@davemloft.net> To: devel@etsukata.com Cc: gregkh@linuxfoundation.org, jslaby@suse.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/2] net/ipv6: Fix misuse of proc_dointvec "skip_notify_on_dev_down" From: David Miller In-Reply-To: <20190625030801.24538-2-devel@etsukata.com> References: <20190625030801.24538-1-devel@etsukata.com> <20190625030801.24538-2-devel@etsukata.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 25 Jun 2019 12:59:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eiichi Tsukata Date: Tue, 25 Jun 2019 12:08:01 +0900 > /proc/sys/net/ipv6/route/skip_notify_on_dev_down assumes given value to be > 0 or 1. Use proc_dointvec_minmax instead of proc_dointvec. > > Fixes: 7c6bb7d2faaf ("net/ipv6: Add knob to skip DELROUTE message ondevice down") > Signed-off-by: Eiichi Tsukata Applied.