Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp4048072ybd; Tue, 25 Jun 2019 13:07:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqz646xhI5q25CtyY12rRRBs8781hBOE980HYVTT5gLUO4fmCSXCY/v2PbAtG0nAvT1IyeLD X-Received: by 2002:a17:902:a03:: with SMTP id 3mr527718plo.302.1561493226448; Tue, 25 Jun 2019 13:07:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561493226; cv=none; d=google.com; s=arc-20160816; b=sXVNUf3yfrCblaszA9l1gmBxA+cnAqUVzj9NpDlDej20/rUYVZUSNe0Cxx8NdEJsdI RWYOMddznYHDP3snvKQ/oju3O/4rqMryam8Y0H6hsVsdvEoDU+jpGDfxLXcTUSlelAF1 8V1zS7vwUtWcLY7ctTCZD979Z8hRy5tsmsVtDOlGRVgnktMnd6uGkxQuBMtrFPJAXjgs LBqpXAYKKXNCr24Ner1QV+HYkaI/Doyd80Ocu5HEoxlU5LPZNeyxac/GWiFUkiKE38H5 62z9Igu56pDF3CKikJknA6KosS0ibVVy4BIXypL4BPEr7OZVVD27mrT3nzQZDIRM9lZ/ xSrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RTShSTj5/FpTVgIWgu2/oFhLVrp3kVnO6Lz9E5kxwQM=; b=AhjqvoOWPfwsXsB3SgbGd0tha/+RktIlCSPHDnYhL1UIXhrJKAZ7wOHTroRVWtheG5 fRE/t9DnNB2AiAGqQI4FXUZ7emjzkUd70/Lc5QWlb0KErtztty0QVsym/2VLSJvpKze/ poAjxxGrnNqXqXuhakFSd3hJfsu3VrIU8GvA2PArZpL/NhvdQ0fFFyIsXt1CuBW3YpNt aA3aFdaaVdQwOC1dal1+ojBVw0VL+RA4Y/Sv9RQa1mJgKu884rA22/vskboIIiKIkh61 Txjspq+/obUqtUc4rbOP6OPrglJM4kRAASBz4J5fpwrWB/SQ2YteKv+IzZZsYUKDvbpT eSTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ha1vFqbT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m45si81015pje.39.2019.06.25.13.06.39; Tue, 25 Jun 2019 13:07:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ha1vFqbT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727653AbfFYUGU (ORCPT + 99 others); Tue, 25 Jun 2019 16:06:20 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:34449 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbfFYUGT (ORCPT ); Tue, 25 Jun 2019 16:06:19 -0400 Received: by mail-qk1-f195.google.com with SMTP id t8so13716887qkt.1; Tue, 25 Jun 2019 13:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RTShSTj5/FpTVgIWgu2/oFhLVrp3kVnO6Lz9E5kxwQM=; b=ha1vFqbT0ywZB5TXVQmocuAfoQKB6bgbEwlb/9v31UC05KTLDW/64Vt6sDEuDGQJD6 JHYd3VesOiyHR54nqqx5gwy+zAKHLKPQT7Qw5ph/9dRiTaHImUYTSxKvT1I+faRUfNyt MlchwGAfPA3LXqNu1Cj/NPtjZh+IicgsxRPIiBj1w63qJb4DL4CA4reCdoStk6lCbjFc OtYm/Fa33A4RQq9tcAHUvKhiZwGxejaTTRcctLUaNbINFVbrtRCLRcgZ6uRQZ8YweRCn vCPiMl7CCTNZA99tGiSvr7566ekdX3Jn1kr0JtfXsvSwlNeO80BRu/UIYQCnscwoSKk0 Mf5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RTShSTj5/FpTVgIWgu2/oFhLVrp3kVnO6Lz9E5kxwQM=; b=tcZNGfr/xYR1GfieuZ9+eiZ4H8Hv2XMmIqFhx7vhW41ysEVbU/wHjuDkox54GtE0al hcTsjN/bIxwoLvbcR91IgOz2mA9KogVUbfj3uNJcFcQhv51iUnoUtOWdzyqyeRHYvDmf ofHmnknnDQXhKSon5r5jg+6fbJij3f+96re+jK+98ZNV77QdcUXGKlOypvlxE3DVEVoO mzpuhXJ/Lu0xq2ywu1AyCLytxWAWKpXopZ78klGUarP5I1dbWBy/B2GaW9aCjeTz3vQA 4JWy59gXdrIBSv2w1TNeN/WvVINMl6C4dXrCzpWUIX+GLrDSy1ij64PNP0kVT+OBfBya q5Wg== X-Gm-Message-State: APjAAAVjMSxQ2dPuoglRHCTA2YI69mYNu3yU9o68QJfNjmlthu6CG5JE niv4KTTn3kCeJtgTQ0C+6Kv1y/1rr2SocYWinUY= X-Received: by 2002:a37:5cc3:: with SMTP id q186mr506709qkb.74.1561493178572; Tue, 25 Jun 2019 13:06:18 -0700 (PDT) MIME-Version: 1.0 References: <20190625172717.158613-1-allanzhang@google.com> In-Reply-To: <20190625172717.158613-1-allanzhang@google.com> From: Song Liu Date: Tue, 25 Jun 2019 13:06:07 -0700 Message-ID: Subject: Re: [PATCH bpf-next v4 0/2] bpf: Allow bpf_skb_event_output for more prog types To: allanzhang Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , "David S. Miller" , Networking , bpf , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 25, 2019 at 12:45 PM allanzhang wrote: > > Software event output is only enabled by a few prog types right now (TC, > LWT out, XDP, sockops). Many other skb based prog types need > bpf_skb_event_output to produce software event. > > Added socket_filter, cg_skb, sk_skb prog types to generate sw event. > > allanzhang (2): > bpf: Allow bpf_skb_event_output for a few prog types > bpf: Add selftests for bpf_perf_event_output I am not sure whether this is caused by delay in the mailing list or something else. But it appears to me that you are ignoring some of the feedback. Please pay more attention to these feedback. Please include changes "v1, xxx, v2, xxx, .." in the cover letter, but not the commit log itself. In other words, include that in 0/2, but not in 1/2 or 2/2. Thanks, Song > > net/core/filter.c | 6 ++ > tools/testing/selftests/bpf/test_verifier.c | 33 ++++++- > .../selftests/bpf/verifier/event_output.c | 94 +++++++++++++++++++ > 3 files changed, 132 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/bpf/verifier/event_output.c > > -- > 2.22.0.410.gd8fdbe21b5-goog >