Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3769ybd; Tue, 25 Jun 2019 15:16:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqzxnxY2n6BhayCgXKW2uWNhx4bZaI2tT6cTjbgbax1AMWp0K94qswcz7YjJceG9S6ChbOSN X-Received: by 2002:a17:90a:33c4:: with SMTP id n62mr232736pjb.28.1561500972490; Tue, 25 Jun 2019 15:16:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561500972; cv=none; d=google.com; s=arc-20160816; b=fWn6Ftqp2gAueesoRnZszfhfNhr0PIIUai/5dnNrtk29ZxgaHz7SU/uq8jgWkGegXa pQoYg5F6HxFrhzbkviTnfkoWPQYPj8jT6L1UG/A6teQkxC8gOygEiKCvVg8P1X2BJXik gMQZ7AOp5QMeVWIoB90SWC0Y/EN6+eypjJ0+Yeg5rOQkdy0RViX7WsptJMhAb/+G4tQR WLxcJmsQ9QnKgXNuGirBDHD1wZM8OdGoW5ZtguFFo/qLnolobULtxq6j0bWQTPQPulez yuVquM3xJvwWaxaQ89QQHndbM/ZSIyu/AlFjFGrem0dxyQY4sZBkHRUnfLXNrunVnR7/ T+iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:user-agent:cc:subject :from:to:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=ZcG6s2SVVPlQMCLBl239NuNMjuljQYUwEP8YAEKAtsQ=; b=VGLcH4rmQf+aoZU38biPWASiMK/nGADvR8GCSiWNbRDcxH+q5f1eLhdoWsOVIdzT7V bM/Gr5/yi1lKcm+DRrj3S9UPtq6qC665nuou/Ad9X+4h76dpMts/jWLVWjxCC1VuImPR 7t4Qj30bwm1KJRvtzkNBmco33fOXWWLok7E2OwBk8lrStnQECupXTizX6JeQda0tUgNN OU4koXxeswAON/xQoGxr7+fQp7UhoiuKAF7vYGG9DVeagwn5bJCRUYc+mIkAH8UkxrqN Bdot0oUS8h/YS+b4Jm+JZnj04WlrHRa+ZCFSPbH72EA5B2vge69ILZqg03m3YVneJIZU EH2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ydzac1EN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1si68189pju.84.2019.06.25.15.15.56; Tue, 25 Jun 2019 15:16:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ydzac1EN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbfFYWOQ (ORCPT + 99 others); Tue, 25 Jun 2019 18:14:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:53882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfFYWOQ (ORCPT ); Tue, 25 Jun 2019 18:14:16 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0DC22086D; Tue, 25 Jun 2019 22:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561500855; bh=ZcG6s2SVVPlQMCLBl239NuNMjuljQYUwEP8YAEKAtsQ=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=Ydzac1ENQGs8JHN5EL5E+CkJH82B6XZ3c9ps/ajN91KLrj3uAj/+VpNZmZCdy27gF j+kmQ0rJLpj2ZbPXomZ68FzknKOIshM5pYbIqyrdhTjjiWWhao81hbRMTErmFENX0n gDVC1TZk2QIFCy7IUZZGjEqeE/telP1NRjhfAJ2M= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1560138293-4163-1-git-send-email-weiyi.lu@mediatek.com> References: <1560138293-4163-1-git-send-email-weiyi.lu@mediatek.com> To: Matthias Brugger , Weiyi Lu From: Stephen Boyd Subject: Re: [RFC v1] clk: core: support clocks that need to be enabled during re-parent Cc: James Liao , Fan Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, srv_heupstream@mediatek.com, stable@vger.kernel.org, Weiyi Lu , Biao Huang User-Agent: alot/0.8.1 Date: Tue, 25 Jun 2019 15:14:14 -0700 Message-Id: <20190625221415.B0DC22086D@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Weiyi Lu (2019-06-09 20:44:53) > When using property assigned-clock-parents to assign parent clocks, > core clocks might still be disabled during re-parent. > Add flag 'CLK_OPS_CORE_ENABLE' for those clocks must be enabled > during re-parent. >=20 > Signed-off-by: Weiyi Lu Can you further describe the scenario where this is a problem? Is it some sort of clk that is enabled by default out of the bootloader and is then configured to have an 'assigned-clock-parents' property to change the parent, but that clk needs to be "enabled" so that the framework turns on the parents for the parent switch?