Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp383262ybd; Tue, 25 Jun 2019 23:26:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqyyv6I1uyQzN2WqRvmYZ1cJYtf47uQLIyCILgBKHkfbDGkGIfxcyH6262SSu5v2vnEZIj6g X-Received: by 2002:a17:902:2bcb:: with SMTP id l69mr3392431plb.155.1561530408269; Tue, 25 Jun 2019 23:26:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561530408; cv=none; d=google.com; s=arc-20160816; b=w8UsoekQeukGqW1CKMaJhttLeEsD9bMEoPuAp7gncsisoxzHAmkU0+k3/ELhQNjVgh BaZOYTPj5441HLPAM2wBH8sIsDqteUqJ0+u/P8Rk6T3bs/pkE+GGDk8LZ+y5eoir/eWs NUH3sJaSmKmPB8dirN8YwdmQ8FkDtRXePekxSYJsYc6JG3hGz524oM+f8OJ19fcBhFe3 kRWyLZk24L2eQymN9T4sal+Zneemn63dt6S/XSIWIPxZms/BtQ/W6DQz/wO0haJi9ymh QLxyZJH8VWCwfGMdEbQZlJy8vnGdKwIgd1TLOVOnjUjd7NojqqEoaxEsHHuOP/1958+3 ZN/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=vjf2d0NZNtFcEmYWnKexpRDmfiz1k60Y5KEvZ3aKoq0=; b=fxdclaN3eNsTJxAjOx646C0pc31EmRg7GNs26w2o4Xb2ppvLClK8e400da0zdXV7lf uoFQJ9Y4LidIknUCeUWQpJupQaeXEXFb02LZ+azkg5UGx4biibW8YR9l/45xG336SIj2 KTuqKO6UOrFv5yWAWPEK4J304YUAbUatNFuSHwBIsJm215LE/HXB42bn1UaLemlayAAX pYznibvbN2O7bdpg9sWlFsjzfmjYXCJrW5I/iAOzJHr6VpKc8Qaw3a6CWKZO17uPMgO9 6mNBZ1YRc24uzSeiAIUDbmqN+syzxtr2sBZlOxhNVmtUh0ZOBihS4Coo/3Ee2XAdBvw9 M1/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=UBaIRenG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=geanix.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6si2451344plm.94.2019.06.25.23.26.31; Tue, 25 Jun 2019 23:26:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=UBaIRenG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=geanix.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbfFZG0V (ORCPT + 99 others); Wed, 26 Jun 2019 02:26:21 -0400 Received: from first.geanix.com ([116.203.34.67]:59366 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725924AbfFZG0U (ORCPT ); Wed, 26 Jun 2019 02:26:20 -0400 Received: from [192.168.100.94] (unknown [95.138.208.137]) by first.geanix.com (Postfix) with ESMTPSA id 1FEB8A8C; Wed, 26 Jun 2019 06:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1561530346; bh=NDzWY1mn8lR9WsNTeOSRA7DhTJGZznkTv0X6E2FIZ0k=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=UBaIRenG4Cel4QngwSQ1B2hHFpou0eDA/c+J/ub1C3MTrt/jHs2A4lrSvuLxqhL0x 2AyWZxz0UBtrh+aqOSqIrin9+IQgBbjf8eZaIWe6WYmg/30Kcu5vexu6gDtM30iGMS /ds5jksQ2rY2PDsDsOjT1aiXltgUkS45rKrHNYHNYBseg7Jo7ADD8GuMdztswItfvL jtUQXFUq3MEPnZNgWNqJ6Tbk2/k7C8sY4rH1IjROks7Y54ZMsOgLxHdPi6baVHBaD7 mf4lS7wo/IRFKl+xoDgS77gbarFvId89gC9EisZvaYGvelNFQnzyc4h/HopvsXxWiu Qrx41MMrxhEjQ== Subject: Re: [PATCH] can: mcp251x: add error check when wq alloc failed To: Willem de Bruijn , Weitao Hou Cc: Wolfgang Grandegger , Marc Kleine-Budde , David Miller , Greg Kroah-Hartman , allison@lohutok.net, tglx@linutronix.de, linux-can@vger.kernel.org, Network Development , linux-kernel References: <20190625125048.28849-1-houweitaoo@gmail.com> From: Sean Nyekjaer Message-ID: <6a678bc9-648e-e566-9781-2b42a678ed86@geanix.com> Date: Wed, 26 Jun 2019 08:26:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=disabled version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on 884f5ce5917a Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/2019 16.03, Willem de Bruijn wrote: > On Tue, Jun 25, 2019 at 8:51 AM Weitao Hou wrote: >> >> add error check when workqueue alloc failed, and remove >> redundant code to make it clear >> >> Signed-off-by: Weitao Hou > > Acked-by: Willem de Bruijn > Tested-by: Sean Nyekjaer