Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp426440ybd; Wed, 26 Jun 2019 00:16:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqzd3oF2/9iDTfPfs7sevF3MoGwj5q9WEqwivAxZh8pBmnIE7rbkMSuq/HZIP1i7iycqCIUb X-Received: by 2002:a17:902:1125:: with SMTP id d34mr3704226pla.40.1561533389345; Wed, 26 Jun 2019 00:16:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561533389; cv=none; d=google.com; s=arc-20160816; b=koKC/5CRluchm7dUN29XXpAJi6jcdMLDmhb4rGnutdfG5gxQkSHO/BkqwNe+9yUO5t QpOriHOabBdRgHFDpe7WradvO32L1BJLrCNmqzwweoPag38KockFclU2aphisn5fPgwS Blbr5jqrGiYCRu/1lYaAXo6EcQRRocepY/EuVtYY3YZ4hcDqpcxAo8N/ejuWdqw6PBzm fr8Bsx5HmSpeUk4K2Cm/IgjmeblqbsufR6IZIpiGttnxFdrKtpm4Xl0jFAyKnrreHTzi g/fn1HExFNOlOJ3Frx63L4H5yskvSTQXfZKEBvEFM0tGHY+kJee7RJqNceP6uH11inyY xsJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=GdRopXmwzFBJhE/O8431CTMDPjRbbT7G4w2BpMwcWkg=; b=PTOTFhnDiorC69yjhwxqBXCOU3LqzgDbk9T4ngbFwGEI/jO0KghJAHf6FhtMHQErv4 mLib6ljIsXt3juVefhvfscygn6HdHJcpGjGKybbRJhklc9p4NwUGUKPOBwo7KrmMdczz 4yFrxDQpYdMpsOEa0qywQqoVIib446PR3bH19lHR/qYhfZRABVYzKsi4dqQKRGr9930o N2Xtzi2u45GsORFlBoTr3fu4txu2GUkjKU3+034ntCJ5y9WGjeCxNuKl2L5vIYxvu7tn B/H1wWA0Us6wBqmBront+/sKExZEIFqAGbZq6whVnvv2Pf+N6GcqWOSxYdvwfqzyFZ/1 DpBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 68si2519985ple.89.2019.06.26.00.15.49; Wed, 26 Jun 2019 00:16:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726883AbfFZHOL (ORCPT + 99 others); Wed, 26 Jun 2019 03:14:11 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:32786 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726077AbfFZHOL (ORCPT ); Wed, 26 Jun 2019 03:14:11 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 7383ED8A4FDEEF3C92B8; Wed, 26 Jun 2019 15:14:07 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 26 Jun 2019 15:13:54 +0800 Subject: Re: [PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails To: Yue Hu , , CC: , , , References: <20190626033038.9456-1-zbestahu@gmail.com> From: Chao Yu Message-ID: <96f12ad4-e9dc-a688-2c26-2dd285b7b795@huawei.com> Date: Wed, 26 Jun 2019 15:13:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190626033038.9456-1-zbestahu@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/6/26 11:30, Yue Hu wrote: > From: Yue Hu > > We should consider the error returned by fill_inline_data() when filling > last page in fill_inode(). If not getting inode will be successful even > though last page is bad. That is illogical. Also change -EAGAIN to 0 in > fill_inline_data() to stand for successful filling. > > Signed-off-by: Yue Hu Reviewed-by: Chao Yu Thanks,