Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp526746ybd; Wed, 26 Jun 2019 02:14:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqw3TyeOSXtCIXsrcHJBebMbF+9N3Vr6063FzbIJ6syk8+Yr8fFrhrvKBtNHdtyMj/7QTHqy X-Received: by 2002:a63:1a03:: with SMTP id a3mr1806400pga.397.1561540480979; Wed, 26 Jun 2019 02:14:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561540480; cv=none; d=google.com; s=arc-20160816; b=QHjqcd/Zx3uh1ubtl5uFoe1t1TBqaD11jBtUlXRscJWpFUJhsB4EQdd+Zt1Z4grIfK RfOy1iSAbFavWjkdJ4+40bcULwMBb1MYuku4KyusxHkikezx04lyUuX5/jNLojc+uZC9 4HpwMqoYuQT9tFJ7RICF/iVN5R/UGTVOx5W+OUAFhtxEIBGlDgvhvJj3Gd9l9kGe2ZtW MMCVupg+nO9kX8f2A0qRQE+5VWxWN1CsASziM29gSe03YalaAA5qog+nct+euMwiZ7/D Gvxq/4iJ0kVGtvzNSuOP4HoRJ0CoIkzev5M+DXRcw3wBtxjxzQzD14KO97dghmEjko7R lhiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject; bh=Y68kjL3oB4no+75Vc4L5WJi8kvCbtpayI2ogScb1Png=; b=t1OKtpK3HhVXjJXlr3Ycm5zepdJZZS/7FgD8lH8b9xmhep9qovHWblZA1IhEcbzdt5 b+HCamMEP6f2c4jKMNf5+29DlZeV01vvDNX1W06e7mc1B7yxj9ltXxLd+qfX0Ph04BXS QVTyUqDIC28hCw1y7y3Wk0PR2KaGq/EHlkPClMIFxiFRhcKeKU1/tvCoIFjAvB3Ds+QY +Q4avT7L4YgGwNuHf+Ms4l5yASFLqWXHhRs43g/c/PtbhzGghf3XpnDqdl4ouDk7OeIH rHBjiLxpyHN4H4W2mgEg1yGVYB6j6bfchLlonGfuAO1jiR9uhsZoevVY61D3GWBQiBU8 5e1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b67si1584781pjc.81.2019.06.26.02.14.23; Wed, 26 Jun 2019 02:14:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726673AbfFZJM5 (ORCPT + 99 others); Wed, 26 Jun 2019 05:12:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32922 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725379AbfFZJM4 (ORCPT ); Wed, 26 Jun 2019 05:12:56 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E4707307D863; Wed, 26 Jun 2019 09:12:52 +0000 (UTC) Received: from [10.36.116.174] (ovpn-116-174.ams2.redhat.com [10.36.116.174]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B0AA5D9D6; Wed, 26 Jun 2019 09:12:36 +0000 (UTC) Subject: Re: [PATCH v1 0/6] mm / virtio: Provide support for paravirtual waste page treatment To: Christophe de Dinechin Cc: Alexander Duyck , nitesh@redhat.com, kvm@vger.kernel.org, mst@redhat.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, yang.zhang.wz@gmail.com, pagupta@redhat.com, riel@surriel.com, konrad.wilk@oracle.com, lcapitulino@redhat.com, wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, alexander.h.duyck@linux.intel.com References: <20190619222922.1231.27432.stgit@localhost.localdomain> <7hmui42017.fsf@turbo.dinechin.lan> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: Date: Wed, 26 Jun 2019 11:12:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <7hmui42017.fsf@turbo.dinechin.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 26 Jun 2019 09:12:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.06.19 11:01, Christophe de Dinechin wrote: > > David Hildenbrand writes: > >> On 20.06.19 00:32, Alexander Duyck wrote: >>> This series provides an asynchronous means of hinting to a hypervisor >>> that a guest page is no longer in use and can have the data associated >>> with it dropped. To do this I have implemented functionality that allows >>> for what I am referring to as waste page treatment. >>> >>> I have based many of the terms and functionality off of waste water >>> treatment, the idea for the similarity occurred to me after I had reached >>> the point of referring to the hints as "bubbles", as the hints used the >>> same approach as the balloon functionality but would disappear if they >>> were touched, as a result I started to think of the virtio device as an >>> aerator. The general idea with all of this is that the guest should be >>> treating the unused pages so that when they end up heading "downstream" >>> to either another guest, or back at the host they will not need to be >>> written to swap. >>> >>> When the number of "dirty" pages in a given free_area exceeds our high >>> water mark, which is currently 32, we will schedule the aeration task to >>> start going through and scrubbing the zone. While the scrubbing is taking >>> place a boundary will be defined that we use to seperate the "aerated" >>> pages from the "dirty" ones. We use the ZONE_AERATION_ACTIVE bit to flag >>> when these boundaries are in place. >> >> I still *detest* the terminology, sorry. Can't you come up with a >> simpler terminology that makes more sense in the context of operating >> systems and pages we want to hint to the hypervisor? (that is the only >> use case you are using it for so far) > > FWIW, I thought the terminology made sense, in particular given the analogy > with the balloon driver. Operating systems in general, and Linux in > particular, already use tons of analogy-supported terminology. In > particular, a "waste page treatment" terminology is not very far from > the very common "garbage collection" or "scrubbing" wordings. I would find > "hinting" much less specific. for example. > > Usually, the phrases that stick are somewhat unique while providing a > useful analogy to server as a reminder of what the thing actually > does. IMHO, it's the case here on both fronts, so I like it. While something like "waste pages" make sense, "aeration" is far out of my comfort zone. An analogy is like a joke. If you have to explain it, it's not that good. (see, that was a good analogy ;) ). -- Thanks, David / dhildenb