Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp602692ybd; Wed, 26 Jun 2019 03:39:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqweSXF2635nK8iQYyR5lpeSdQTJvWmi4JpV/a5LFENMWvbpTOuA7GyGjKDPuihyle3e1TT6 X-Received: by 2002:a17:90a:cb97:: with SMTP id a23mr3854716pju.67.1561545587478; Wed, 26 Jun 2019 03:39:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561545587; cv=none; d=google.com; s=arc-20160816; b=FnRyEb3iKweE0n38Imthvxjz5I1s7MUpxo2vDMiPs6+NRFCRYM0T8d15shYlAPer/b 4nf48P3xqjhUDpBMzzd7AZAp/a56K1sAQuTJ79iIXDGc6htUkgsf/WcdT8eN/++l/RHk nIhocBNPpKe3oJahf4RUMkfMzoQeCKiI00IE+cicsD0de0lSPpi74qXc9MLol9euhCXY ZAlOjgIDM8JwJHODwE1G7p3dMkBmQ70zxvGIOGJA5MxrD9enAJcM0l8mVC4v7Q9amf1S dhU1jB+y2osy9KCAlebpqODVMnJybCIAmQ0Zn92Og9rSM17bT0S9HVkcHOZXuVIaU8sa wLYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xJ4m0by2++9HOQy1nxvjvxKgg1O9KxqocX77DoVxh9I=; b=lkSm8g1ZMjOj6CpOwK3rXURKNPQ87u5iz0sNKuhTUvLWgKUSPt/SPqFwIrraU0eb5k PWENIj6S/uxYZX/6xsDVwbkoV714ZfptwKA51srllAH3j/Cf9xX2kHXj4G5vqiSysqat l2u7kYm3W+mM98Sr80QiXzUQAqbp/av7Z30dj3h7xiTEomTlFNlFmS6XHuSo8dKAqvve xSgXc77yg6jjg05Ecd/QKhu646241V4Ad90LcJvss+fV9N0y5AEvDrmxRWY80hSdzeMH FmLfg3F3XNW9rQ/l9tFc8gPiL/4gFnt8D89hRR8TcpknC61cJhpgvCWxPED6ox7dsB2l TWWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Y8LuQXVE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 79si13112284pga.276.2019.06.26.03.39.31; Wed, 26 Jun 2019 03:39:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Y8LuQXVE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbfFZKjQ (ORCPT + 99 others); Wed, 26 Jun 2019 06:39:16 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:47802 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbfFZKjQ (ORCPT ); Wed, 26 Jun 2019 06:39:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xJ4m0by2++9HOQy1nxvjvxKgg1O9KxqocX77DoVxh9I=; b=Y8LuQXVEzUZY/Zor1Ea5GGrtS kXI7pGcfwdr8xmD7cLNeiWBxnXgw94aoRWF8JDNguW/KnwzfyjWLSL8+ESI59cdzjQfEQFtHDer3v htt03AewcJ6jcp1gQogjGzo98K74PbUdeGkE2GWAELCISrralIiZNIHIeI5nzIv2IHnzI=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=finisterre.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg5Ka-0007lL-MF; Wed, 26 Jun 2019 10:39:12 +0000 Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id 33AE5440046; Wed, 26 Jun 2019 11:39:12 +0100 (BST) Date: Wed, 26 Jun 2019 11:39:12 +0100 From: Mark Brown To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ranjani Sridharan , "kernelci . org bot" Subject: Re: [PATCH AUTOSEL 5.1 38/51] ASoC: core: Fix deadlock in snd_soc_instantiate_card() Message-ID: <20190626103912.GW5316@sirena.org.uk> References: <20190626034117.23247-1-sashal@kernel.org> <20190626034117.23247-38-sashal@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nyUxq7w40972sSTq" Content-Disposition: inline In-Reply-To: <20190626034117.23247-38-sashal@kernel.org> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nyUxq7w40972sSTq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 25, 2019 at 11:40:54PM -0400, Sasha Levin wrote: > From: Ranjani Sridharan >=20 > [ Upstream commit 495f926c68ddb905a7a0192963096138c6a934e1 ] >=20 > Move the client_mutex lock to snd_soc_unbind_card() before > removing link components. This prevents the deadlock > in the error path in snd_soc_instantiate_card(). Again, are you sure there's no dependencies? --nyUxq7w40972sSTq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl0TS08ACgkQJNaLcl1U h9Bp8wf/b10PvV5+hosEt5JhEak/U1IB1FmeyKx3FAZVgheXBMUX/ENgHuHVx59c RA6HdxulvuxEo3PeOZxgJxBwKmfV7SiZZTrV/dAcEhRVXT1Zw24Ci2Fmez4cqocJ XMEYKOLKQ8X/bP58YttRJbtlzcHlH/e+lsLUSHr7Hn3QzyjKuJ6dsfJ6nID2oB8o Qj48a5Z6/6SqokSSVS2DfSBRmkU65xLYFGnrGzbgPKjhXxUdxz1/tBvugBHjIHxf dd/nBLTTx5wCy5xWEf09BcIq2rG1Goz+uCwpkRkT5GGlfuxqjKdWTrkfyKiMtF56 NYpGA6UM2gqlDEfWVc3EnqmoEQ+uIw== =RJf/ -----END PGP SIGNATURE----- --nyUxq7w40972sSTq--