Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1561551539-18251-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1561551539-18251-1-git-send-email-pbonzini@redhat.com>
From:   Alexander Potapenko <glider@google.com>
Date:   Wed, 26 Jun 2019 14:24:10 +0200
Message-ID: <CAG_fn=UdN-nPHGBT_t7Dco3287=kGhy5VUOwvKJo4mFY2RZ8Fw@mail.gmail.com>
Subject: Re: [PATCH v2] KVM: x86: degrade WARN to pr_warn_ratelimited
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 26, 2019 at 2:19 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> This warning can be triggered easily by userspace, so it should certainly=
 not
> cause a panic if panic_on_warn is set.
>
Can you please also add the Reported-by tag here?

Reported-by: syzbot+c03f30b4f4c46bdf8575@syzkaller.appspotmail.com
> Suggested-by: Alexander Potapenko <glider@google.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Alexander Potapenko <glider@google.com>
> ---
>  arch/x86/kvm/x86.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 83aefd759846..66585cf42d7f 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1557,7 +1557,7 @@ static int set_tsc_khz(struct kvm_vcpu *vcpu, u32 u=
ser_tsc_khz, bool scale)
>                         vcpu->arch.tsc_always_catchup =3D 1;
>                         return 0;
>                 } else {
> -                       WARN(1, "user requested TSC rate below hardware s=
peed\n");
> +                       pr_warn_ratelimited("user requested TSC rate belo=
w hardware speed\n");
>                         return -1;
>                 }
>         }
> @@ -1567,8 +1567,8 @@ static int set_tsc_khz(struct kvm_vcpu *vcpu, u32 u=
ser_tsc_khz, bool scale)
>                                 user_tsc_khz, tsc_khz);
>
>         if (ratio =3D=3D 0 || ratio >=3D kvm_max_tsc_scaling_ratio) {
> -               WARN_ONCE(1, "Invalid TSC scaling ratio - virtual-tsc-khz=
=3D%u\n",
> -                         user_tsc_khz);
> +               pr_warn_ratelimited("Invalid TSC scaling ratio - virtual-=
tsc-khz=3D%u\n",
> +                                   user_tsc_khz);
>                 return -1;
>         }
>
> --
> 1.8.3.1
>


--=20
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636 M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg