Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 26 Jun 2019 08:26:09 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Josh Poimboeuf <jpoimboe@redhat.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: NMI hardlock stacktrace deadlock [was Re: Linux 5.2-rc5]
Message-ID: <20190626082609.5c8489f0@gandalf.local.home>
In-Reply-To: <20190625030345.dwbydi2w67mpp4zq@treble>
References: <CAHk-=whEQPvLpDbx+WR4Q4jf2FxXjf_zTX3uLy_6ZzHtgTV4LA@mail.gmail.com>
        <156094799629.21217.4574572565333265288@skylake-alporthouse-com>
        <CAHk-=wjhJNKVfHgwd0QX_bq769sxfP4jvfy0dd-WtFMfdivMwg@mail.gmail.com>
        <156097197830.664.13418742301997062555@skylake-alporthouse-com>
        <CAHk-=wjoeZ9_aiu+642ur=iGhGjfBQhRPURxX9Py+-B6coctXw@mail.gmail.com>
        <20190625030345.dwbydi2w67mpp4zq@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 24 Jun 2019 22:03:45 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> Looking at the dmesg, panic_on_oops doesn't seem to be enabled: it went
> through the rewind_stack_do_exit() path instead of the panic() path.  So
> the system is apparently not configured to reboot on oops.

"Command line: BOOT_IMAGE=/boot/drm_intel root=/dev/sda1 rootwait fsck.repair=yes intel_iommu=igfx_off nmi_watchdog=panic,auto panic=5 softdog.soft_panic=5 drm.debug=0xe log_buf_len=1M 3 ro"

> 
> So I'd say the hang was presumably caused by a lock held by the oopsing
> code.  So it looks normal to me, other than the original oops.
> 

Looks like its missing "oops=panic", as the documentation says:


        oops=panic      Always panic on oopses. Default is to just kill the
                        process, but there is a small probability of
                        deadlocking the machine.
                        This will also cause panics on machine check exceptions.
                        Useful together with panic=30 to trigger a reboot.

-- Steve