Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp746318ybd; Wed, 26 Jun 2019 05:29:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqz1u72VB/g4BMoYqEobTzjpstA+Dm3AvWcYSlHGEcXFMJRm3MBAuRYaHb8PznNTR6yDp6jP X-Received: by 2002:a17:90a:1aa4:: with SMTP id p33mr4544828pjp.27.1561552161078; Wed, 26 Jun 2019 05:29:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561552161; cv=none; d=google.com; s=arc-20160816; b=dguJx7yP7Yl0ezCv3j80TS3E2554ihqmeondSrjKSfBNS9vgdJ4PkHs5ELqW5wcLW5 VZivoMvDpSEPs7XnH2h6XvmjCGM2G+XyA3LzLWeueNplPlEEPJvolCEGMEnf5SoF7nld Qw04GseFVmy3ZAJEtpVuNrqG+8bkhcrjPunJTsBWimCB8xDKK9jKDmw0vUqetueRjm6T DDkR7kPibejeB2Kf4aleOTGd//RgIGUcGF5yBimXdaPkhGzB6trLlTIZqNu9VzJArOue TsbLpd5QIoqSzlgpKQf2jyXGvRnVNuY9QiF9dsJsWdESZo020OJZ/XjxMGuqzWfm2Seg e4Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=DvpFXGkn8D3TAMVnH/XfK8pie9+euDypEwPPovS+cDY=; b=C6m47ZmTY3e+IOUTu8DJXxPoWB0jczHZsbo7yfzWNT30QvVH7s7N+ZRzMXsqTsJZha 09vNaUYW5CDE1t6IpcNGhgCd+sb5KqTyLQdo0C7tAfm1ivTRdo3iccHJNMFpN3va8Wwh +4I/NnX1RG4FKwNW+JzotpqV+n2FIvt9BIgCHSiUUPGXJf97RDcVPKCEhG/syuGzwy06 FgPFCwdI2Vdu/0HDY+8vbVMj8pd58c6/+KlLTWZX/oroKWdNBwbNc0c9E9r+7MMNl41f XTbhJZe15sAXwLtVq1QX96/Q6xU/JGWX+7QJFFwqsGEgFd+wjzCMHBNPTdHlVWZUo/rQ 2mmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=WnOodiXs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si3191153plp.96.2019.06.26.05.29.04; Wed, 26 Jun 2019 05:29:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=WnOodiXs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727239AbfFZM1h (ORCPT + 99 others); Wed, 26 Jun 2019 08:27:37 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:60516 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbfFZM1h (ORCPT ); Wed, 26 Jun 2019 08:27:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DvpFXGkn8D3TAMVnH/XfK8pie9+euDypEwPPovS+cDY=; b=WnOodiXsfD4fyL9Z5NzzOmO6b PshG1mD2SemWwT82Ewq0+W5sgLfgnN/7Wy2xLYIvLDJDTAOA7P6ilpPmInXPb6zKSPKJh7Km4YNhI c3mLQ4o36WI78rn3nKWKeBgqIxNUrHaHrWPGkunEuBsb4IXfVtTpLBkX0U4MiJDuloDRc=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=finisterre.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg70f-0007qs-Sb; Wed, 26 Jun 2019 12:26:45 +0000 Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id 1ABC1440046; Wed, 26 Jun 2019 13:26:44 +0100 (BST) Date: Wed, 26 Jun 2019 13:26:44 +0100 From: Mark Brown To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Pierre-Louis Bossart , Jie Yang , Cezary Rojewski , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/11] ASoC: Intel: Skylake: Remove static table index when parsing topology Message-ID: <20190626122644.GD5316@sirena.org.uk> References: <20190617113644.25621-1-amadeuszx.slawinski@linux.intel.com> <20190617113644.25621-6-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="on+I5Kkc+zqLv55g" Content-Disposition: inline In-Reply-To: <20190617113644.25621-6-amadeuszx.slawinski@linux.intel.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --on+I5Kkc+zqLv55g Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 17, 2019 at 01:36:38PM +0200, Amadeusz S=C5=82awi=C5=84ski wrot= e: > Currently when we remove and reload driver we use previous ref_count > value to start iterating over skl->modules which leads to out of table > access. To fix this just inline the function and calculate indexes > everytime we parse UUID token. This doesn't apply against current code, please check and resend. --on+I5Kkc+zqLv55g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl0TZIQACgkQJNaLcl1U h9CIkAf/XqlWXek/c2A2wcZGYAvrtlTTQ8sZ/0UuXaQmIjtdEo1DyARVUHh+Qssv Fl4RPsk4Bs9kkVhKIpoBbIzonFCi37z9HmzixNEUG8ohCZZ4T5KP4zM/nkhXkrjC dv/CrAIRGAL252YrJEaZHjHs15sKRP3vIKB2gdrgIQbDS/7CbQSo4e8kPc4gFzWp iL14YeiHxQxadR9Vx3YkF5c0ArkbsCgHeUQB66a51ENNA9d4dA4J/kZHKczYawv6 lYiqS2cjv+e8KT1CgtPHEaTchKTOfsoxxDahf7uwzxg+MieeSyf8Q8e6YQVX5ZL5 qLrUTgT38tJxoRIHV1vLTaGIJ1it3w== =H7fM -----END PGP SIGNATURE----- --on+I5Kkc+zqLv55g--