Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp781378ybd; Wed, 26 Jun 2019 06:05:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDOSzIXiHOBVHRlG7DLQ+lygZfHvMlhZ7bcRCm3A5HKHRUjBTStCxTgbnPE8B46YS8R6x8 X-Received: by 2002:a65:6083:: with SMTP id t3mr2863054pgu.342.1561554334733; Wed, 26 Jun 2019 06:05:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561554334; cv=none; d=google.com; s=arc-20160816; b=sSjGbnVrQCWRj0J5bPLOMeJz+2VDLGiXZEVKNNZvYJ5wbwAcL138ne7bN+s15f7+Uv 5QCUN658L84Vun2PON7ti4PcV1FQP7DPoD9fKsSY5SsGCj96SOybc8hqPYwEmIEFk7WM xB/Wd7VW0Y5fHzdwPzHhuSe+D5sb+wbYdcvLqwNiuuN7oqxkV01SBFVEnfw8BtFoDmHF AddG0TM8zjsQa3uDMoy6di5xiegbcNdzAHWRLnlGyXWdgNBSJO5xDnlm+kDteGx+tZL6 rgsqyGWOu8+fXGkWCqIE0+QGet+SqJHq8NF+F027Nf+G0V6+muEvx9aDowlnQMypji5N bGNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date:dkim-signature:dkim-filter; bh=2KdsEmoK84RYDcktQ94XY4dfpIi6hmLKPNkgF9bi94s=; b=H8iBodrVaMgas1FR3JPS4ua599FUbRBEnzI2ZG4kunf6lcrdxOOZYa1/SulqKEp3+V TdvOlbb+eMWu1vPRjsXxwJBay1KxswzYF6rOlACHdQ7RMKCX8cyhVQKXZzbgaDhBVFyg zJZWdvt2ADWE0kycgP+I7+H91+/fxeoDpD6w+JZdSRsl3UTlxfEpctkwnHyXBl4bIQkd da7sSBxqIkHIIeGO9/4pIjREbaHPewiGJEDR/+gtri359yGGtgqBP/dd9E9qy0Gra/eS DT0a7UcbWv3vjdLNZ/y56LrRGPuEAGsglcAeM8DFS4GZE6EohREf5aI1Uy0UqzRcn9P3 +Rcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zytor.com header.s=2019061801 header.b=WNtGSl3v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zytor.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si2007776pju.64.2019.06.26.06.05.16; Wed, 26 Jun 2019 06:05:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zytor.com header.s=2019061801 header.b=WNtGSl3v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zytor.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727489AbfFZNCs (ORCPT + 99 others); Wed, 26 Jun 2019 09:02:48 -0400 Received: from terminus.zytor.com ([198.137.202.136]:38721 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbfFZNCs (ORCPT ); Wed, 26 Jun 2019 09:02:48 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x5QD2gk94112661 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 26 Jun 2019 06:02:42 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 terminus.zytor.com x5QD2gk94112661 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2019061801; t=1561554162; bh=2KdsEmoK84RYDcktQ94XY4dfpIi6hmLKPNkgF9bi94s=; h=Date:From:Cc:Reply-To:In-Reply-To:References:To:Subject:From; b=WNtGSl3vQx7+BojyBlp2vs1ljTt6ciGcld018QJKftvw0qVec5g7mgzUQ9egjlTSm eS5HMlCSh47Fd2L21Xg0UHnFALiPMrtXwGEFhJ6wpviqgakChwztcaDS9wVjCQ3ftL 9wcDZE8ctU+OLIa/aolw2wWLgPNfvpg5GZ2NzLF79hRWNDaL525F0ERVccaKniTM7B mXp60IMGwd45XjLfC94iB3IrYKbGe/6G0ad2hJkDB9AkadXKME+YRr5mXGTG2nTtp4 puJFlM4CAzLm2rg5g5RuEXdq7qmsGDDMl9obpGgSDhkqyYxZsN0P4MPjPUV84QOJLB r/2udOVRdJuaw== Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x5QD2fpv4112658; Wed, 26 Jun 2019 06:02:41 -0700 Date: Wed, 26 Jun 2019 06:02:41 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Ferdinand Blomqvist Message-ID: Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com, ferdinand.blomqvist@gmail.com, tglx@linutronix.de Reply-To: tglx@linutronix.de, ferdinand.blomqvist@gmail.com, hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@kernel.org In-Reply-To: <20190620141039.9874-4-ferdinand.blomqvist@gmail.com> References: <20190620141039.9874-4-ferdinand.blomqvist@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:core/rslib] rslib: decode_rs: Fix length parameter check Git-Commit-ID: a343536f8f482be6932803a023f46d0fa723ae56 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=2.2 required=5.0 tests=ALL_TRUSTED,BAYES_00, DATE_IN_FUTURE_12_24,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, DKIM_VALID_EF,FREEMAIL_FORGED_REPLYTO autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a343536f8f482be6932803a023f46d0fa723ae56 Gitweb: https://git.kernel.org/tip/a343536f8f482be6932803a023f46d0fa723ae56 Author: Ferdinand Blomqvist AuthorDate: Thu, 20 Jun 2019 17:10:35 +0300 Committer: Thomas Gleixner CommitDate: Wed, 26 Jun 2019 14:55:46 +0200 rslib: decode_rs: Fix length parameter check The length of the data load must be at least one. Or in other words, there must be room for at least 1 data and nroots parity symbols after shortening the RS code. Signed-off-by: Ferdinand Blomqvist Signed-off-by: Thomas Gleixner Link: https://lkml.kernel.org/r/20190620141039.9874-4-ferdinand.blomqvist@gmail.com --- lib/reed_solomon/decode_rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/reed_solomon/decode_rs.c b/lib/reed_solomon/decode_rs.c index 3313bf944ff1..22006eaa41e6 100644 --- a/lib/reed_solomon/decode_rs.c +++ b/lib/reed_solomon/decode_rs.c @@ -39,7 +39,7 @@ /* Check length parameter for validity */ pad = nn - nroots - len; - BUG_ON(pad < 0 || pad >= nn); + BUG_ON(pad < 0 || pad >= nn - nroots); /* Does the caller provide the syndrome ? */ if (s != NULL)