Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp812521ybd; Wed, 26 Jun 2019 06:27:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqzlqUlbHjFGWOq0+RrmxD0sropJbciu62ilFkjJxUqkJw0v6z/KV0KCUt3qYXTX26KdhYe1 X-Received: by 2002:a17:90a:dd45:: with SMTP id u5mr4646335pjv.109.1561555655463; Wed, 26 Jun 2019 06:27:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561555655; cv=none; d=google.com; s=arc-20160816; b=bqJy97m8qZU4M6C/fAByXvNlp8pou4WYSSteOWuXlodElKRRIqFBNzTkSXgqiAWX4F NLmxAU6Tjyc+q59bBtgP16NmYMTI6fEJKen+r1e2zFupO9zwLdum2kmMX2vIixodXg+h m7ZGr+Mm8APdJJUNMduiDCbVcxWwYADXlIbKtxwFFFVhclqRyWT008YzGuH+6Q0+w7xk oA2B66fhEcOXZlqC/YZXbgHPH7jM3y0KdFjlSZ6zdhknMZqDJInvvezOVZKg+BF4AXap pBTJcjYbBJBI9EZAR0paSriieqlqIl9Z1loHxx+cDWr1wp4eAyo9NsJtS/uwMfSriIsA Rnrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3KkjIEWuvBf7zc0GINznLy2IcxBym+z5vEk9sZ3vG7M=; b=KGq5PnkUM3htNar6oV2qC2zGEjyRyvbc38v0R72+rGh9RbxDKSthnbxzwEMJyRPStn 3k3rtN4mqAHdUthumBpgrLIqgUXG8Mt+85gZQXE5REjEx4spesC6fds0n66AUteeQlOb 0N+1dFlLtUw3wiuIYhtz3/grYSObI97wyz57ECUL/CQpvW9erg2MF2bqNbY1Uf0ATW0Q o1wG5DLgnGX/5zTx8m6Kbfb/d59JZxmjTUUUGy6d8h4yEFeCbjyjo+gIHHgbupXupf12 QGUXBbtarLkmPkrlD7xCoUbmPwqMosE92y7urYvzNGaWqMUd9TaLG0Tc611vPiQzytKq DziQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ingics-com.20150623.gappssmtp.com header.s=20150623 header.b=MBhySszZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si3191153plp.96.2019.06.26.06.27.18; Wed, 26 Jun 2019 06:27:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ingics-com.20150623.gappssmtp.com header.s=20150623 header.b=MBhySszZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727681AbfFZN04 (ORCPT + 99 others); Wed, 26 Jun 2019 09:26:56 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41284 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726984AbfFZN0z (ORCPT ); Wed, 26 Jun 2019 09:26:55 -0400 Received: by mail-pg1-f195.google.com with SMTP id y72so1226319pgd.8 for ; Wed, 26 Jun 2019 06:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3KkjIEWuvBf7zc0GINznLy2IcxBym+z5vEk9sZ3vG7M=; b=MBhySszZUbVd8/OYyYuorpH67jBzTVvfKEb3Yw7Vk91sRSJr91KYR5gVMCnad6IxAe 2T5c7TjfeskPmXYDTJXiKuFSDmg/RsH8Nb0YdmjPNFLUqN6fQsqMtGyN3ekzzULUSkVh 9hsfbLFcPiSR989uNqZHtW8C5ZD8sxhQ0UQZ1n7WQCE05VqvP7oT6YoFvpBLT6CPtiS6 5QHAnQDwxeiqy73h3tNIKipFC7SIRRYar5ACYqQk4ZIYHRAeNf+EhbpCTjxCw0rJ+lGt buFi1/SNjrz2R0lkmeobmNJ8cqyPHMxrT8BxhX4p1GZaTMBkPuiJHZV1ilDVFn0kbCPm oeuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3KkjIEWuvBf7zc0GINznLy2IcxBym+z5vEk9sZ3vG7M=; b=BpdmzBcjSKQHQnZBqivM7kCspOObvpeDtPz/p0dq94kvVwyYVYRdicDpFTfT6fhnt7 RPQCin6MB27zNbYLAoohP4Fs+pPk6PsOSsVkuDQRKGdl1pW29ESM8gZshbcdsYAHqwRc eB5skuiaUGAQJOe1dTUkYSSLzV5evX8AlO+bb9Cgdj4aY5Udj9ILrSZvQ2HSBq/JyuJ2 +kVl/XEZcnwj4Az+JPMzNEK1LTQ37QeX6SjrSehq4j5DzUY+pa1pmRp/em/KKsVWjXgc AIQN7tDBWgw2883UB5f1OoA0A6UX+YgkVWzhcliUMk36EZqoTuCmmC0gWLTaYdNuQMCi ODOA== X-Gm-Message-State: APjAAAU7lEm6ulOPVhJn4QPqMsGcSYClYIAVl7qME6+/BFxzHJU+Wapq RpmHEYTI1JRQtEj6jIWo6//uJw== X-Received: by 2002:a65:45c1:: with SMTP id m1mr3137351pgr.260.1561555615012; Wed, 26 Jun 2019 06:26:55 -0700 (PDT) Received: from localhost.localdomain (36-239-239-167.dynamic-ip.hinet.net. [36.239.239.167]) by smtp.gmail.com with ESMTPSA id a21sm28649147pfi.27.2019.06.26.06.26.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 26 Jun 2019 06:26:54 -0700 (PDT) From: Axel Lin To: Mark Brown Cc: Dan Murphy , Milo Kim , Liam Girdwood , linux-kernel@vger.kernel.org, Axel Lin Subject: [RFT][PATCH 1/2] regulator: lm363x: Fix off-by-one n_voltages for lm3632 ldo_vpos/ldo_vneg Date: Wed, 26 Jun 2019 21:26:31 +0800 Message-Id: <20190626132632.32629-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the datasheet https://www.ti.com/lit/ds/symlink/lm3632a.pdf Table 20. VPOS Bias Register Field Descriptions VPOS[5:0] Sets the Positive Display Bias (LDO) Voltage (50 mV per step) 000000: 4 V 000001: 4.05 V 000010: 4.1 V .................... 011101: 5.45 V 011110: 5.5 V (Default) 011111: 5.55 V .................... 100111: 5.95 V 101000: 6 V Note: Codes 101001 to 111111 map to 6 V The LM3632_LDO_VSEL_MAX should be 0b101000 (0x28), so the maximum voltage can match the datasheet. Fixes: 3a8d1a73a037 ("regulator: add LM363X driver") Signed-off-by: Axel Lin --- drivers/regulator/lm363x-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/lm363x-regulator.c b/drivers/regulator/lm363x-regulator.c index 5647e2f97ff8..e4a27d63bf90 100644 --- a/drivers/regulator/lm363x-regulator.c +++ b/drivers/regulator/lm363x-regulator.c @@ -30,7 +30,7 @@ /* LM3632 */ #define LM3632_BOOST_VSEL_MAX 0x26 -#define LM3632_LDO_VSEL_MAX 0x29 +#define LM3632_LDO_VSEL_MAX 0x28 #define LM3632_VBOOST_MIN 4500000 #define LM3632_VLDO_MIN 4000000 -- 2.20.1