Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp906409ybd; Wed, 26 Jun 2019 07:57:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqyro8bHJyK4kffBsjnS2EV2/pIdbeOAARlGaNWF8yOyKhQ+uARbWf3sWWudz3rZp0Ti1fH0 X-Received: by 2002:a17:902:6848:: with SMTP id f8mr5956870pln.102.1561561053777; Wed, 26 Jun 2019 07:57:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561561053; cv=none; d=google.com; s=arc-20160816; b=xPe/UjQ2lSpvPNvMCugWUevNFLdnqFjoEKAxxK6qrma/ki2qx7CHen34v+bHVoemce 7UIWnOyaMpbIqFEuArHXo3oOvu7X9wwqghX0vongutNEhOWOuEawxTKdkFC6iBjM0l3V eAcUYwKqKqdUO82LgLxm8pJ/iojNe+B+6byCvWJR3StqoSlWCJ/qQUJw8LXotPHYOMLt txah5ENrn2XfK+XgZ0W9r03EaP+G6QTkbrUEna+ixrQ+xvd5yq74i7IcNXUDrV+fqnoI fy7eqBEG1mRU7MGCT8PaQho5NFHp0AivpTGVDC/MC7NLWSBknoWLwDxooA0aFUTpr/Rq egMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=5eXj9JSQwVsY+6/vhyj/4J9kpc6Obm+cVlZtWQ4EXHc=; b=AohbDiYopXBojLs6mr2sAhXg+OYOcd1Y4ruoym84SGFD3KFA/zPu1HpyNrTT36S0I8 s7d0veIchjXjEV8AjMA+pnQSHkVFEev/qCKVMFAsP0gNsV8DQK8d8zuu2e+F5Ml0CYb1 J1IV9dEQjPkXaKOpC7SHxfZ8ywTDCLow/xsfFFOPqb6LOjdycgaKEPq3olEBvBLi41TQ 54PezROM+0HlwORX8yMPU8+lhMb98s0J1Q0YeinHu/zTB6RinE0JR9YSCYp5nkDX63i9 JsXn/BNiMhhUD5Mad0hPgfW3PqunmruYaMa9Vxhbh1TbCpYd+NpFhk5UvdID67JY4uU1 BDLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si17671429pfr.52.2019.06.26.07.57.17; Wed, 26 Jun 2019 07:57:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728254AbfFZO4q (ORCPT + 99 others); Wed, 26 Jun 2019 10:56:46 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:52616 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbfFZO4q (ORCPT ); Wed, 26 Jun 2019 10:56:46 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hg9Ln-0007ls-0V; Wed, 26 Jun 2019 14:56:43 +0000 Subject: Re: [PATCH] orangefs: remove redundant assignment to variable buffer_index To: Dan Carpenter , Mike Marshall Cc: linux-fsdevel , Martin Brandenburg , devel@lists.orangefs.org, kernel-janitors@vger.kernel.org, LKML References: <20190511132700.4862-1-colin.king@canonical.com> <20190521150311.GL31203@kadam> <20190626061801.GA18776@kadam> From: Colin Ian King Openpgp: preference=signencrypt Autocrypt: addr=colin.king@canonical.com; prefer-encrypt=mutual; keydata= mQINBE6TJCgBEACo6nMNvy06zNKj5tiwDsXXS+LhT+LwtEsy9EnraKYXAf2xwazcICSjX06e fanlyhB0figzQO0n/tP7BcfMVNG7n1+DC71mSyRK1ZERcG1523ajvdZOxbBCTvTitYOy3bjs +LXKqeVMhK3mRvdTjjmVpWnWqJ1LL+Hn12ysDVVfkbtuIm2NoaSEC8Ae8LSSyCMecd22d9Pn LR4UeFgrWEkQsqROq6ZDJT9pBLGe1ZS0pVGhkRyBP9GP65oPev39SmfAx9R92SYJygCy0pPv BMWKvEZS/7bpetPNx6l2xu9UvwoeEbpzUvH26PHO3DDAv0ynJugPCoxlGPVf3zcfGQxy3oty dNTWkP6Wh3Q85m+AlifgKZudjZLrO6c+fAw/jFu1UMjNuyhgShtFU7NvEzL3RqzFf9O1qM2m uj83IeFQ1FZ65QAiCdTa3npz1vHc7N4uEQBUxyXgXfCI+A5yDnjHwzU0Y3RYS52TA3nfa08y LGPLTf5wyAREkFYou20vh5vRvPASoXx6auVf1MuxokDShVhxLpryBnlKCobs4voxN54BUO7m zuERXN8kadsxGFzItAyfKYzEiJrpUB1yhm78AecDyiPlMjl99xXk0zs9lcKriaByVUv/NsyJ FQj/kmdxox3XHi9K29kopFszm1tFiDwCFr/xumbZcMY17Yi2bQARAQABtCVDb2xpbiBLaW5n IDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+iQI2BBMBCAAhBQJOkyQoAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEGjCh9/GqAImsBcP9i6C/qLewfi7iVcOwqF9avfGzOPf7CVr n8CayQnlWQPchmGKk6W2qgnWI2YLIkADh53TS0VeSQ7Tetj8f1gV75eP0Sr/oT/9ovn38QZ2 vN8hpZp0GxOUrzkvvPjpH+zdmKSaUsHGp8idfPpZX7XeBO0yojAs669+3BrnBcU5wW45SjSV nfmVj1ZZj3/yBunb+hgNH1QRcm8ZPICpjvSsGFClTdB4xu2AR28eMiL/TTg9k8Gt72mOvhf0 fS0/BUwcP8qp1TdgOFyiYpI8CGyzbfwwuGANPSupGaqtIRVf+/KaOdYUM3dx/wFozZb93Kws gXR4z6tyvYCkEg3x0Xl9BoUUyn9Jp5e6FOph2t7TgUvv9dgQOsZ+V9jFJplMhN1HPhuSnkvP 5/PrX8hNOIYuT/o1AC7K5KXQmr6hkkxasjx16PnCPLpbCF5pFwcXc907eQ4+b/42k+7E3fDA Erm9blEPINtt2yG2UeqEkL+qoebjFJxY9d4r8PFbEUWMT+t3+dmhr/62NfZxrB0nTHxDVIia u8xM+23iDRsymnI1w0R78yaa0Eea3+f79QsoRW27Kvu191cU7QdW1eZm05wO8QUvdFagVVdW Zg2DE63Fiin1AkGpaeZG9Dw8HL3pJAJiDe0KOpuq9lndHoGHs3MSa3iyQqpQKzxM6sBXWGfk EkK5Ag0ETpMkKAEQAMX6HP5zSoXRHnwPCIzwz8+inMW7mJ60GmXSNTOCVoqExkopbuUCvinN 4Tg+AnhnBB3R1KTHreFGoz3rcV7fmJeut6CWnBnGBtsaW5Emmh6gZbO5SlcTpl7QDacgIUuT v1pgewVHCcrKiX0zQDJkcK8FeLUcB2PXuJd6sJg39kgsPlI7R0OJCXnvT/VGnd3XPSXXoO4K cr5fcjsZPxn0HdYCvooJGI/Qau+imPHCSPhnX3WY/9q5/WqlY9cQA8tUC+7mgzt2VMjFft1h rp/CVybW6htm+a1d4MS4cndORsWBEetnC6HnQYwuC4bVCOEg9eXMTv88FCzOHnMbE+PxxHzW 3Gzor/QYZGcis+EIiU6hNTwv4F6fFkXfW6611JwfDUQCAHoCxF3B13xr0BH5d2EcbNB6XyQb IGngwDvnTyKHQv34wE+4KtKxxyPBX36Z+xOzOttmiwiFWkFp4c2tQymHAV70dsZTBB5Lq06v 6nJs601Qd6InlpTc2mjd5mRZUZ48/Y7i+vyuNVDXFkwhYDXzFRotO9VJqtXv8iqMtvS4xPPo 2DtJx6qOyDE7gnfmk84IbyDLzlOZ3k0p7jorXEaw0bbPN9dDpw2Sh9TJAUZVssK119DJZXv5 2BSc6c+GtMqkV8nmWdakunN7Qt/JbTcKlbH3HjIyXBy8gXDaEto5ABEBAAGJAh8EGAEIAAkF Ak6TJCgCGwwACgkQaMKH38aoAiZ4lg/+N2mkx5vsBmcsZVd3ys3sIsG18w6RcJZo5SGMxEBj t1UgyIXWI9lzpKCKIxKx0bskmEyMy4tPEDSRfZno/T7p1mU7hsM4owi/ic0aGBKP025Iok9G LKJcooP/A2c9dUV0FmygecRcbIAUaeJ27gotQkiJKbi0cl2gyTRlolKbC3R23K24LUhYfx4h pWj8CHoXEJrOdHO8Y0XH7059xzv5oxnXl2SD1dqA66INnX+vpW4TD2i+eQNPgfkECzKzGj+r KRfhdDZFBJj8/e131Y0t5cu+3Vok1FzBwgQqBnkA7dhBsQm3V0R8JTtMAqJGmyOcL+JCJAca 3Yi81yLyhmYzcRASLvJmoPTsDp2kZOdGr05Dt8aGPRJL33Jm+igfd8EgcDYtG6+F8MCBOult TTAu+QAijRPZv1KhEJXwUSke9HZvzo1tNTlY3h6plBsBufELu0mnqQvHZmfa5Ay99dF+dL1H WNp62+mTeHsX6v9EACH4S+Cw9Q1qJElFEu9/1vFNBmGY2vDv14gU2xEiS2eIvKiYl/b5Y85Q QLOHWV8up73KK5Qq/6bm4BqVd1rKGI9un8kezUQNGBKre2KKs6wquH8oynDP/baoYxEGMXBg GF/qjOC6OY+U7kNUW3N/A7J3M2VdOTLu3hVTzJMZdlMmmsg74azvZDV75dUigqXcwjE= Message-ID: <712efbc2-1c10-8e6e-7517-16fa57cb8709@canonical.com> Date: Wed, 26 Jun 2019 15:56:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190626061801.GA18776@kadam> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/06/2019 07:18, Dan Carpenter wrote: > On Tue, Jun 25, 2019 at 02:55:11PM -0400, Mike Marshall wrote: >>>> You often send these patches before they hit linux-next so I had skipped >>>> reviewing this one when you sent it. >> >> I know Linus is likely to refuse pull requests for stuff that >> has not been through linux-next, so I make sure stuff has been >> there at least a few days before asking for it to be pulled. >> "A few days" is long enough for robots to see it, perhaps not >> long enough for humans. I especially appreciate the human review. One of >> the good things about Orangefs is that it is easy to install and configure, >> especially for testing. Documentation/filesystems/orangefs.txt has >> instructions for dnf installing orangefs on Fedora, and also how to download >> a source tarball and install from that. > > No, no, that comment was to Colin. It's good that he's sending patches > for all the trees as soon as possible like the zero day bot does. But > it does make it hard to review at times. > > regards, > dan carpenter > Indeed, I normally work against the latest code landing in linux-next, so apologies for any confusion. Anyhow, by the look of it these minor nitpicks still need addressing (really low priority), so shall I leave that with you Mike to sort out? Colin