Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1018534ybd; Wed, 26 Jun 2019 09:44:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqwHiwBq2uny16yjjMU8BB7C5Qg9e/huD4uZOU0PUkrMTM+MfnlH4GhgBNiZg2B7Y0T0arTu X-Received: by 2002:a17:902:27e6:: with SMTP id i35mr6495364plg.190.1561567494102; Wed, 26 Jun 2019 09:44:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561567494; cv=none; d=google.com; s=arc-20160816; b=zmwcRpoGQOJcADdnSr0hkPaALLYz+HbFEavjuievpoTUOUtwSDbtUEC7gap3Ir4VUY 2CDg3XqGKo45TVSptGSHD7iU63h+mW1XrMY3ILKUDUsda7UX/XuMMp7SxqCKgrjUQU2u GfNkf5G8G0LXUBBviuFe4gsagJe5h2WNtkKKvSeK2WlxAPQflfbVVr6BtoeJqCdEneEt ekv8qri9KYszqGH8nVhOoV1VyYBBfm/igUrzGONAkvJGzVt4UpYPC1eHEGxJyr+Qzd5D KuSbSWbJtoKe8QvpCl8gtKcZ2w991b31nQdUaYWy0/OiqKKo3fUm3ynDQZ6OXKquQHyn QtxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=+Kl6zqvRZLZ9lQVoKaV2eqKE+0ZKBG6ehD62Gdt20JA=; b=ZioV+5ztIU1Ki8OlQku4iNR4r58JvqFUUwPunRtNznB7fR2VJaQCcHfsapm49pLifG e6/eu+x+EWW7mpLRu78ZLg5owVq4YKNNtybfw0uPXXbLfVmwILiXH2nDyybv9E3sL6vP s+j7z4Y1kaIDf+FpACFYFRkdDKi7JM2Q0gozVUr3ioa98j32/8W3ke7aQrN6bymvxUQ0 zMZvkmjqZ2Wi1KFJtzBFmfAXc5a/yOCCNBtgfYXm0p4+R6JUTkX6yL0IJ778MPdKDnL5 lWl9h2N8WaF1vbB7pI/hoJYhH7Hq3xI1emvJKQJofvAKt7EXdOA34ak+kt8oDQRZ9fFr NfLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uU2pTcrx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c1si3738298plr.405.2019.06.26.09.44.38; Wed, 26 Jun 2019 09:44:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uU2pTcrx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbfFZQoV (ORCPT + 99 others); Wed, 26 Jun 2019 12:44:21 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33974 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbfFZQoU (ORCPT ); Wed, 26 Jun 2019 12:44:20 -0400 Received: by mail-wr1-f65.google.com with SMTP id k11so3553046wrl.1; Wed, 26 Jun 2019 09:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+Kl6zqvRZLZ9lQVoKaV2eqKE+0ZKBG6ehD62Gdt20JA=; b=uU2pTcrxx3uMqfgAS4VpCdKScq1eWw199rVUyEd8NlrFqrQKIr+zLIpfhSAhdLtSsF g7sn0TBRGaT8F1zuWI1Xr7w7g1CIZvSiDtFZN1JmuXrRDMjoNyE0U/S+536chovbg2xB VdZkbqkQln02gT6MBYgaXRMdXtpKIwxbvuVCaB9JTXf5QLR1EbogkYegTDs6BOpwfivU E/pbRSQ1WYSfpn8/u+xVtkURAqK5SiwKfncihP3NikZ8mjoUc3wclXn6q6kBe9+gzAUM cG5aKPkFaob3WSbbtfBSp8+te99ec09QfbpfAsIKRhbnQTbgAzKogYdUkplReEUbKErr bTdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=+Kl6zqvRZLZ9lQVoKaV2eqKE+0ZKBG6ehD62Gdt20JA=; b=shN1BP2U4ije97iQrvvuTSstSbVGDdOl/Lvo8ao11O6cJPjF7pcZpfAQ8p3ZVXz7b3 Al3uNFzsxpiwI576xFcmH+8q5LUVtt9B4Qh2Z/F/Mp/CZPL59TLpVvJ/2jpDK08PDTcr mGv0qTkZlNOsRRUR0K3j82rC65Livjpr181WCr/Ki/nVuh3VS5H4l5zyy31O/TnSTzSe NgGw2VfDm1X5bKXhzUbRA5SUIUMcYjZy1MjwAydwi0dahH+AcqAAneCL/mh2+3CjSvMf FpOo7t81etQIC00LMm2r7vglKk7b8uZe0quxkeOj4LA2f+wSjumCvynn3+bVA2L1irzj mkvA== X-Gm-Message-State: APjAAAXH3gjEar7DDok4SkdF5UH3w2KAv9Ki3ppIzVJKDhnR2Ct5jwh3 XLyZkMnabIZEX54bwdcwkFI= X-Received: by 2002:a5d:680d:: with SMTP id w13mr4504587wru.141.1561567456730; Wed, 26 Jun 2019 09:44:16 -0700 (PDT) Received: from [10.67.50.91] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id t1sm24161642wra.74.2019.06.26.09.44.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jun 2019 09:44:16 -0700 (PDT) Subject: Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox To: Peng Fan , Jassi Brar Cc: Rob Herring , Mark Rutland , Sudeep Holla , ", Sascha Hauer" , dl-linux-imx , Shawn Guo , "festevam@gmail.com" , Devicetree List , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , Andre Przywara , "van.freenix@gmail.com" References: <20190603083005.4304-1-peng.fan@nxp.com> <20190603083005.4304-3-peng.fan@nxp.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Wed, 26 Jun 2019 09:44:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/26/19 6:31 AM, Peng Fan wrote: >>> The firmware driver might not have func-id, such as SCMI/SCPI. >>> So add an optional func-id to let smc mailbox driver could >>> use smc SiP func id. >>> >> There is no end to conforming to protocols. Controller drivers should >> be written having no particular client in mind. > > If the func-id needs be passed from user, then the chan_id suggested > by Sudeep should also be passed from user, not in mailbox driver. > > Jassi, so from your point, arm_smc_send_data just send a0 - a6 > to firmware, right? > > Sudeep, Andre, Florian, > > What's your suggestion? SCMI not support, do you have > plan to add smc transport in SCMI? On the platforms that I work with, we have taken the liberty of implementing SCMI in our monitor firmware because the other MCU we use for dynamic voltage and frequency scaling did not have enough memory to support that and we still had the ability to make that firmware be trusted enough we could give it power management responsibilities. I would certainly feel more comfortable if the SCMI specification was amended to indicate that the Agent could be such a software entity, still residing on the same host CPU as the Platform(s), but if not, that's fine. This has lead us to implement a mailbox driver that uses a proprietary SMC call for the P2A path ("tx" channel) and the return being done via either that same SMC or through SGI. You can take a look at it in our downstream tree here actually: https://github.com/Broadcom/stblinux-4.9/blob/master/linux/drivers/mailbox/brcmstb-mailbox.c If we can get rid of our own driver and uses a standard SMC based mailbox driver that supports our use case that involves interrupts (we can always change their kind without our firmware/boot loader since FDT is generated from that component), that would be great. -- Florian