Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1108127ybd; Wed, 26 Jun 2019 11:19:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwS/yq2FKLLe0cBNj5UClgTJC7+iXoY9u5XgWpro3pMqfvZhFQA/7dPRyRjdmFjXjn4i4XE X-Received: by 2002:a63:ec13:: with SMTP id j19mr4153083pgh.174.1561573161393; Wed, 26 Jun 2019 11:19:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561573161; cv=none; d=google.com; s=arc-20160816; b=JQY6VsoxQFo32cv5r+FhXwhvUEpNlcgkysnfnSWmBQWNjCdBChZwZ6LcyLh03WNGE5 zTsMQV9suqZ9Qn8xuPe+smHDwL3e1N3PMM0dsry+V8E65NWXUGWTg/X+L7NsiNfXmxkm FFkTbEX7ZrCwN1/4rb2ljIjAqtscBVmkS2OlAeihMxTLV9NK8P45LhtGuh5n6RFfBIfO NQfRTtElcBp7ueLfhN7Hb9KLXpGeJayoevXs5D7YPff6Frue1JLYO8Xfb7tXJRhFqYVv +xkrpwSKs44MWFdB93VZgM61reCflHR4vMjdl9Cd4Hofh3kJ4xBcOPyGnWOeEPwhTdqk naVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:user-agent:cc:subject :from:to:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=ngfloKnnEljm5koGJ5y0rZ8cyy4BPg9KdJZKx/SEddk=; b=0Y6f2wyObd1saDBCQ7DLLbW9phz6V8FVdPd+MzITDRvvKmZf1o1Z35SK3dMmaR8ALT 3opuueteTlyQhmV4QbHlUJU7kTqx6RhIOllOEzi6+OoNAejv3za8reTaE6Y8uXRtrJVG wJXb/UX48GdV6fHRwVW9gjaXEp5wW/uKH15x/JUZD5mdKU+TLusibqoBIv+RY601XDz3 3K8mFJ98N0wzCLxcqbjMIatAlrMmpoXOFiF1wWVHqmmetYaaYcllSCG4ieb1dQSBtYmA 1/WppbLXjgJxU/qMWmdK/MDQIlyw7ZBYKowILIsEzYe2ScTgkfsYE9m10QE/AZfMtHpq KSnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2rBqUqBZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o71si2555135pjb.8.2019.06.26.11.19.04; Wed, 26 Jun 2019 11:19:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2rBqUqBZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726652AbfFZSQt (ORCPT + 99 others); Wed, 26 Jun 2019 14:16:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:60540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726223AbfFZSQs (ORCPT ); Wed, 26 Jun 2019 14:16:48 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 993C221726; Wed, 26 Jun 2019 18:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561573007; bh=ngfloKnnEljm5koGJ5y0rZ8cyy4BPg9KdJZKx/SEddk=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=2rBqUqBZkbNa47oKYmqOlCjsXw7fvrPVeaLx3mkT665MfNL2CP8LtDZM1AaGPICRt TphgoDg2KmGK3cMU/FMdW3vXX+c2+D+CUS4nQkjeQThHu42C6vpRTp0cDyh8xN7GzO QtzeTx5T3Z7Nig2Y4fx7qYmoUSfRnLTC7iOIK+3s= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190522011504.19342-4-zhang.chunyan@linaro.org> References: <20190522011504.19342-1-zhang.chunyan@linaro.org> <20190522011504.19342-4-zhang.chunyan@linaro.org> To: Chunyan Zhang From: Stephen Boyd Subject: Re: [PATCH v2 3/3] clk: sprd: Add check for return value of sprd_clk_regmap_init() Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Orson Zhai , Chunyan Zhang , Baolin Wang User-Agent: alot/0.8.1 Date: Wed, 26 Jun 2019 11:16:46 -0700 Message-Id: <20190626181647.993C221726@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Chunyan Zhang (2019-05-21 18:15:03) > sprd_clk_regmap_init() doesn't always return success, adding check > for its return value should make the code more strong. >=20 > Signed-off-by: Chunyan Zhang > Reviewed-by: Baolin Wang > --- Applied to clk-next