Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1123800ybd; Wed, 26 Jun 2019 11:36:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqxufC6mnnNLudejwaKsL6P4LP9LO+KGyxQ1BumCSPBXceu8ts9M6o7aclayH91B1yKnqGiJ X-Received: by 2002:a63:735d:: with SMTP id d29mr4317622pgn.276.1561574190019; Wed, 26 Jun 2019 11:36:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561574190; cv=none; d=google.com; s=arc-20160816; b=wuOHIUbozfJIn4/kbx4OfmZTJxPBYSxNlt6fi/Akh9/TUZfJhZOmllNdkbgmQ6Yfh8 9jg1fFJ4gLKB2NdJA5+8gjKb4/7lO6Hu+TocGUb4RUMM5VBROqclw9DSceab1C1DbxWn 1K5GcrqKKFgobBSvHD44R+y3IhABM2Zx87ieoi+loTKqTWvwLik2QzuhVUte7GmoZ/aJ qtNXcP1uN44Klr+rKB94Ec7Xb1gh7kmuheDXX+R6J1CSjvZKu+rUZIktnqxiurWXcmI4 zG5ryCLUxTVCMtw/uzMuU8Jm6GJCUUwV0uzzvZaaq2bRjhH4Baa9lOMQIhjUzvHZyVs7 Fuag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=w8Pa/im4y5h7DkkEGS3uN7ZgITpB7XpwK8QeF9bgxZg=; b=X5i6eDeq3DqTggVhcCm+zs0Mz5oCX39MlL6OAipfH1s4pAEOxv3BYtLcNmNRtk9+Qc Fi2tniLfBEMvHW7KqaoER/S3NK+1Fl6NJC6yhmCDrP6bvJBcoJtaQCI0dqGgb4NKMouk grf52+A1uQPZt1YcOQZiDIFs7SAKQP7kPRPjIls9RDWouIzu2OIfz+piIbOtxCx2+x1b N6AN7X1fQcqDgw98vvH9QPfowCqT/eWoxapYMqxuqrxR2Z0vqh3sZwzTNO5OSay/b9Wn zu/3J15g5Pce39aDG7aJDJsVW3L2bYwtXnkFeJZXOUxVpXuSTkvctq95t/3scT3mnZan gttQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cu6si481559pjb.102.2019.06.26.11.36.13; Wed, 26 Jun 2019 11:36:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbfFZSfa (ORCPT + 99 others); Wed, 26 Jun 2019 14:35:30 -0400 Received: from saturn.retrosnub.co.uk ([46.235.226.198]:35694 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbfFZSf2 (ORCPT ); Wed, 26 Jun 2019 14:35:28 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id BAC2A9E7F55; Wed, 26 Jun 2019 19:35:25 +0100 (BST) Date: Wed, 26 Jun 2019 19:35:24 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: , , , , Michael Hennerich Subject: Re: [PATCH 3/5] iio: imu: adis: Add support for SPI transfer cs_change_stall_delay_us Message-ID: <20190626193524.2bf08a14@archlinux> In-Reply-To: <20190625131328.11883-3-alexandru.ardelean@analog.com> References: <20190625131328.11883-1-alexandru.ardelean@analog.com> <20190625131328.11883-3-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jun 2019 16:13:26 +0300 Alexandru Ardelean wrote: > The ADIS16460 requires a higher delay before the next transfer. Since the > SPI framework supports configuring the delay before the next transfer, this > driver will become the first user of it. > > The support for this functionality in ADIS16460 requires an addition to the > ADIS lib to support the `cs_change_stall_delay_us` functionality in SPI. > > Signed-off-by: Michael Hennerich > Signed-off-by: Alexandru Ardelean Subject to previous patch naming etc, this is fine and I'll pick it up once that's sorted. Thanks, Jonathan > --- > drivers/iio/imu/adis.c | 9 +++++++++ > include/linux/iio/imu/adis.h | 2 ++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c > index c771ae6803a9..90dac69910b3 100644 > --- a/drivers/iio/imu/adis.c > +++ b/drivers/iio/imu/adis.c > @@ -40,28 +40,33 @@ int adis_write_reg(struct adis *adis, unsigned int reg, > .len = 2, > .cs_change = 1, > .delay_usecs = adis->data->write_delay, > + .cs_change_stall_delay_us = adis->data->cs_stall_delay, > }, { > .tx_buf = adis->tx + 2, > .bits_per_word = 8, > .len = 2, > .cs_change = 1, > .delay_usecs = adis->data->write_delay, > + .cs_change_stall_delay_us = adis->data->cs_stall_delay, > }, { > .tx_buf = adis->tx + 4, > .bits_per_word = 8, > .len = 2, > .cs_change = 1, > .delay_usecs = adis->data->write_delay, > + .cs_change_stall_delay_us = adis->data->cs_stall_delay, > }, { > .tx_buf = adis->tx + 6, > .bits_per_word = 8, > .len = 2, > .delay_usecs = adis->data->write_delay, > + .cs_change_stall_delay_us = adis->data->cs_stall_delay, > }, { > .tx_buf = adis->tx + 8, > .bits_per_word = 8, > .len = 2, > .delay_usecs = adis->data->write_delay, > + .cs_change_stall_delay_us = adis->data->cs_stall_delay, > }, > }; > > @@ -134,12 +139,14 @@ int adis_read_reg(struct adis *adis, unsigned int reg, > .len = 2, > .cs_change = 1, > .delay_usecs = adis->data->write_delay, > + .cs_change_stall_delay_us = adis->data->cs_stall_delay, > }, { > .tx_buf = adis->tx + 2, > .bits_per_word = 8, > .len = 2, > .cs_change = 1, > .delay_usecs = adis->data->read_delay, > + .cs_change_stall_delay_us = adis->data->cs_stall_delay, > }, { > .tx_buf = adis->tx + 4, > .rx_buf = adis->rx, > @@ -147,11 +154,13 @@ int adis_read_reg(struct adis *adis, unsigned int reg, > .len = 2, > .cs_change = 1, > .delay_usecs = adis->data->read_delay, > + .cs_change_stall_delay_us = adis->data->cs_stall_delay, > }, { > .rx_buf = adis->rx + 2, > .bits_per_word = 8, > .len = 2, > .delay_usecs = adis->data->read_delay, > + .cs_change_stall_delay_us = adis->data->cs_stall_delay, > }, > }; > > diff --git a/include/linux/iio/imu/adis.h b/include/linux/iio/imu/adis.h > index 469a493f7ae0..4aa248b6b3bd 100644 > --- a/include/linux/iio/imu/adis.h > +++ b/include/linux/iio/imu/adis.h > @@ -27,6 +27,7 @@ struct adis_burst; > * struct adis_data - ADIS chip variant specific data > * @read_delay: SPI delay for read operations in us > * @write_delay: SPI delay for write operations in us > + * @cs_stall_delay: SPI stall delay between transfers in us > * @glob_cmd_reg: Register address of the GLOB_CMD register > * @msc_ctrl_reg: Register address of the MSC_CTRL register > * @diag_stat_reg: Register address of the DIAG_STAT register > @@ -36,6 +37,7 @@ struct adis_burst; > struct adis_data { > unsigned int read_delay; > unsigned int write_delay; > + unsigned int cs_stall_delay; > > unsigned int glob_cmd_reg; > unsigned int msc_ctrl_reg;