Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1130945ybd; Wed, 26 Jun 2019 11:44:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqw2qjQwC4Bq/mZcAFFMmf684sfRpxXlw6ldy8fL8LyQGDHS1nu9hNx6DkVptX2Fq3wa/+hF X-Received: by 2002:a17:90a:fa12:: with SMTP id cm18mr598506pjb.137.1561574695591; Wed, 26 Jun 2019 11:44:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561574695; cv=none; d=google.com; s=arc-20160816; b=kNV7vc04QjwRHTkT0XeJdp68SxwtL4YQsrAcFTCCqg5Ew8lP5l2Plu0Nn6Zmsdhes1 BFQdIfZ28Dk17MYKCcRp23LpgRjL1bRK91dU/NJNWx6e3bj2FZk4bgcPcrRG4eRgKFiR 2Ybe3W8EBC8WWx+wJqvY6aLcOqc8acvYh0G1KFBDseV4XMmOGBGaLQacVxpyEmBFUJX8 9/Uq8SvQUy99HvJH4juqko+Xi0+GwXL0ecPACGUf+kd7lcNAuDnJAXG/Laa2ZptXhoBi Ck0qRrpk6yoZ2S2BcsixmpDjq5eNyg3KpruncthCvpmWpuqlcJ3fVjm1Mm/PbIzulN8u R96w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3TBLLk6wLcUnDfjG98IQu8SFRff4fUj3n5OjjYJB6sM=; b=ZPAXLVDCM0TJ/XpcxoEwzfG8LRwhXPa+1nWz61jNj2htLOZvkZU3paVQHu+IMwgJNo 4+Xa1vl9av3V5tB+VnGOkstMicfrWagrEkP6HPudnQuuQecSi4CWI1uwU5SUQLngBkOa Eq0To8LdM8ZfFxgRCBaIevaphQjTgonSHK1HJRH54z3CzDzwNFpidXIiUYKzM6SOMbMI exhmU7BDs/cAymYRaxcqUM6LWfixI8+NAgDULSmvAW8/9Wi/Y7o2nZuKKy/7mrDdBGCC noZ/TK2SWtx3H6GAxMloi7OIFnEhfyp4SGvmO8OyAuI26HLeww1hgUEjqlVizpGOKbfb mDhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iLmqEE0O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g23si18154799pfi.153.2019.06.26.11.44.39; Wed, 26 Jun 2019 11:44:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iLmqEE0O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726583AbfFZSn2 (ORCPT + 99 others); Wed, 26 Jun 2019 14:43:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:49908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbfFZSn2 (ORCPT ); Wed, 26 Jun 2019 14:43:28 -0400 Received: from linux-8ccs (ip5f5adbbc.dynamic.kabel-deutschland.de [95.90.219.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38C3D20659; Wed, 26 Jun 2019 18:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561574607; bh=3TBLLk6wLcUnDfjG98IQu8SFRff4fUj3n5OjjYJB6sM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iLmqEE0O6gxXsxIYBGCGtFAEnrrx4qDSBhsYQhC7FEyIeQblQpqsiuN8XXZcaW9ks RFEVrdafYFD27+VdH5qOT3TnO31Gs+Ut2XAya2VU6VU41URWbd3WcFnkrXFEPSSBPP wwGu2zjBzSfObh2+m9tb3tttTuQUBRBxB5ydm8nk= Date: Wed, 26 Jun 2019 20:43:22 +0200 From: Jessica Yu To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, namit@vmware.com, cj.chengjian@huawei.com, sfr@canb.auug.org.au, linux-next@vger.kernel.org Subject: Re: [PATCH] modules: fix compile error if don't have strict module rwx Message-ID: <20190626184322.GB16326@linux-8ccs> References: <1561455628-50795-1-git-send-email-yangyingliang@huawei.com> <20190625192115.GA27913@linux-8ccs> <5D12E83B.9000209@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <5D12E83B.9000209@huawei.com> X-OS: Linux linux-8ccs 5.1.0-rc1-lp150.12.28-default+ x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Yang Yingliang [26/06/19 11:36 +0800]: > > >On 2019/6/26 3:21, Jessica Yu wrote: >>+++ Yang Yingliang [25/06/19 17:40 +0800]: >>>If CONFIG_ARCH_HAS_STRICT_MODULE_RWX is not defined, >>>we need stub for module_enable_nx() and module_enable_x(). >>> >>>If CONFIG_ARCH_HAS_STRICT_MODULE_RWX is defined, but >>>CONFIG_STRICT_MODULE_RWX is disabled, we need stub for >>>module_enable_nx. >>> >>>Move frob_text() outside of the CONFIG_STRICT_MODULE_RWX, >>>because it is needed anyway. >> >>Maybe include a fixes tag? >> >>Fixes: 2eef1399a866 ("modules: fix BUG when load module with rodata=n") >OK, I will add it in v2. No need to, I've added the fixes tag and queued it up on modules-next. Thanks! Jessica