Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1152805ybd; Wed, 26 Jun 2019 12:09:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwIJwZ5TMoMe10UJSpmWQ5D0XFiNtWaJlqs2CJh7xM4eAooeYBBMloYA6QlwUGuaYcNcC1Z X-Received: by 2002:a63:1b66:: with SMTP id b38mr4467126pgm.54.1561576176427; Wed, 26 Jun 2019 12:09:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561576176; cv=none; d=google.com; s=arc-20160816; b=JiYYnMY7/6xUsBx/YNCK36bzHFmZoIVw4BbXezy05I03nibTMiaI2M/PzSwETS978q dAEbkQeWIGxsTT3dxvEQer/x+3uusEqiBvlj96R3iecVn9PkgDLzqFGfuz2jkE2lFIqA YA5kezxPtAal0M/CNeUuoKgdtBtvYjtQNhNdITOx+jYOQ6FUuXhYi14qx2i07gBguW7n HY+RwZH7pxBwylvnP3U+X2c2UQ0tpENrp+2lyGb/uT+LOwB+sspQ5saQfE+KESWDB5uL UUJ4YO3E070lQCEz+21Xz1FZXzdpbvoT0qX8F9OKFrxDaggWO3YMI7g5wQ+xQeuRsLia 6okw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=1zZYAuiqE5ZU5RZf7K0jdlZLPDRx2Mh5nInBwAuU5x0=; b=tTcEctAQw7OoVzjYnjpZM4VoagQH/EukPJK6jSfkAFO5QDc1NfdzRn2hhvOThVBA/0 Q7rpI/r1yR5qKcSOxNUB2DzF85bIXxgRX7TF48zWTlTI+52qolzDnxqAHhYiZZL1zELi 4Jxi4ylMJMP70FdTjFnMescAln9MG2jhQNsw+4Q5t5yUpr1/7HIdIbSjAYyvNED/aT1E vt2yDDGfSu7ZM3P+R4R0HZqW0TCLDUq2YcWoLKLJ9Iqyr3fPTRgZUjNYcxE1T4A7YN+d x0qiVn+/gr7lKgy8omuol3gKQRKNJUK+lYk8p5jNNDJMOC1WrtuQju7voYnMUJ2V2kdN qIgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s18si3875315plp.128.2019.06.26.12.09.19; Wed, 26 Jun 2019 12:09:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbfFZTJM (ORCPT + 99 others); Wed, 26 Jun 2019 15:09:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:15052 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbfFZTJL (ORCPT ); Wed, 26 Jun 2019 15:09:11 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2019 12:09:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,420,1557212400"; d="scan'208";a="162375579" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by fmsmga008.fm.intel.com with ESMTP; 26 Jun 2019 12:09:08 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hgDI2-0002RV-PU; Wed, 26 Jun 2019 22:09:06 +0300 Date: Wed, 26 Jun 2019 22:09:06 +0300 From: Andy Shevchenko To: Charles Keepax Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com, jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com Subject: Re: [PATCH v7 2/6] i2c: acpi: Use available IRQ helper functions Message-ID: <20190626190906.GA9224@smile.fi.intel.com> References: <20190626150302.22703-1-ckeepax@opensource.cirrus.com> <20190626150302.22703-3-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190626150302.22703-3-ckeepax@opensource.cirrus.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 26, 2019 at 04:02:58PM +0100, Charles Keepax wrote: > Use the available IRQ helper functions, most of the functions have > additional helpful side affects like configuring the trigger type of the > IRQ. > - acpi_dev_free_resource_list(&resource_list); I have thought that we can drop completely the resource_list, though ACPI doesn't allow this. So, I would rather withdraw this change to be on the safe (symmetrical) side. -- With Best Regards, Andy Shevchenko