Message-ID: <4389DFA1.7000105@shadowconnect.com>
Date: Sun, 27 Nov 2005 17:32:33 +0100
From: Markus Lidel <Markus.Lidel@shadowconnect.com>
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
MIME-Version: 1.0
To: Adrian Bunk <bunk@stusta.de>
CC: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/message/i2o/pci.c: fix a NULL pointer dereference
References: <20051126233705.GD3988@stusta.de>
In-Reply-To: <20051126233705.GD3988@stusta.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1024
Lines: 33

Hello,

Adrian Bunk wrote:
> The Coverity checker spotted this obvious NULL pointer dereference.
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Signed-off-by: Markus Lidel <Markus.Lidel@shadowconnect.com

> This patch was already sent on:
> - 23 Nov 2005
> - 21 Nov 2005

Sorry, didn't know i have to answer to it. Next time i will respond earlier.

Thank you very much for this patch!

> --- linux-2.6.15-rc1-mm2-full/drivers/message/i2o/pci.c.old	2005-11-20 21:50:45.000000000 +0100
> +++ linux-2.6.15-rc1-mm2-full/drivers/message/i2o/pci.c	2005-11-20 21:51:08.000000000 +0100
> @@ -421,8 +421,8 @@
>  	i2o_pci_free(c);
>  
>        free_controller:
> -	i2o_iop_free(c);
>  	put_device(c->device.parent);
> +	i2o_iop_free(c);
>  
>        disable:
>  	pci_disable_device(pdev);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/