Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1198758ybd; Wed, 26 Jun 2019 13:04:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqySHzdvP9qiiG7zcPz+lTMyQLkfK3YHpRsu/c7wBzXnNBS8egL0K6+O0Qjc+0DeFGLZq5wj X-Received: by 2002:a63:5212:: with SMTP id g18mr2558295pgb.387.1561579482544; Wed, 26 Jun 2019 13:04:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561579482; cv=none; d=google.com; s=arc-20160816; b=z51dBm2TijopG0w8y2ssnWVf0qo+0FK4x57wBMUI5H7bEEVwKHQR/Bvqrtm66hSH1G h7YuoruA4PbzLeMMWy9NojZ1K7kYKNqQ3BGcEY4etuPinCjM6bE3UDVLh4QRwRny8COL 8rnncoZewVph7J+snxxS3uZ0dAmJYVDRjsepuIjwNoXgHd62s2XrvhlUR9WBwJimUw4I x0bawXZg73v+C6jjuL0ubAk2sxqc36Ptsn6L3t/CYXVEn0VNF4QWcWui/FFF97eECoiT h84vge6Ezkq0k0z8AtYZNurfxEFwlVKoP3iVhI7hw1iDfiBjhA8szfMuUk8EeWJYrvWx iMUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=k/UfQ4e5C37ktvXcxqUnrSGdIJj4bG8yOyogvtJrQ10=; b=jOnK1wwSp9C4WYe8JzGr/BYo+pjNHq446sYxcbDglToUQs2JUzIcfQZJdILpIX+itI Yruss9q5tzLLZd8vXH/pIy9sfbwjBM7/XAspQ1ZmYk1HX3HNp/iVJDDsYF4lAcEY/jZ0 afrDD4QDW60gWOZJiAGPwDFyr93Pq31sTiXaQu9DDByP1JkoovfC1/E8iFzRLjl7ylVJ FUoYkMoePHme3bQ1NfYJvKL8eUraJRWUN2OeiYKjR1lQLlOg3Pzgh1ORZS6NOuQ5/sB+ xeOBCjtZjf15zuIjji6LZUIJzKPwMfLoI2QFe/u7z6mf4l1WkPxXNtZI2k2cw750r5T1 rr4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s22si17649828pga.189.2019.06.26.13.04.26; Wed, 26 Jun 2019 13:04:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726511AbfFZUDu (ORCPT + 99 others); Wed, 26 Jun 2019 16:03:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40778 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbfFZUDt (ORCPT ); Wed, 26 Jun 2019 16:03:49 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DA22C14DB71D4; Wed, 26 Jun 2019 13:03:48 -0700 (PDT) Date: Wed, 26 Jun 2019 13:03:48 -0700 (PDT) Message-Id: <20190626.130348.743645536748522991.davem@davemloft.net> To: skhan@linuxfoundation.org Cc: gnomes@lxorguk.ukuu.org.uk, puranjay12@gmail.com, bjorn@helgaas.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates From: David Miller In-Reply-To: <5f04f52d-8911-4db9-4321-00334d357d54@linuxfoundation.org> References: <20190621094607.15011-1-puranjay12@gmail.com> <20190621162024.53620dd9@alans-desktop> <5f04f52d-8911-4db9-4321-00334d357d54@linuxfoundation.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Jun 2019 13:03:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shuah Khan Date: Fri, 21 Jun 2019 10:36:02 -0600 > Stephen Hemminger is suggesting removal as well. Makes sense to me. ... > What would you recommend the next steps are? Would like driver > removed? If you hadn't proposed the cleanups nobody would have said to remove this driver. Really if someone wants to go through the tree and send removal patches for seemingly really unused drivers, that is a separate piece of work unrelated to your cleanup. While something still is in the tree we should clean it up from stuff like this. Therefore, I'll be applying v5 of your changes, thanks.