Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1202241ybd; Wed, 26 Jun 2019 13:08:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDmzWr5Mh38p6PYse3V/ql6dCe6kzMSLf6LFta0S1g0rb+CckQ0Dag0HHRYByWbCQfKrI9 X-Received: by 2002:a17:90a:cb15:: with SMTP id z21mr1053097pjt.87.1561579709161; Wed, 26 Jun 2019 13:08:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561579709; cv=none; d=google.com; s=arc-20160816; b=cJMaPDA9fLqy0/woNVa9ESs3BOzttkpT3AjnRV07nNoC638gHruuwIa5F1WG9/77+k Oi1mhfIcLgvE0L1x6tLZmZCHt4Sjvc5/6HfkKZkhWqYmjsF9kR9W6xWb20jbis16gaLB j2ETaSnS7p6cG9Q4GeHs9uYrUJ5i9Q+bv+TICJV9X0Yll1PZZMlz4/HaTWzLsEeXs6hP 7EATMaYQ26KHLCuliDVUpM0CdvXclERA25fOWZVhNopGtwTt94lPzLcF9fmTCQ5kAnBz U6Kl4c8JSMeIGseEnfVGoXoeR6rMgatuKNO0zCzYC0dRq+Lnbqkba7OzpO82mRKA7Zhn VeMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=kYklNIrSrLJyVvVrtrmlbWbz9ECHmexyziQG4fzqorc=; b=ihUJ4hLi/b+Iv9TBoCqaMKLfVcXhoYYw6gd2e7EDakPq4Ip+uROxgw1YAe3VHnVuaF /IIe/Tr7b5K8+Jfn5vyUQNb25X+XAhQ4Cjcyz5qK9kyhOLYXVkNw34ykLqZ4r9Gmwfjk 7z+7h4TvvfnYU16OETKZNHhp9gv03FTM6vsuXu8p8RQmO4G7AXPVGKLAw6QN70UymPIz C/IPgNCtmE6ki/L7eT+UTaK8cGiiWWPOs+Lq3nE98ow+W2yY7vvw1nR3XlQ47yo4Rpcv dCLCh6Ksn+KGN51X272mRYJK1bTkQfXxrre7EwjgQeYzHZCAhtQgAREPMoJZpCBGwho8 CjWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j65si84200plb.103.2019.06.26.13.08.12; Wed, 26 Jun 2019 13:08:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726550AbfFZUHa (ORCPT + 99 others); Wed, 26 Jun 2019 16:07:30 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40872 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbfFZUHa (ORCPT ); Wed, 26 Jun 2019 16:07:30 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7FA4E14DB8366; Wed, 26 Jun 2019 13:07:29 -0700 (PDT) Date: Wed, 26 Jun 2019 13:07:29 -0700 (PDT) Message-Id: <20190626.130729.2125111135503705774.davem@davemloft.net> To: puranjay12@gmail.com Cc: skhan@linuxfoundation.org, bjorn@helgaas.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 3/3] net: ethernet: atheros: atlx: Remove unused and private PCI definitions From: David Miller In-Reply-To: <20190621163921.26188-4-puranjay12@gmail.com> References: <20190621163921.26188-1-puranjay12@gmail.com> <20190621163921.26188-4-puranjay12@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Jun 2019 13:07:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Puranjay Mohan Date: Fri, 21 Jun 2019 22:09:21 +0530 > Remove unused private PCI definitions from skfbi.h because generic PCI > symbols are already included from pci_regs.h. > > Signed-off-by: Puranjay Mohan Please also handle the PCI register bit value define duplications as well, as pointed out by Bjorn. Thanks.