Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] platform/chrome: lightbar: Assign drvdata during probe
To:     Rajat Jain <rajatja@google.com>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        linux-kernel@vger.kernel.org
Cc:     evgreen@google.com, rajatxjain@gmail.com
References: <20190625205101.33032-1-rajatja@google.com>
From:   Enric Balletbo i Serra <enric.balletbo@collabora.com>
Message-ID: <a755588b-1062-7c4f-7c03-f35ca23f39a4@collabora.com>
Date:   Wed, 26 Jun 2019 22:34:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.1
MIME-Version: 1.0
In-Reply-To: <20190625205101.33032-1-rajatja@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rajat,

On 25/6/19 22:51, Rajat Jain wrote:
> The lightbar driver never assigned the drvdata in probe method, and thus
> causes a panic when it is accessed at the suspend time.

Good catch, that's one of the problems I currently have with mainline on Samus.
The other one, that I didn't find time to look at is, that for some reason, when
I suspend the system reboots. Is suspend/resume working for you in current mainline?

There is no drvdata because we don't really need extra private data for this
driver, the ec_dev is directly the drvdata provided by device parent. I am
wondering if you can just do

   struct cros_ec_dev *ec_dev = to_cros_ec_dev(dev);

in the suspend/resume calls like we do in the show/store calls or get the
drvdata from its parent. I guess I prefer the first one.

> 

Would be nice have a fixes tag here.

> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
>  drivers/platform/chrome/cros_ec_lightbar.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
> index d30a6650b0b5..98e514fc5830 100644
> --- a/drivers/platform/chrome/cros_ec_lightbar.c
> +++ b/drivers/platform/chrome/cros_ec_lightbar.c
> @@ -578,11 +578,14 @@ static int cros_ec_lightbar_probe(struct platform_device *pd)
>  
>  	ret = sysfs_create_group(&ec_dev->class_dev.kobj,
>  				 &cros_ec_lightbar_attr_group);
> -	if (ret < 0)
> +	if (ret < 0) {
>  		dev_err(dev, "failed to create %s attributes. err=%d\n",
>  			cros_ec_lightbar_attr_group.name, ret);
> +		return ret;
> +	}
>  
> -	return ret;
> +	platform_set_drvdata(pd, ec_dev);
> +	return 0;
>  }
>  
>  static int cros_ec_lightbar_remove(struct platform_device *pd)
> 

Thanks,
~ Enric