Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1254603ybd; Wed, 26 Jun 2019 14:10:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqx+gA9lQqJ3A+hzSvhz0c1YXOZJcJFwmecEsSF3LhZ+TvgGCOCwRzWZBRZIwDNPWuNIcQPB X-Received: by 2002:a17:902:7c8e:: with SMTP id y14mr162708pll.298.1561583421444; Wed, 26 Jun 2019 14:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561583421; cv=none; d=google.com; s=arc-20160816; b=W6u6YQQfYHbFT9s1li6DBGrPuxVW2NFn3WeG5Kxs4KDJl7t1NxPI2Z7OYoQzM/tVuN upCiOqzxWfyXG480i5Ya77IOUxDBpaSc3vZxlA8jKw1ekBAhZd/d9kOTIVXilRIRcnqW Koon5tMYKCI0aviuCXH+QD/Ji7WhDAlgPrcM2fPR+rl+1lsjQnGGQyfNjJsAo3VQlzbv /drgqBGJKlvVG2yP/ze4woaOyK5qRZm03VtYUDWBHeyXucWJO0KOq45M7ou/QiJUpSUQ 0tXy4wf2CQdOdhec4UshsbVPiM0Byvcx1VTsNTV63rvRCHazDdmE6cd3y26wxlSPIYrI gclA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=TWRqlHNEoRTM2RoSqQR5XHhWWHcsHzMj/qElcklExME=; b=qKz6dpWyR2CO0bc+GbfJn/FaS0vxCEF06zVMskP+Bbltc5vICz0DWFzB5n+BH2G9HP 3xvdq0gN+hPuRqH+8t/Gevqqthfe5i7ya/ZHa6MsfGsasfIHO6aET3km36SfOCpOpoq1 qKdNEFGqKu0Tb/O85mHdoXckwSzyyWJih0mcwWzQUJiao/YWil3kxAi2qpctYD7cV+ii Z39aTkiqiyJxHANz6dITV73LhsFwU+08p2ydGSVGNdTzvy3d58Kn044v+mpf8UN+oMX6 tpBjaE+yw0GMgo+ZqhlY3zVCn1ohj7b9nm/smUE+f4h54qVByRoikOTaMuuVMumugkoY q6BQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o6si68488pls.251.2019.06.26.14.10.04; Wed, 26 Jun 2019 14:10:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbfFZVJ7 (ORCPT + 99 others); Wed, 26 Jun 2019 17:09:59 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41734 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbfFZVJ7 (ORCPT ); Wed, 26 Jun 2019 17:09:59 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D77DA14DD9E46; Wed, 26 Jun 2019 14:09:58 -0700 (PDT) Date: Wed, 26 Jun 2019 14:09:56 -0700 (PDT) Message-Id: <20190626.140956.1543752418469724857.davem@davemloft.net> To: palmer@sifive.com Cc: nicolas.ferre@microchip.com, harinik@xilinx.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: net: macb: Fix compilation on systems without COMMON_CLK, v2 From: David Miller In-Reply-To: <20190625084828.540-1-palmer@sifive.com> References: <20190625084828.540-1-palmer@sifive.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Jun 2019 14:09:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Palmer Dabbelt Date: Tue, 25 Jun 2019 01:48:26 -0700 > Our patch to add support for the FU540-C000 broke compilation on at > least powerpc allyesconfig, which was found as part of the linux-next > build regression tests. This must have somehow slipped through the > cracks, as the patch has been reverted in linux-next for a while now. > This patch applies on top of the offending commit, which is the only one > I've even tried it on as I'm not sure how this subsystem makes it to > Linus. > > This patch set fixes the issue by adding a dependency of COMMON_CLK to > the MACB Kconfig entry, which avoids the build failure by disabling MACB > on systems where it wouldn't compile. All known users of MACB have > COMMON_CLK, so this shouldn't cause any issues. This is a significantly > simpler approach than disabling just the FU540-C000 support. > > I've also included a second patch to indicate this is a driver for a > Cadence device that was originally written by an engineer at Atmel. The > only relation is that I stumbled across it when writing the first patch. > > Changes since v1 <20190624061603.1704-1-palmer@sifive.com>: > > * Disable MACB on systems without COMMON_CLK, instead of just disabling > the FU540-C000 support on these systems. > * Update the commit message to reflect the driver was written by Atmel. Series applied, thanks.