Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190627080521.5df8ccfc@canb.auug.org.au> <20190626221347.GA17762@tower.DHCP.thefacebook.com>
In-Reply-To: <20190626221347.GA17762@tower.DHCP.thefacebook.com>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Wed, 26 Jun 2019 16:36:50 -0700
Message-ID: <CAADnVQJiMH=jfuD0FGpr2JmzyQsMKHJ4pM1kfQ8jhSxrAe0XWg@mail.gmail.com>
Subject: Re: linux-next: Fixes tag needs some work in the bpf tree
To:     Roman Gushchin <guro@fb.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Networking <netdev@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 26, 2019 at 3:14 PM Roman Gushchin <guro@fb.com> wrote:
>
> On Thu, Jun 27, 2019 at 08:05:21AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   12771345a467 ("bpf: fix cgroup bpf release synchronization")
> >
> > Fixes tag
> >
> >   Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from
> >
> > has these problem(s):
> >
> >   - Subject has leading but no trailing parentheses
> >   - Subject has leading but no trailing quotes
> >
> > Please don't split Fixes tags across more than one line.
>
> Oops, sorry.
>
> Alexei, can you fix this in place?
> Or should I send an updated version?

I cannot easily do it since -p and --signoff are incompatible flags.
I need to use -p to preserve merge commits,
but I also need to use --signoff to add my sob to all
other commits that were committed by Daniel
after your commit.

Daniel, can you fix Roman's patch instead?
you can do:
git rebase -i -p  12771345a467^
fix Roman's, add you sob only to that one
and re-push the whole thing.