Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1410963ybd; Wed, 26 Jun 2019 17:25:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyJyQKrnNnYRUnGpQWFNjZT19xG/9EBK0mjGX9L4TgBgi5Y+ZCbhzKJN+bePhvtJrzmFnjA X-Received: by 2002:a17:902:f213:: with SMTP id gn19mr1075336plb.35.1561595102089; Wed, 26 Jun 2019 17:25:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561595102; cv=none; d=google.com; s=arc-20160816; b=HSUrjnuNnc4tmHRIgPtgSz6cNUrWyO4TUttTOTh1vntwbJfK143myDBuQeMWNgDe6e J+I4DtQq5L1IAlzw+o0OPxj7HFhObYKQiYTJoynbB/tScf22LZbsKMiIkalvlXefmG7A wDXsCXlhFMPPsuoOxqsd7AACvzwg6asf9GSqQLFNY8txpJFXX70aUy/pzpCSUOGkuhKU S/vQexG4i7ps1sMCbmy13h4FWte1L00E26pviUkatoHfT5+0YQt5x06cHFfKdkw8vfpj W5HwUHCxxf6b5jidPtSSNB7+0EbNX73p3q146HmpetwRZgLPRT4ZFVS/rNA02hvZLjHp f30A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=alD1se/H8oSgNNFyrIfLo/Nfix2/7MSIr7dtHdEMxz0=; b=NPw9/TX7glknAUaonN7kSNRyr/jdfwHMhRWLZPCaWT94pqF3H5KHSvh/SK/JHLvgLL 0w9c6AK8ydcPYljOblJgVQutKMdEKK3UUO69BntiHZKPRYQqLwbHGjZG7Lgk+JZL5oQN ntMxfxM82GFN6mFRPZi6GqFzX30DU6iAFKiLWqha5jKFECLBWNqZ7KeDKFCBHUtC89wG XrqcyWkTZ5J258fa+sB0j/+Kz/xgaZJ0KaiYlKgp2dPbwfxebnKDbE+0TECBOuTJnyKU vFyCdavWv/z0eo1SOkSpGVarDTjd+MwBiBPopD2ITMnZc+KDeWonp3zXU2MmA++8WuGU F9KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nUE3ssRA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z142si741906pfc.128.2019.06.26.17.24.45; Wed, 26 Jun 2019 17:25:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nUE3ssRA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726783AbfF0AY1 (ORCPT + 99 others); Wed, 26 Jun 2019 20:24:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:59896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfF0AY0 (ORCPT ); Wed, 26 Jun 2019 20:24:26 -0400 Received: from localhost (unknown [107.242.116.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89F2820815; Thu, 27 Jun 2019 00:24:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561595066; bh=alD1se/H8oSgNNFyrIfLo/Nfix2/7MSIr7dtHdEMxz0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nUE3ssRAsi7TSkJaT84htx3XrfeVIZO8w2Ah4D0LMJGbTSnCKtsVdGMDNqzj04zoQ yWPiIQMdlZWcsPvXMQnUJDgwHLgl4zv+tC+Pdo87oXr7HimLZf24Izawzep8WHCLWq CVxNTKOwX5JTuZm/dTlmAxGMYvdBRRNXjBFXknww= Date: Wed, 26 Jun 2019 20:24:22 -0400 From: Sasha Levin To: Mark Brown Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ranjani Sridharan , "kernelci . org bot" Subject: Re: [PATCH AUTOSEL 5.1 38/51] ASoC: core: Fix deadlock in snd_soc_instantiate_card() Message-ID: <20190627002422.GO7898@sasha-vm> References: <20190626034117.23247-1-sashal@kernel.org> <20190626034117.23247-38-sashal@kernel.org> <20190626103912.GW5316@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190626103912.GW5316@sirena.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 26, 2019 at 11:39:12AM +0100, Mark Brown wrote: >On Tue, Jun 25, 2019 at 11:40:54PM -0400, Sasha Levin wrote: >> From: Ranjani Sridharan >> >> [ Upstream commit 495f926c68ddb905a7a0192963096138c6a934e1 ] >> >> Move the client_mutex lock to snd_soc_unbind_card() before >> removing link components. This prevents the deadlock >> in the error path in snd_soc_instantiate_card(). > >Again, are you sure there's no dependencies? I'm taking the patch it depends on (also a fix) as part of this AUTOSEL branch. -- Thanks, Sasha