Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1411749ybd; Wed, 26 Jun 2019 17:26:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZYnWah8xnrQyIjcKh0Nm5EB0QHNqM6KetP0R6B4+cU5+nabqoO9TM1L3jXAEENOOpykiN X-Received: by 2002:a17:90a:36e4:: with SMTP id t91mr2261476pjb.22.1561595159913; Wed, 26 Jun 2019 17:25:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561595159; cv=none; d=google.com; s=arc-20160816; b=X7fuETarjDxvpvLihhLmpLOj7UyWOE+WrwOsrGBtrPJjhRm6i00OJk42HAXQapWANZ JOgJVVtKAXx+9dN+/2C2BdNSPPbFzh2Wbbmqon7TXoIdB3E8D+46cyacDr9ZHsgQc51t FVkCHAMBMa4ZiCLcgUUNy/AVSP2b0hIGslL8NBuJeYb2k49mDIOgoKpIVZ0ObEkGKkUC YC5dPIZRZBWpd5hqnAXGYav8Vof63iNUZbfqlew2pu/x+whxJJMu82c2mE2q3YdO79Tq GYjrq57bMWvofOXlfn+0JorSvxVXbuy6Tt5SU2GKhBmV48SaBmgmC/on/Rix0a8Rp03Q V/2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=l5x2VvRl++sXWxBNrMQE3zytnOqiTo0fKg1zqbtx46w=; b=UOwuAek6mIY8VPWzHG3CvGwfz4h3/aEbXTk71z9HrXtBMHlwRlNLXoJyPeao8luJuw iTi5eN1Ay6KM9UvXnPcojD6Ba85pcvC2cl/t/fWvg0D+L0wFVUlJGK2jWBBDSJiCsOia a5HBdpif3VrjWejZJ8KjwQQJ3qSj3R890VPyMtD2rlIqs4O8/VaPjh7txwDIorfWgax1 O1CCw+tT69v8quwhoBRP66jxSKXCpkWY82qnI/JQEe3WLYAIFUY5HrjOgBhSeoeUPy2d 2/ttsgkjd6CNa8ce4hYaM1keCexMBWGPwe9KYrh0Sz/sok8VRT3w5iczQ+/GdVE6F0ey U5/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="cs/+gfhP"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a15si714237pfi.48.2019.06.26.17.25.43; Wed, 26 Jun 2019 17:25:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="cs/+gfhP"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726807AbfF0AZC (ORCPT + 99 others); Wed, 26 Jun 2019 20:25:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:60026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfF0AZC (ORCPT ); Wed, 26 Jun 2019 20:25:02 -0400 Received: from localhost (unknown [107.242.116.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66F0C20815; Thu, 27 Jun 2019 00:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561595101; bh=l5x2VvRl++sXWxBNrMQE3zytnOqiTo0fKg1zqbtx46w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cs/+gfhPiTphyqbKkCAedgK/080En6ogMkzs8OuId21lUsX7nctTpa8kFCUoxIZVW ym9SrZvKu89pXJ0nTObaJNjMzdBqLEMBRLBSbzG1fdJrmphqya/7mG04+JEBlGuutb X5tzXZWlppGoemjAL7H7T3mrSYhH41aoyyYlXurY= Date: Wed, 26 Jun 2019 20:24:57 -0400 From: Sasha Levin To: Mark Brown Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ranjani Sridharan Subject: Re: [PATCH AUTOSEL 5.1 08/51] ASoC: core: lock client_mutex while removing link components Message-ID: <20190627002457.GP7898@sasha-vm> References: <20190626034117.23247-1-sashal@kernel.org> <20190626034117.23247-8-sashal@kernel.org> <20190626103701.GT5316@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190626103701.GT5316@sirena.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 26, 2019 at 11:37:01AM +0100, Mark Brown wrote: >On Tue, Jun 25, 2019 at 11:40:24PM -0400, Sasha Levin wrote: >> From: Ranjani Sridharan >> >> [ Upstream commit 34ac3c3eb8f0c07252ceddf0a22dd240e5c91ccb ] >> >> Removing link components results in topology unloading. So, >> acquire the client_mutex before removing components in >> soc_remove_link_components. This will prevent the lockdep warning >> seen when dai links are removed during topology removal. > >There's additional fixes for this IIRC. The fix is part of this branch, you commented on it as well. -- Thanks, Sasha