Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH RESEND] mfd: hi655x-pmic: Fix missing return value check
 for devm_regmap_init_mmio_clk
To:     Axel Lin <axel.lin@ingics.com>, Lee Jones <lee.jones@linaro.org>
CC:     <linux-kernel@vger.kernel.org>
References: <20190626133007.591-1-axel.lin@ingics.com>
From:   Chen Feng <puck.chen@hisilicon.com>
Message-ID: <40ae33d4-10fd-852a-30e6-db56d709ef1c@hisilicon.com>
Date:   Thu, 27 Jun 2019 10:03:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.3
MIME-Version: 1.0
In-Reply-To: <20190626133007.591-1-axel.lin@ingics.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks

On 2019/6/26 21:30, Axel Lin wrote:
> Since devm_regmap_init_mmio_clk can fail, add return value checking.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Acked-by: Chen Feng <puck.chen@hisilicon.com>
> ---
> This was sent on https://lkml.org/lkml/2019/3/6/904
> 
>   drivers/mfd/hi655x-pmic.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> index 96c07fa1802a..6693f74aa6ab 100644
> --- a/drivers/mfd/hi655x-pmic.c
> +++ b/drivers/mfd/hi655x-pmic.c
> @@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
>   
>   	pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
>   						 &hi655x_regmap_config);
> +	if (IS_ERR(pmic->regmap))
> +		return PTR_ERR(pmic->regmap);
>   
>   	regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver);
>   	if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) {
>