Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190626133007.591-1-axel.lin@ingics.com> <40ae33d4-10fd-852a-30e6-db56d709ef1c@hisilicon.com>
In-Reply-To: <40ae33d4-10fd-852a-30e6-db56d709ef1c@hisilicon.com>
From:   Axel Lin <axel.lin@ingics.com>
Date:   Thu, 27 Jun 2019 10:57:24 +0800
Message-ID: <CAFRkauDFf0qWpovNaaMkB48RXAsRsGEQ_=osSM7+Ze59C8DEkw@mail.gmail.com>
Subject: Re: [PATCH RESEND] mfd: hi655x-pmic: Fix missing return value check
 for devm_regmap_init_mmio_clk
To:     Chen Feng <puck.chen@hisilicon.com>
Cc:     Lee Jones <lee.jones@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Chen,

Chen Feng <puck.chen@hisilicon.com> =E6=96=BC 2019=E5=B9=B46=E6=9C=8827=E6=
=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8A=E5=8D=8810:03=E5=AF=AB=E9=81=93=EF=BC=
=9A
>
> Thanks
I assume this is an Ack.
If you can add your Acked-by in the reply, it's easier for maintainer to ac=
cept
the patch.

>
> On 2019/6/26 21:30, Axel Lin wrote:
> > Since devm_regmap_init_mmio_clk can fail, add return value checking.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > Acked-by: Chen Feng <puck.chen@hisilicon.com>
> > ---
> > This was sent on https://lkml.org/lkml/2019/3/6/904
> >
> >   drivers/mfd/hi655x-pmic.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> > index 96c07fa1802a..6693f74aa6ab 100644
> > --- a/drivers/mfd/hi655x-pmic.c
> > +++ b/drivers/mfd/hi655x-pmic.c
> > @@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device=
 *pdev)
> >
> >       pmic->regmap =3D devm_regmap_init_mmio_clk(dev, NULL, base,
> >                                                &hi655x_regmap_config);
> > +     if (IS_ERR(pmic->regmap))
> > +             return PTR_ERR(pmic->regmap);
> >
> >       regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic-=
>ver);
> >       if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) {
> >
>