Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1684531ybd; Wed, 26 Jun 2019 23:20:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqxV0UzSP9MKL2ZNCQnvapRTKYgzpyYpd8E71cnekUArvpQB7mM+WjWwn9ojVY7t8ky3xtfT X-Received: by 2002:a17:90a:2641:: with SMTP id l59mr3720472pje.55.1561616409694; Wed, 26 Jun 2019 23:20:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561616409; cv=none; d=google.com; s=arc-20160816; b=sDHeawXRiT8wNavfX0biGxxn6R2XwUwuQfwkRPC6lasSREgsiaO97mNvLIO/bOGexJ z/ePD6ymmTSK4w3ZPq3G82aJFntjXMgkyH1pcYdPMe5YSYTANAFZJov9Ze6hmB+xi+Uz bIp2RPdg3RHAcFqeN+j78LoFtuEycKsOYvxnk8GBTOpYbDMxt5uqSE5Hc2YelKMQrOyE tl/slQbD0HXYs64CT5dBfqqHfNQeoAGMF0X8ugbkXRIwcI6gAfW0T62ksxcneOvNEP2w j7DUpkGnvwaDK/h+bloZyjbUAACR6GST8leF8j32R4j01yfYy0eHkCbo6cv04KPCLngV 90ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=qcdKUl4XVVIhPiQNKGSoasT6uALKyt6aJuMcP7wZok4=; b=QKshm7vRupiPSel5UVxoR+73kfQS130oUQMzNBWVDDSobVRcVfgWy4Jmz4PI0QGiWS Z/3YUtES38I07N8VaMWCWl4ubXIHyQnOQ1gsjh8nEwTludqXvdvnimVc+ev7DiR4V+Eo mw3eI/fvfu0qCnB/nnR6IMQhE+bJyl66XJdkk+CnPdX8HnviS5elq63+MRs8kPmwxiSh N2lZDlomSeqM+6DBmM6I79Fd6MosInNyrcvNfaAhTQweKZ5xslgBtw8GNiPXUM+S46UR Bf6uf64KDT+wf4jFdlEBH3VwbKUoQENethCDGN1zzHm4NqGPvkJpTypBHtdQG1csBZ6x 3ChA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 66si1453668plc.85.2019.06.26.23.19.51; Wed, 26 Jun 2019 23:20:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726401AbfF0GTs (ORCPT + 99 others); Thu, 27 Jun 2019 02:19:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60640 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbfF0GTr (ORCPT ); Thu, 27 Jun 2019 02:19:47 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8751519CB81; Thu, 27 Jun 2019 06:19:47 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-96.ams2.redhat.com [10.36.116.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02C9760856; Thu, 27 Jun 2019 06:19:45 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8730911AAF; Thu, 27 Jun 2019 08:19:42 +0200 (CEST) Date: Thu, 27 Jun 2019 08:19:42 +0200 From: Gerd Hoffmann To: Tina Zhang Cc: intel-gvt-dev@lists.freedesktop.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, zhi.a.wang@intel.com, kevin.tian@intel.com, hang.yuan@intel.com, alex.williamson@redhat.com Subject: Re: [RFC PATCH v3 1/4] vfio: Define device specific irq type capability Message-ID: <20190627061942.k5onxbm27dju3iv5@sirius.home.kraxel.org> References: <20190627033802.1663-1-tina.zhang@intel.com> <20190627033802.1663-2-tina.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190627033802.1663-2-tina.zhang@intel.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 27 Jun 2019 06:19:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > +struct vfio_irq_info_cap_type { > + struct vfio_info_cap_header header; > + __u32 type; /* global per bus driver */ > + __u32 subtype; /* type specific */ Do we really need both type and subtype? cheers, Gerd