Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1700950ybd; Wed, 26 Jun 2019 23:40:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzr4bHhdKCyzqVnr9Jh/jdCL5v5hhbfTyzMU1rcjhujcmu/hpkURBU7cD+h+E/M41y6Wge7 X-Received: by 2002:a17:90a:2768:: with SMTP id o95mr4039215pje.37.1561617627050; Wed, 26 Jun 2019 23:40:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561617627; cv=none; d=google.com; s=arc-20160816; b=y3XbV9B9S9mO0Fj3AeUyB7gFVF6CzLWsbBlAgVQjokC6diRDNVtqV3VEgi20Gm7Ai9 3ww9vAv681i5tEvNZ4yuU5lYXNPWq5QlNDVPIfa8a3c5Zzs0NtL28egMhXLrfgglQ9sn pjS9WkWb/kl1dqMxzVFRD5Rl0d0CSHucfJlinQP3/bQwkhjcic3md4oFoXgCPqSzSGzS OEIojQiz8DfLc3+yvK71iFpX27/8O9s5ZK9p8RolbsBkQvbZ1ryVzmFEO2zouz5El8SR I/QMxjjGmS1FTyH6FMgErUz8+j1p9FdP9HKSswV1bF1YAFrpTEMZ49cN3ozzPP9Gxi8D Xb/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=YjE7SJlOZfPWmKNq+pc874QvmZFRvtKwDqs9768+UBw=; b=P9mXQXNKtWu4Ln6qEhwNqsm3hJfPZfNjk+dYACXuDvzknknS8zOKpCk2m2LGLYv5Af m5yNBBbk/hAh2a7VqcaDVBybs1k+nlNJG2XfnoBf/bX7GQkehFpUkosEm44pLGxuSVOV uTwG/a/mNtblx4FLM9alFsCFbviNd8FOUPBpI93r1XZgk/OnyXzDJi6qXMJDwqeCHp1/ h0e+1rQbEHxAAS4yVQcngUvKxEyDMG1orBKhFksSNXx2AFcPKyJ/RzAzMtqRqptMW05c 8HUSIbOBdxbglTu56o/wG/C3t+UjmLfzeVY5hJMCK4qhzTGOzBPXB9QSi7mZmIknflkc 0kHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="Ur+/R8g8"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u18si1470061plq.311.2019.06.26.23.40.10; Wed, 26 Jun 2019 23:40:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="Ur+/R8g8"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbfF0Gix (ORCPT + 99 others); Thu, 27 Jun 2019 02:38:53 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:56740 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbfF0Giw (ORCPT ); Thu, 27 Jun 2019 02:38:52 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5R6XYRU021300; Thu, 27 Jun 2019 06:38:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=YjE7SJlOZfPWmKNq+pc874QvmZFRvtKwDqs9768+UBw=; b=Ur+/R8g8sLOoHPLlPb5tKBzZ3Wn/y6j1O5ba8ytsuug07ZYHmbUHMO0+sttZpVHmuClM 2gvndOqExUQk2BIn+4Z+A7GDLMvsu8CgcX4oxXVSwxyFIvoz3FFWh7IYkMbJr9iLlxVV R715OAl4e80r7O8ukIhK+FKrCKvUBcXGC3omhgd6Q6K/c286F+6OP8FOBSbl9YJP2I9s m9s92zRZ0fNVmcf7Go8gUmjokYP5zP+T3yg9F7GXt/Y4PuK9rT8NZ7OOscKWX5XSj+yK N1C5+NqnFhcNfunx91hQOxjH8Lp87JgZeBjf8kWh7qDMv7fLMUqD/pbX1hDJD19mrxkx UQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2t9brtec1q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Jun 2019 06:38:44 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5R6bu9v030198; Thu, 27 Jun 2019 06:38:43 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2t9acd2t5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Jun 2019 06:38:43 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5R6cfRl009357; Thu, 27 Jun 2019 06:38:42 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 26 Jun 2019 23:38:41 -0700 Date: Thu, 27 Jun 2019 09:38:35 +0300 From: Dan Carpenter To: Hariprasad Kelam Cc: Greg Kroah-Hartman , Nishka Dasgupta , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: hal: sdio_halinit: Remove set but unused varilable pHalData Message-ID: <20190627063835.GH28859@kadam> References: <20190626174459.GA8539@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190626174459.GA8539@hari-Inspiron-1545> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9300 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=959 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906270076 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9300 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906270075 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 26, 2019 at 11:14:59PM +0530, Hariprasad Kelam wrote: > @@ -1433,7 +1430,6 @@ static void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val) > #endif > #endif > > - pHalData = GET_HAL_DATA(padapter); > > switch (variable) { We need to delete one of those blank lines or it introduces a new checkpatch warning. regards, dan carpenter