Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190522011504.19342-1-zhang.chunyan@linaro.org>
 <20190522011504.19342-2-zhang.chunyan@linaro.org> <20190626181637.CFA6321726@mail.kernel.org>
In-Reply-To: <20190626181637.CFA6321726@mail.kernel.org>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Thu, 27 Jun 2019 15:52:42 +0800
Message-ID: <CAAfSe-v6F-8F5YtunuHVmZVrGh5vAAFbkYLP1kThqoJd04BmBw@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] clk: sprd: Switch from of_iomap() to devm_ioremap_resource()
To:     Stephen Boyd <sboyd@kernel.org>
Cc:     Chunyan Zhang <zhang.chunyan@linaro.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 27 Jun 2019 at 02:16, Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Chunyan Zhang (2019-05-21 18:15:01)
> > devm_ioremap_resources() automatically requests resources and devm_ wrappers
> > do better error handling and unmapping of the I/O region when needed,
> > that would make drivers more clean and simple.
> >
> > Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
>
> Applied to clk-next
>
> > diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c
> > index e038b0447206..9ce690999eaa 100644
> > --- a/drivers/clk/sprd/common.c
> > +++ b/drivers/clk/sprd/common.c
> > @@ -50,7 +51,11 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
> >                         return PTR_ERR(regmap);
> >                 }
> >         } else {
> > -               base = of_iomap(node, 0);
> > +               res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +               base = devm_ioremap_resource(&pdev->dev, res);
> > +               if (IS_ERR(base))
>
> There's also devm_platform_ioremap_resource() if you want to save even
> more lines!

Yes indeed, thanks for the information.
Considering this patch was queued to your tree, I decide to use this
more integrated function later :)

Cheers,
Chunyan

>
> > +                       return PTR_ERR(base);
> > +