Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1943555ybd; Thu, 27 Jun 2019 04:15:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqy7obFnGC+h4WC4s9cNbyBTWrhAbcz8F/ujVtViQFaWHnWVa41djdCtk4o18nB2WJofYMkz X-Received: by 2002:a17:90b:f0f:: with SMTP id br15mr5435211pjb.101.1561634158585; Thu, 27 Jun 2019 04:15:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561634158; cv=none; d=google.com; s=arc-20160816; b=DIwxZ1VM/6TnH+OW02K06eTl+Q7Ls2UE6RZQKkbSv7ION8W5nm+oYBiQ5jecFm5EaH 23ukpRcEMcVTOGQUHHnLSt6fe/g13m8egYPA9XNrknNEM/1iLZHuQ+Dx9Npld9eX6ESM gHauSJXskci72l+wG/nIyCpEhY9Gl2lsKdKbc1K6RzqjQVniLs+dTKzwcmPep9uvGF2k BgiOOkDLeBsxghZNyg2ngswLQwQjXlP7bAbBrk78jbtA1Orr8yfcHQGyQ/UpAuSt7wcZ dOfTJknhoHDuTV3+PrBCIjC5TuAUsGxXRcbNQuI+dA/omqG0HovuG1Vinv8lKivwCfyG ++Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=5TqvPz8DpORGx1+vi8ExXWSK0FXpNg/HXwHTY32b52w=; b=bEkCM9lWYHW89qOlw3rIF1KAOuAnsHJZeB44wcTXbbYRcYgPY5v7D1K9PRiheRFv6q 8efoVpjfj5fp35DoaWlCsiX8s7hKKroQjRoDbj5iJ5Cb/zwVxXaR1D2fZd01oW2P9+kF CxwoOI71J2xTQ/A/Q2V97E5qWnD/i1R0OO0kMy7vUgZl8OVawHiOYeJxAgkojuiLxa+b BvZ3Qxeeh6gu2ZXkvgYnQA3ypNUh85Gr5vn47d8xI+R2AZq4HAg/ApJ7rX/SmyiLhYCI qk9YvuA5hgtqfi2BCtR49+expoBV5nhQk8duNeYP/fr+PWYk1Q0u42dnHnroNRc+DBOU 7U1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Oh8LTD8m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w5si4866779pjt.86.2019.06.27.04.15.41; Thu, 27 Jun 2019 04:15:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Oh8LTD8m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726497AbfF0LPM (ORCPT + 99 others); Thu, 27 Jun 2019 07:15:12 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:45670 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbfF0LPL (ORCPT ); Thu, 27 Jun 2019 07:15:11 -0400 Received: by mail-lj1-f195.google.com with SMTP id m23so1885783lje.12 for ; Thu, 27 Jun 2019 04:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5TqvPz8DpORGx1+vi8ExXWSK0FXpNg/HXwHTY32b52w=; b=Oh8LTD8m7IDgDorBBc7V+VvCco9ShEfKtubYx65x1T5UADxUHneIwXm5D34fbeGt8A ixjCx/VH3pF/bQ6ZHMg9PHCQmjkpCAiXVk/t5qsh/Qqm5tx9SPGzVhjOT8gQTzjQQrfi lAGtQ9fEG9oF9K1v8oeREAXC0uuw/SL0BJN950l/xiDxO5+wGYpYmT+5VPl0QUp7nSue aAMKG7ngQmAlBgnfr7IMamGqNGSDVnT6ZsHyoFmoAYfgNHCqJ4qfQ4AxjZkWYV30/+vx p6K15ZkS7XsSbBvwsLCURk/PDZbWbvX4UVyTadC7wxBwmODusUKB4z9LZEZdJG1mVlPF JTEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5TqvPz8DpORGx1+vi8ExXWSK0FXpNg/HXwHTY32b52w=; b=dLLOAwkxFdVcwV1w5lyxKVonLSj4Hd0KUn9QXXVQjrbPNZHkxfRTbX5+S4A9/5PQEm dwfE+UVWbUMIQlwf4XnpwbvM2nvxW8CZdBz3zm63I3Oax7T1FNxKds6cE2Ra3P9hwUZo 2gtix27CmKHonPyVrVny302iz159CBA6e1TQe78fuYWyueSIrvhiha/euLpF8mpmwEQ7 0fyohSvZFi02pkHCKhKUm+o5HrB8DA05nbgwwVDI/Nq+sKm+WQ6Ez5p+zBqxacVM80Vu 4pHdRuYrc2UeQTd3d7jxivfknH7VbLffcGXxwGaHat2qlUY93YxWqXQZqFcAxAto0EVs XO/A== X-Gm-Message-State: APjAAAWu5cTC6BJnBLvqf2zRJr/YTuTg4qeOUu13F0WP3SIGK2BNmHe1 xg0rj0+L1o+Bsk8GIDKuQMCkjARexgRNIjvM6z/sUQ== X-Received: by 2002:a2e:a0cf:: with SMTP id f15mr2303238ljm.180.1561634109728; Thu, 27 Jun 2019 04:15:09 -0700 (PDT) MIME-Version: 1.0 References: <20190625163434.13620-1-brgl@bgdev.pl> <20190625163434.13620-4-brgl@bgdev.pl> In-Reply-To: <20190625163434.13620-4-brgl@bgdev.pl> From: Linus Walleij Date: Thu, 27 Jun 2019 12:14:58 +0100 Message-ID: Subject: Re: [PATCH 03/12] backlight: gpio: pull the non-pdata device probing code into probe() To: Bartosz Golaszewski Cc: Sekhar Nori , Kevin Hilman , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , David Lechner , Linux ARM , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" , linux-fbdev@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 25, 2019 at 5:34 PM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > There's no good reason to have the generic probing code in a separate > routine. This function is short and is inlined by the compiler anyway. > Move it into probe under the pdata-specific part. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij Yours, Linus Walleij