Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1954507ybd; Thu, 27 Jun 2019 04:27:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFazDWeREW5nZEJdjtcKFt68l2f6lkWgivesIQg3nkr3mEj6J4E1d/sd5u1cT8UkuR3tRC X-Received: by 2002:a17:902:1486:: with SMTP id k6mr3982787pla.177.1561634858861; Thu, 27 Jun 2019 04:27:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561634858; cv=none; d=google.com; s=arc-20160816; b=tBAmPfQUlSFIiWhouLOtZw4h2+3ivUrGwMqAxPzH9H3uyY9XPW35mEU2+8B8ie8wKp 9GPFDt8PzcUAw0QvtiT5gTRA13Xp/aDRUvv5eDulCkmw/4qc2vkYIbeq5MOM/XQIYfPS U41qdzN1SKX3lZB3fvDncjRY6Hpi8ytMt/1uMr6vH7t6dgpF6DFWqTrkGWQ0zGQkJ7Cf WmgYfWmEzEW2hKH/YSDhixBtH4abZ369DNVs6B82egCey3yVuZEG9q8TLdtEYHqh4pKg Ysd+Chbp1SlIZgkmeArwpzGJbfyuDctH/OCRpy35Jv8M4Eo8rxeJnGSGYdfflMfUW42H +hhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=+uxeEEQjEVDK3nm13bd6qaNEmjtzRjx1xD5XFu/UxWs=; b=tssxxh8+wFHXPfbHqeLZX3db1O/OhpgJgOpz46aS8k4ULlDZYXjSu0y6nYKtK1Emov MBWBL7fAwfN9lsYmJ/BE5wjX8vlisvek/WRMoaGdr4Yg8JtW7xlvXtpPDhZhrjmsSByV qNpPJKC8I+uqRZ6rT0V63W75znNvJ2hduFO67AV+xKCwTx8pTOqz9jcvW3r4MhP6LrBN 5nCunysyGuHxKF//g7XDmhyj7fBHIlGu93gh5pVmhvkbbiM0MO/7Lc1bOweslEDtJCTQ uJIzxeJuW7SKcGfUfZiOtlg+suKNVXKOX/djpL/0dJWEvOkUvIIIuSrFOeytQu10pD5q 2LWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si1974663pgi.218.2019.06.27.04.27.22; Thu, 27 Jun 2019 04:27:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726663AbfF0L1L (ORCPT + 99 others); Thu, 27 Jun 2019 07:27:11 -0400 Received: from mga04.intel.com ([192.55.52.120]:32328 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726429AbfF0L1L (ORCPT ); Thu, 27 Jun 2019 07:27:11 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 04:27:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,423,1557212400"; d="scan'208";a="183428592" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 27 Jun 2019 04:27:07 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 27 Jun 2019 14:27:06 +0300 Date: Thu, 27 Jun 2019 14:27:06 +0300 From: Mika Westerberg To: Charles Keepax Cc: wsa@the-dreams.de, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com Subject: Re: [PATCH v8 3/6] i2c: acpi: Factor out getting the IRQ from ACPI Message-ID: <20190627112706.GD2640@lahna.fi.intel.com> References: <20190627092411.26123-1-ckeepax@opensource.cirrus.com> <20190627092411.26123-4-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190627092411.26123-4-ckeepax@opensource.cirrus.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 27, 2019 at 10:24:08AM +0100, Charles Keepax wrote: > In preparation for future refactoring factor out the fetch of the IRQ > into its own helper function. Whilst we are at it update the handling > to return the actual error code returned from acpi_dev_get_resources > as well. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Charles Keepax Reviewed-by: Mika Westerberg