Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2010365ybd; Thu, 27 Jun 2019 05:22:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqwgQ2B5NFRGjxNCz7NrGbw1BCPLRr2JIpXKgomv1uQ7n0RUFS/+dacH80uiBPrcLYz3iTPD X-Received: by 2002:a63:b547:: with SMTP id u7mr3681725pgo.322.1561638151015; Thu, 27 Jun 2019 05:22:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561638151; cv=none; d=google.com; s=arc-20160816; b=BAARNpC6/9vi1qsBs6XACTw2594mjoVw14d33OpFbcAIOPsy0iKg/Cljmn2PYzpxdW Rki9jnf/6LUCh/9nGYRgG4cfhTiLoOOx3eIPdUnWNuwIUDAvK+FxSdQoxFy6bm5BGmYW SIkul/Z/5/kauop9OkgfvpPHQ2bAZ7T7+OjG5xR2GBIu+Xdk4QtQ81qlovL1URQ4vb2i yJBzrybX8QPqaBw/Ie2ntwMwcj3oyD+nv9PhaCUjCCDYRbp7r0i8/NB9DxtTZe1ozPdP kOjAUzbSo9U6POxxlTeBxa1SaKGXr21g66Ej7Dt1Rwz7pJ7NYpt+p04CCemQwSN9QGND XcpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature :dkim-signature; bh=ZRXagN1vk0EdEW/aB7NmDpXGCkwVxYEqHwmBLJ36cnk=; b=LdSfNfWkmjm94k5IVTqKbepKojWOHaE/sVruwMsnlAOYKq12jUA6JItAl2sxaFRoH8 RMar1QJ4CyLawyJzDoM7MuFjfe7AASDmEJ8A9WGsvVPUQTXPvyIdVgDVNOGAukSARFkV 489fLyf0WqJAzbQ+3+x+TnQEc6G6Qj+DAOi3MBVyByfMmLe+GJkY/PnItbZMylq31RjB 4U4Emuqngf5xAm9zyGIZFfOx5RtfrwYLM9QNsuiWarIGmxiku23nZ33d1ki17o96KNO1 mcwwfYPZGQy5ylpmdYlnWJGizgqpOQ45VrufEeq4XGYogioREffYiXHs6QvF/XP3MJx4 4sLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=ghSxDRVJ; dkim=fail header.i=@synopsys.onmicrosoft.com header.s=selector1-synopsys-onmicrosoft-com header.b=RTBRY+TU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k16si2241987pls.326.2019.06.27.05.22.12; Thu, 27 Jun 2019 05:22:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=ghSxDRVJ; dkim=fail header.i=@synopsys.onmicrosoft.com header.s=selector1-synopsys-onmicrosoft-com header.b=RTBRY+TU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbfF0MVQ (ORCPT + 99 others); Thu, 27 Jun 2019 08:21:16 -0400 Received: from smtprelay-out1.synopsys.com ([198.182.47.102]:39204 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726431AbfF0MVQ (ORCPT ); Thu, 27 Jun 2019 08:21:16 -0400 Received: from mailhost.synopsys.com (dc8-mailhost2.synopsys.com [10.13.135.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id E47BBC0BF3; Thu, 27 Jun 2019 12:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1561638075; bh=1VXyV86FgsHJwwFrgL1rUBPUlssZ+p7EZ8+A4dnJKPU=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=ghSxDRVJlK/wQlVh696LFB5YIO3ofztnWDxDn1wlZEoyoQ0hlpdpwCz2ctLAp5tmB 9osY5nSJ600TjeYzzqSpCRy7RxDbxXNjcHAnBl4+cqpTa2p0L5ivTMdv6qLUutQw3f dAaSzdueCSWxcdvPMlL7jawDDUPAUImS/i0eHzx08J6I5wmT0myo/I7zryG5aQ0AUV L5WkCQnJocXDpxj/OvS0mswmFoOQEZiQY99X0ZixF3uO3ogMZSbT6FvcvcvIgR78IV ZoOswM4YyRtTxMiGvdhsQsRmlI6quQ+oBnr4V+s4Y5Kd1iaCbt8Bi5Gns8e2bEHSB5 DpSqEfuE6E9hg== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 32447A0065; Thu, 27 Jun 2019 12:21:14 +0000 (UTC) Received: from US01HYBRID2.internal.synopsys.com (10.15.246.24) by us01wehtc1.internal.synopsys.com (10.12.239.231) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 27 Jun 2019 05:21:13 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (10.13.134.195) by mrs.synopsys.com (10.15.246.24) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 27 Jun 2019 05:21:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=synopsys.onmicrosoft.com; s=selector1-synopsys-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZRXagN1vk0EdEW/aB7NmDpXGCkwVxYEqHwmBLJ36cnk=; b=RTBRY+TUolhGMAZOt2cAGOYzWPXBxlvim42OoF8Rgkyu42ebVpG5CAfZjT/z+zQTETeHhEl5RKOwjAmOn+Cs/G218wUt/1r+Y3ji7TRV+nbxbCf2u/Iy3GRTxuri9lpRKI2kPhOPlZ1flfy0SsdsiI3zfExxWoLpqYpyLIOlbVg= Received: from BN8PR12MB3266.namprd12.prod.outlook.com (20.179.66.159) by BN8PR12MB3172.namprd12.prod.outlook.com (20.179.64.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Thu, 27 Jun 2019 12:21:12 +0000 Received: from BN8PR12MB3266.namprd12.prod.outlook.com ([fe80::c922:4285:22a6:6e]) by BN8PR12MB3266.namprd12.prod.outlook.com ([fe80::c922:4285:22a6:6e%5]) with mapi id 15.20.2008.018; Thu, 27 Jun 2019 12:21:11 +0000 From: Jose Abreu To: Voon Weifeng , "David S. Miller" , Maxime Coquelin CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Giuseppe Cavallaro" , Andrew Lunn , "Florian Fainelli" , Alexandre Torgue , Vinicius Costa Gomes , Ong Boon Leong Subject: RE: [RFC net-next 1/5] net: stmmac: introduce IEEE 802.1Qbv configuration functionalities Thread-Topic: [RFC net-next 1/5] net: stmmac: introduce IEEE 802.1Qbv configuration functionalities Thread-Index: AQHVJdrSnKdXMM/880K7fuGYVs8ARaavd29g Date: Thu, 27 Jun 2019 12:21:11 +0000 Message-ID: References: <1560893778-6838-1-git-send-email-weifeng.voon@intel.com> <1560893778-6838-2-git-send-email-weifeng.voon@intel.com> In-Reply-To: <1560893778-6838-2-git-send-email-weifeng.voon@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=joabreu@synopsys.com; x-originating-ip: [83.174.63.141] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6280d005-c47f-4b8e-eb61-08d6faf9f12d x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:BN8PR12MB3172; x-ms-traffictypediagnostic: BN8PR12MB3172: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 008184426E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(136003)(39860400002)(366004)(376002)(346002)(189003)(199004)(11346002)(7416002)(9686003)(4744005)(55016002)(68736007)(99286004)(66066001)(53936002)(486006)(76176011)(86362001)(446003)(229853002)(476003)(6506007)(52536014)(5660300002)(7696005)(102836004)(66476007)(66556008)(66946007)(73956011)(66446008)(64756008)(6436002)(26005)(76116006)(186003)(2906002)(256004)(8676002)(110136005)(316002)(8936002)(81156014)(81166006)(54906003)(25786009)(74316002)(305945005)(7736002)(71200400001)(71190400001)(478600001)(3846002)(6116002)(14454004)(4326008)(33656002)(6246003);DIR:OUT;SFP:1102;SCL:1;SRVR:BN8PR12MB3172;H:BN8PR12MB3266.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: synopsys.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: uXS0xMVDQl0PF8jBxyI4R3aDxIa2Cqp6wwo2kBPz5GtCFckhoQWoVeDzlOuHcF5MxQawV5uKkKCHB3PcMO1T8IbyhxmoWM+hdC8bpekWQGgNYNwCgoFQskZowHd+70/UnHd0xlaZcOXs0tUEidCn7gsDGyCw85Ae7t9vNCH9IvV6+LfDo3j/dA1qwOilo/3qjqgXcjjJJ0tLhhgQ/P1ku21IZKDCo8MhfJf0xRRdosf7kpeSCXUGLUZVHerxA68eJxriJkFvouvfn+CjLIppbdO7eGyzY1aBfhCl530/FGsDZaP+e73Uv+2IKWcwYWjAx16NEGcqpQj9cxrLR+Yjzb5ZiLFyIiB8hSebQTYbuCLteiwzWIxxWkpao9xMjVV84n3lGI/pv7uiUbUDqvjKsuInL5sKbfV/9Pwrk3dB7J4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6280d005-c47f-4b8e-eb61-08d6faf9f12d X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2019 12:21:11.8083 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: joabreu@synopsys.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3172 X-OriginatorOrg: synopsys.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Voon Weifeng > diff --git a/drivers/net/ethernet/stmicro/stmmac/dw_tsn_lib.c b/drivers/n= et/ethernet/stmicro/stmmac/dw_tsn_lib.c > new file mode 100644 > index 000000000000..cba27c604cb1 > --- /dev/null > +++ b/drivers/net/ethernet/stmicro/stmmac/dw_tsn_lib.c XGMAC also supports TSN features so I think more abstraction is needed=20 on this because the XGMAC implementation is very similar (only reg=20 offsets and bitfields changes). I would rather: - Implement HW specific handling in dwmac4_core.c / dwmac4_dma.c and=20 add the callbacks in hwif table; - Let TSN logic in this file but call it stmmac_tsn.c. > @@ -3621,6 +3622,8 @@ static int stmmac_set_features(struct net_device *n= etdev, > */ > stmmac_rx_ipc(priv, priv->hw); > =20 > + netdev->features =3D features; Isn't this a fix ?