Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2084367ybd; Thu, 27 Jun 2019 06:32:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhde2FSAnG+XQvSS5YdtR9XcVReqn3j/cRWiVextcBaSgjHhMmNLUCrFHUS1AJZm1HR8on X-Received: by 2002:a63:4e58:: with SMTP id o24mr3767833pgl.366.1561642328041; Thu, 27 Jun 2019 06:32:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561642328; cv=none; d=google.com; s=arc-20160816; b=NOLn/YNfZM7kSHeOmsPrvlYkLJhZhvTOiDDbdEJkR2KiN3KpNZ/XuWmlXuQum9pHEN It9Se5JObdFAlViWk9AjppqlsgzDCm4aW6XNyIewbjZn/5nS2Zw02b5Qg8L1PVWCyqZy gjTfIrWqcZPZ3S7dYlwCXvgeIv+EGoh9nFsWH4NjEJDPS8VRbSgJTxhDEzRpqsWZ9Dbr eMivJp9b03gKBEZBZiYwTYzXeOgh5/mCq8ApG2Nj0sb93Cwl+jMDkoDinqros09RI91Z GRSl7LY2HpAs1BXbPtxLxF6R8jo4vHyCaPfiMa+cdW3bc8eP8/rxqEIRMTAtX81j0M68 KsJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bbYrjwHXJqiMsGuqj1zgA9NwpJhH7d+2wc890aAsl00=; b=tEZoUooT/Wh6JU+kyPqZLyLPzSxncTRGmauvIzUl8ZDT1pezV25DUnhfBBWlUKmoWG t7+/HIqGh+uvFBDs2Hu6Hjfhkk3M8RBYynFGJs6I8IhTQIgkJp0f2kZuuXvaZ/u/4U6N gyIt0dNVMg7NpxpP7ilwSjCa6//eCyn79KCuweOy3rHCQXBF9CpqC5Yatg1PA/30pBur jAd754HfvP5VlYewckNZq7iZrcjX1tnNM7E5Nkpg2q74zrRWDQLLmdmDlSwHgDs++onU gLpeYNIrVXkF6FxiNo1+xA3XY2TdSXT1XDD7avUU7WSdAjxx0WdSPGlDKc1zmy9XGs5f 5PIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nO5Os47p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id br15si4845264pjb.43.2019.06.27.06.31.50; Thu, 27 Jun 2019 06:32:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nO5Os47p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726690AbfF0NaK (ORCPT + 99 others); Thu, 27 Jun 2019 09:30:10 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40886 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726472AbfF0NaK (ORCPT ); Thu, 27 Jun 2019 09:30:10 -0400 Received: by mail-wm1-f65.google.com with SMTP id v19so5689008wmj.5 for ; Thu, 27 Jun 2019 06:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bbYrjwHXJqiMsGuqj1zgA9NwpJhH7d+2wc890aAsl00=; b=nO5Os47pOlhih/DxECOGkBUdP0PXcYx6vg/vZU54lwJU59dZEDWjWj/wt2Jml1BuB9 +xoPB6fGqbtnIHnJtvRZyVgd4zenYWr3e8Si3Ic+IrPYLYzQrMJEwSlOL1zXuKo+dl6Y A7/W+p6pWMaRN1+FHQmm03oVZynY5OeAHaaEknzvBFTqzd10MMmMwxGYBmsBHZSBMJxP uC0qkNV3fw3KEaVto2Enxm21RlgETtiF4a8RsE/tSKcGKHI6e5dRpibzwUMkXyCuSQSR CBYSUjYi4LFw1C4MmffB6/4XhUEpAASpe6Y2IfjYtKMG9z2xswedDy9AOgoLYxs/CBtW uMLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bbYrjwHXJqiMsGuqj1zgA9NwpJhH7d+2wc890aAsl00=; b=iVnvepxWBV73QSab/W8DMYyG60IItYmDKCRVRFTLnnB3oPvuTid7LlssHeEvoU03ox BiVpjmaCOzweHM7gmIoajhS76uFLybfnR4kWq+mK8EZmVLMIWnW5ml1XFvxze7pmGQXb t3NnTm4H51dLjsCIe2RuP/9VbuRbtPozjH3rATResPFfZFCQqgcQsViw1QcWObSl+6Tw gih4mI3meThzhZ385rmlMQFFPQdBqKD+Df2ugDCjtZ1utTVjsKtJED9K4bX64icTtTbh y9EjHXmDyIERRorUp/DLa1DFoaMctw+/yMREKlIIvL9krZBWHcqA/p/d748asPWueoCr g49w== X-Gm-Message-State: APjAAAWM765WQam9qGniDn1QPScUC94/DmTC6gApyAhB7t2tiwOQ+jyT 55rhiWatz74hsjIoPbzZfaCvfg== X-Received: by 2002:a1c:5602:: with SMTP id k2mr2208144wmb.173.1561642207629; Thu, 27 Jun 2019 06:30:07 -0700 (PDT) Received: from apalos (athedsl-4461147.home.otenet.gr. [94.71.2.75]) by smtp.gmail.com with ESMTPSA id x20sm5380562wrg.52.2019.06.27.06.30.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 06:30:07 -0700 (PDT) Date: Thu, 27 Jun 2019 16:30:04 +0300 From: Ilias Apalodimas To: Jarkko Sakkinen Cc: Sasha Levin , peterhuewe@gmx.de, jgg@ziepe.ca, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@microsoft.com, thiruan@microsoft.com, bryankel@microsoft.com, tee-dev@lists.linaro.org, sumit.garg@linaro.org, rdunlap@infradead.org Subject: Re: [PATCH v7 1/2] fTPM: firmware TPM running in TEE Message-ID: <20190627133004.GA3757@apalos> References: <20190625201341.15865-1-sashal@kernel.org> <20190625201341.15865-2-sashal@kernel.org> <673dd30d03e8ed9825bb46ef21b2efef015f6f2a.camel@linux.intel.com> <20190626235653.GL7898@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jarkko, > On Wed, 2019-06-26 at 19:56 -0400, Sasha Levin wrote: > > > You've used so much on this so shouldn't this have that somewhat new > > > co-developed-by tag? I'm also wondering can this work at all > > > > Honestly, I've just been massaging this patch more than "authoring" it. > > If you feel strongly about it feel free to add a Co-authored patch with > > my name, but in my mind this is just Thiru's work. > > This is just my subjective view but writing code is easier than making > it work in the mainline in 99% of cases. If this patch was doing > something revolutional, lets say a new outstanding scheduling algorithm, > then I would think otherwise. It is not. You without question deserve > both credit and also the blame (if this breaks everything) :-) > > > > process-wise if the original author of the patch is also the only tester > > > of the patch? > > > > There's not much we can do about this... Linaro folks have tested this > > without the fTPM firmware, so at the very least it won't explode for > > everyone. If for some reason non-microsoft folks see issues then we can > > submit patches on top to fix this, we're not just throwing this at you > > and running away. > > So why any of those Linaro folks can't do it? I can add after tested-by > tag parentheses something explaining that context of testing. It is > reasonable given the circumstances. There's 2 teams from Microsoft trying to do this [1]. We tested the previous implementation (which problems on probing as built-in). We had to change some stuff in the OP-TEE fTPM implementation [2] and test it in QEMU. What i quickly did with this module was to replace the kernel of the previous build with the new one. Unfortunately i couldn't get it to work, but i don't know if it's the module or the changes in the fTPM OP-TEE part. Since you have tested it my guess is that it has something to do with the OP-TEE part. I don't have any objections in this going in. On the contrary i think the functionality is really useful. I don't have hardware to test this at the moment, but once i get it, i'll give it a spin. The part i tested is that the probing works as expected when no fTPM implementation is running on secure world. Since it has been tested and doesn't break anything we can always fix corner, cases afterwards with more extensive testing [1] https://github.com/ms-iot/linux/blob/ms-optee-ocalls-merge/drivers/char/tpm/tpm_ftpm_optee.c [2] https://github.com/jbech-linaro/manifest/blob/ftpm/README.md Thanks /Ilias > > I can also give an explanation in my next PR along the lines what you > are saying. This would definitely work for me. > > /Jarkko >